ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(input-amount): use minus sign unicode instead of hypen-minus

Browse source
This commit is contained in:
Joren Broekema 2019-09-19 16:01:20 +02:00
parent 85beb18e26
commit edd7396e15
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/input-amount/test/formatters.test.js
View file

@ -60,7 +60,7 @@ describe('formatAmount()', () => {
minimumFractionDigits: 2, minimumFractionDigits: 2,
maximumFractionDigits: 2, maximumFractionDigits: 2,
}), }),
).to.equal('-12.35'); ).to.equal('−12.35');
}); });
it('formats the right amount of fraction digits for a certain currency', async () => { it('formats the right amount of fraction digits for a certain currency', async () => {

8
packages/localize/src/number/formatNumberToParts.js
View file

@ -29,12 +29,8 @@ export function formatNumberToParts(number, options) {
const regexSymbol = /[A-Z.,\s0-9]/; const regexSymbol = /[A-Z.,\s0-9]/;
const regexCode = /[A-Z]/; const regexCode = /[A-Z]/;
/** // U+002D, Hyphen-Minus, -
* TODO: Preprocessor should convert other "dashes" unicodes to − const regexMinusSign = /[-]/;
* Then our regex should test for −
* See also https://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/
*/
const regexMinusSign = /[-]/; // U+002D, Hyphen-Minus, - is what we test on for now, since most keyboards give you this for dash
const regexNum = /[0-9]/; const regexNum = /[0-9]/;
const regexSeparator = /[.,]/; const regexSeparator = /[.,]/;