From edd7396e153b012f90308fa5af3fb0ff2aa9c503 Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Thu, 19 Sep 2019 16:01:20 +0200 Subject: [PATCH] fix(input-amount): use minus sign unicode instead of hypen-minus --- packages/input-amount/test/formatters.test.js | 2 +- packages/localize/src/number/formatNumberToParts.js | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/input-amount/test/formatters.test.js b/packages/input-amount/test/formatters.test.js index c7ab4adb3..dbd03a7db 100644 --- a/packages/input-amount/test/formatters.test.js +++ b/packages/input-amount/test/formatters.test.js @@ -60,7 +60,7 @@ describe('formatAmount()', () => { minimumFractionDigits: 2, maximumFractionDigits: 2, }), - ).to.equal('-12.35'); + ).to.equal('−12.35'); }); it('formats the right amount of fraction digits for a certain currency', async () => { diff --git a/packages/localize/src/number/formatNumberToParts.js b/packages/localize/src/number/formatNumberToParts.js index 1d2f0bcac..d89cc0df8 100644 --- a/packages/localize/src/number/formatNumberToParts.js +++ b/packages/localize/src/number/formatNumberToParts.js @@ -29,12 +29,8 @@ export function formatNumberToParts(number, options) { const regexSymbol = /[A-Z.,\s0-9]/; const regexCode = /[A-Z]/; - /** - * TODO: Preprocessor should convert other "dashes" unicodes to − - * Then our regex should test for − - * See also https://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/ - */ - const regexMinusSign = /[-]/; // U+002D, Hyphen-Minus, - is what we test on for now, since most keyboards give you this for dash + // U+002D, Hyphen-Minus, - + const regexMinusSign = /[-]/; const regexNum = /[0-9]/; const regexSeparator = /[.,]/;