ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1581 from remcovaes/fix/OverlayMixinTypeInfo

Browse source 
fix: type info in OverlayMixinTypes
This commit is contained in:
Thijs Louisse 2022-01-04 11:36:56 +01:00 committed by GitHub
commit c381be9c01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.changeset/grumpy-lemons-repeat.md Normal file
View file

@ -0,0 +1,6 @@
---
'@lion/overlays': patch
'@lion/select-rich': patch
---
Fix type information for the overlayMixin and remove obsolete toggle

1
packages/overlays/src/OverlayMixin.js
View file

@ -5,7 +5,6 @@ import { isEqualConfig } from './utils/is-equal-config.js';
/** /**
* @typedef {import('../types/OverlayConfig').OverlayConfig} OverlayConfig * @typedef {import('../types/OverlayConfig').OverlayConfig} OverlayConfig
* @typedef {import('../types/OverlayMixinTypes').DefineOverlayConfig} DefineOverlayConfig * @typedef {import('../types/OverlayMixinTypes').DefineOverlayConfig} DefineOverlayConfig
* @typedef {import('../types/OverlayMixinTypes').OverlayHost} OverlayHost
* @typedef {import('../types/OverlayMixinTypes').OverlayMixin} OverlayMixin * @typedef {import('../types/OverlayMixinTypes').OverlayMixin} OverlayMixin
*/ */

6
packages/overlays/types/OverlayMixinTypes.d.ts vendored
View file

@ -21,9 +21,9 @@ export declare class OverlayHost {
get config(): OverlayConfig; get config(): OverlayConfig;
set config(value: OverlayConfig); set config(value: OverlayConfig);
open(): void; open(): Promise<void>;
close(): void; close(): Promise<void>;
toggle(): void; toggle(): Promise<void>;
/** /**
* Sometimes it's needed to recompute Popper position of an overlay, for instance when we have * Sometimes it's needed to recompute Popper position of an overlay, for instance when we have
* an opened combobox and the surrounding context changes (the space consumed by the textbox * an opened combobox and the surrounding context changes (the space consumed by the textbox

5
packages/select-rich/src/LionSelectRich.js
View file

@ -247,11 +247,6 @@ export class LionSelectRich extends SlotMixin(ScopedElementsMixin(OverlayMixin(L
this._onFormElementsChanged(); this._onFormElementsChanged();
} }
// TODO: move to overlayMixin and offer open and close
toggle() {
this.opened = !this.opened;
}
/** /**
* In the select disabled options are still going to a possible value for example * In the select disabled options are still going to a possible value for example
* when prefilling or programmatically setting it. * when prefilling or programmatically setting it.