diff --git a/.changeset/grumpy-lemons-repeat.md b/.changeset/grumpy-lemons-repeat.md new file mode 100644 index 000000000..fa0fa8fe6 --- /dev/null +++ b/.changeset/grumpy-lemons-repeat.md @@ -0,0 +1,6 @@ +--- +'@lion/overlays': patch +'@lion/select-rich': patch +--- + +Fix type information for the overlayMixin and remove obsolete toggle diff --git a/packages/overlays/src/OverlayMixin.js b/packages/overlays/src/OverlayMixin.js index 6e6cbae4c..c207da793 100644 --- a/packages/overlays/src/OverlayMixin.js +++ b/packages/overlays/src/OverlayMixin.js @@ -5,7 +5,6 @@ import { isEqualConfig } from './utils/is-equal-config.js'; /** * @typedef {import('../types/OverlayConfig').OverlayConfig} OverlayConfig * @typedef {import('../types/OverlayMixinTypes').DefineOverlayConfig} DefineOverlayConfig - * @typedef {import('../types/OverlayMixinTypes').OverlayHost} OverlayHost * @typedef {import('../types/OverlayMixinTypes').OverlayMixin} OverlayMixin */ diff --git a/packages/overlays/types/OverlayMixinTypes.d.ts b/packages/overlays/types/OverlayMixinTypes.d.ts index 58ac0c2ff..f506a4699 100644 --- a/packages/overlays/types/OverlayMixinTypes.d.ts +++ b/packages/overlays/types/OverlayMixinTypes.d.ts @@ -21,9 +21,9 @@ export declare class OverlayHost { get config(): OverlayConfig; set config(value: OverlayConfig); - open(): void; - close(): void; - toggle(): void; + open(): Promise; + close(): Promise; + toggle(): Promise; /** * Sometimes it's needed to recompute Popper position of an overlay, for instance when we have * an opened combobox and the surrounding context changes (the space consumed by the textbox diff --git a/packages/select-rich/src/LionSelectRich.js b/packages/select-rich/src/LionSelectRich.js index a9593a481..792bb75ea 100644 --- a/packages/select-rich/src/LionSelectRich.js +++ b/packages/select-rich/src/LionSelectRich.js @@ -247,11 +247,6 @@ export class LionSelectRich extends SlotMixin(ScopedElementsMixin(OverlayMixin(L this._onFormElementsChanged(); } - // TODO: move to overlayMixin and offer open and close - toggle() { - this.opened = !this.opened; - } - /** * In the select disabled options are still going to a possible value for example * when prefilling or programmatically setting it.