fix(remark-extend): do not touch image urls
This commit is contained in:
parent
59dad2848d
commit
57ad1569e0
4 changed files with 12 additions and 16 deletions
5
.changeset/fifty-items-act.md
Normal file
5
.changeset/fifty-items-act.md
Normal file
|
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
'remark-extend': patch
|
||||||
|
---
|
||||||
|
|
||||||
|
Do not touch image urls
|
||||||
3
packages-node/remark-extend/docs/test.md
Normal file
3
packages-node/remark-extend/docs/test.md
Normal file
|
|
@ -0,0 +1,3 @@
|
||||||
|
## Test
|
||||||
|
|
||||||
|

|
||||||
|
|
@ -36,7 +36,6 @@ function handleImportedFile({
|
||||||
endSelector,
|
endSelector,
|
||||||
userFunction,
|
userFunction,
|
||||||
filePath,
|
filePath,
|
||||||
fileImport,
|
|
||||||
missingEndSelectorMeansUntilEndOfFile = false,
|
missingEndSelectorMeansUntilEndOfFile = false,
|
||||||
}) {
|
}) {
|
||||||
return tree => {
|
return tree => {
|
||||||
|
|
@ -81,10 +80,6 @@ function handleImportedFile({
|
||||||
if (insertIt && parent && parent.type === 'root') {
|
if (insertIt && parent && parent.type === 'root') {
|
||||||
toInsertNodes.push(node);
|
toInsertNodes.push(node);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (node.type === 'image') {
|
|
||||||
node.url = path.posix.join(path.dirname(fileImport), node.url);
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -82,7 +82,7 @@ describe('remarkExtend', () => {
|
||||||
[
|
[
|
||||||
'<h3>Static Headline</h3>',
|
'<h3>Static Headline</h3>',
|
||||||
'<h1>import me headline</h1>',
|
'<h1>import me headline</h1>',
|
||||||
'<p><img src="fixtures/my.svg" alt="my image">',
|
'<p><img src="./my.svg" alt="my image">',
|
||||||
'<a href="./import-me.md">link to</a></p>',
|
'<a href="./import-me.md">link to</a></p>',
|
||||||
'',
|
'',
|
||||||
].join('\n'),
|
].join('\n'),
|
||||||
|
|
@ -273,13 +273,11 @@ describe('remarkExtend', () => {
|
||||||
});
|
});
|
||||||
|
|
||||||
it('resolves imports via node resolution', async () => {
|
it('resolves imports via node resolution', async () => {
|
||||||
// NOTE: this test can easily break as it reads content from a 3rd. party package
|
|
||||||
// If that content changes the test should be adjusted
|
|
||||||
const result = await execute(
|
const result = await execute(
|
||||||
[
|
[
|
||||||
//
|
//
|
||||||
'### Static Headline',
|
'### Static Headline',
|
||||||
"```js ::importBlock('unified/readme.md', '## Install')",
|
"```js ::importBlock('remark-extend/docs/test.md', '## Test')",
|
||||||
'```',
|
'```',
|
||||||
].join('\n'),
|
].join('\n'),
|
||||||
);
|
);
|
||||||
|
|
@ -287,13 +285,8 @@ describe('remarkExtend', () => {
|
||||||
expect(result).to.equal(
|
expect(result).to.equal(
|
||||||
[
|
[
|
||||||
'<h3>Static Headline</h3>',
|
'<h3>Static Headline</h3>',
|
||||||
'<h2>Install</h2>',
|
'<h2>Test</h2>',
|
||||||
'<p>[npm][]:</p>',
|
'<p><img src="./some-image.svg" alt="some image" title="with alt"></p>',
|
||||||
'<pre><code class="language-sh">npm install unified',
|
|
||||||
'</code></pre>',
|
|
||||||
'<p>This package comes with types.',
|
|
||||||
'If you’re using TypeScript, make sure to also install',
|
|
||||||
'[<code>@types/unist</code>][ts-unist].</p>',
|
|
||||||
'',
|
'',
|
||||||
].join('\n'),
|
].join('\n'),
|
||||||
);
|
);
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue