diff --git a/.changeset/fifty-items-act.md b/.changeset/fifty-items-act.md new file mode 100644 index 000000000..a48c9e726 --- /dev/null +++ b/.changeset/fifty-items-act.md @@ -0,0 +1,5 @@ +--- +'remark-extend': patch +--- + +Do not touch image urls diff --git a/packages-node/remark-extend/docs/test.md b/packages-node/remark-extend/docs/test.md new file mode 100644 index 000000000..03710acb8 --- /dev/null +++ b/packages-node/remark-extend/docs/test.md @@ -0,0 +1,3 @@ +## Test + +![some image](./some-image.svg 'with alt') diff --git a/packages-node/remark-extend/src/remarkExtend.js b/packages-node/remark-extend/src/remarkExtend.js index ea1df50f5..95341bcce 100644 --- a/packages-node/remark-extend/src/remarkExtend.js +++ b/packages-node/remark-extend/src/remarkExtend.js @@ -36,7 +36,6 @@ function handleImportedFile({ endSelector, userFunction, filePath, - fileImport, missingEndSelectorMeansUntilEndOfFile = false, }) { return tree => { @@ -81,10 +80,6 @@ function handleImportedFile({ if (insertIt && parent && parent.type === 'root') { toInsertNodes.push(node); } - - if (node.type === 'image') { - node.url = path.posix.join(path.dirname(fileImport), node.url); - } }); }; } diff --git a/packages-node/remark-extend/test-node/remark-extend.test.js b/packages-node/remark-extend/test-node/remark-extend.test.js index 0d5e454f1..de141a2b2 100644 --- a/packages-node/remark-extend/test-node/remark-extend.test.js +++ b/packages-node/remark-extend/test-node/remark-extend.test.js @@ -82,7 +82,7 @@ describe('remarkExtend', () => { [ '

Static Headline

', '

import me headline

', - '

my image', + '

my image', 'link to

', '', ].join('\n'), @@ -273,13 +273,11 @@ describe('remarkExtend', () => { }); it('resolves imports via node resolution', async () => { - // NOTE: this test can easily break as it reads content from a 3rd. party package - // If that content changes the test should be adjusted const result = await execute( [ // '### Static Headline', - "```js ::importBlock('unified/readme.md', '## Install')", + "```js ::importBlock('remark-extend/docs/test.md', '## Test')", '```', ].join('\n'), ); @@ -287,13 +285,8 @@ describe('remarkExtend', () => { expect(result).to.equal( [ '

Static Headline

', - '

Install

', - '

[npm][]:

', - '
npm install unified',
-        '
', - '

This package comes with types.', - 'If you’re using TypeScript, make sure to also install', - '[@types/unist][ts-unist].

', + '

Test

', + '

some image

', '', ].join('\n'), );