ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: deleted obsolete overlay event names

Browse source
This commit is contained in:
Thijs Louisse 2019-12-11 15:51:37 +01:00
parent b2c5f92e08
commit 1290d9be95
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/dialog/src/LionDialog.js
View file

@ -2,11 +2,6 @@ import { withModalDialogConfig, OverlayMixin } from '@lion/overlays';
import { LitElement, html } from '@lion/core'; import { LitElement, html } from '@lion/core';
export class LionDialog extends OverlayMixin(LitElement) { export class LionDialog extends OverlayMixin(LitElement) {
constructor() {
super();
this.closeEventName = 'dialog-close';
}
// eslint-disable-next-line class-methods-use-this // eslint-disable-next-line class-methods-use-this
_defineOverlayConfig() { _defineOverlayConfig() {
return { return {
@ -15,6 +10,7 @@ export class LionDialog extends OverlayMixin(LitElement) {
} }
_setupOpenCloseListeners() { _setupOpenCloseListeners() {
super._setupOpenCloseListeners();
this.__toggle = () => { this.__toggle = () => {
this.opened = !this.opened; this.opened = !this.opened;
}; };
@ -25,6 +21,7 @@ export class LionDialog extends OverlayMixin(LitElement) {
} }
_teardownOpenCloseListeners() { _teardownOpenCloseListeners() {
super._teardownOpenCloseListeners();
if (this._overlayInvokerNode) { if (this._overlayInvokerNode) {
this._overlayInvokerNode.removeEventListener('click', this.__toggle); this._overlayInvokerNode.removeEventListener('click', this.__toggle);
} }

3
packages/tooltip/src/LionTooltip.js
View file

@ -4,7 +4,6 @@ import { LitElement, html } from '@lion/core';
export class LionTooltip extends OverlayMixin(LitElement) { export class LionTooltip extends OverlayMixin(LitElement) {
constructor() { constructor() {
super(); super();
this.closeEventName = 'tooltip-close';
this.mouseActive = false; this.mouseActive = false;
this.keyActive = false; this.keyActive = false;
} }
@ -19,6 +18,7 @@ export class LionTooltip extends OverlayMixin(LitElement) {
} }
_setupOpenCloseListeners() { _setupOpenCloseListeners() {
super._setupOpenCloseListeners();
this.__resetActive = () => { this.__resetActive = () => {
this.mouseActive = false; this.mouseActive = false;
this.keyActive = false; this.keyActive = false;
@ -58,6 +58,7 @@ export class LionTooltip extends OverlayMixin(LitElement) {
} }
_teardownOpenCloseListeners() { _teardownOpenCloseListeners() {
super._teardownOpenCloseListeners();
this._overlayCtrl.removeEventListener('hide', this.__resetActive); this._overlayCtrl.removeEventListener('hide', this.__resetActive);
this.removeEventListener('mouseenter', this.__showMouse); this.removeEventListener('mouseenter', this.__showMouse);
this.removeEventListener('mouseleave', this._hideMouse); this.removeEventListener('mouseleave', this._hideMouse);