From 1290d9be9556311dd91c539e57d1b0652e5a419c Mon Sep 17 00:00:00 2001 From: Thijs Louisse Date: Wed, 11 Dec 2019 15:51:37 +0100 Subject: [PATCH] fix: deleted obsolete overlay event names --- packages/dialog/src/LionDialog.js | 7 ++----- packages/tooltip/src/LionTooltip.js | 3 ++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/dialog/src/LionDialog.js b/packages/dialog/src/LionDialog.js index 68e1b0666..905576f01 100644 --- a/packages/dialog/src/LionDialog.js +++ b/packages/dialog/src/LionDialog.js @@ -2,11 +2,6 @@ import { withModalDialogConfig, OverlayMixin } from '@lion/overlays'; import { LitElement, html } from '@lion/core'; export class LionDialog extends OverlayMixin(LitElement) { - constructor() { - super(); - this.closeEventName = 'dialog-close'; - } - // eslint-disable-next-line class-methods-use-this _defineOverlayConfig() { return { @@ -15,6 +10,7 @@ export class LionDialog extends OverlayMixin(LitElement) { } _setupOpenCloseListeners() { + super._setupOpenCloseListeners(); this.__toggle = () => { this.opened = !this.opened; }; @@ -25,6 +21,7 @@ export class LionDialog extends OverlayMixin(LitElement) { } _teardownOpenCloseListeners() { + super._teardownOpenCloseListeners(); if (this._overlayInvokerNode) { this._overlayInvokerNode.removeEventListener('click', this.__toggle); } diff --git a/packages/tooltip/src/LionTooltip.js b/packages/tooltip/src/LionTooltip.js index ef1c09b5e..535bdbdff 100644 --- a/packages/tooltip/src/LionTooltip.js +++ b/packages/tooltip/src/LionTooltip.js @@ -4,7 +4,6 @@ import { LitElement, html } from '@lion/core'; export class LionTooltip extends OverlayMixin(LitElement) { constructor() { super(); - this.closeEventName = 'tooltip-close'; this.mouseActive = false; this.keyActive = false; } @@ -19,6 +18,7 @@ export class LionTooltip extends OverlayMixin(LitElement) { } _setupOpenCloseListeners() { + super._setupOpenCloseListeners(); this.__resetActive = () => { this.mouseActive = false; this.keyActive = false; @@ -58,6 +58,7 @@ export class LionTooltip extends OverlayMixin(LitElement) { } _teardownOpenCloseListeners() { + super._teardownOpenCloseListeners(); this._overlayCtrl.removeEventListener('hide', this.__resetActive); this.removeEventListener('mouseenter', this.__showMouse); this.removeEventListener('mouseleave', this._hideMouse);