From 2c285a60bb715437fcda014b19630958b84c5081 Mon Sep 17 00:00:00 2001
From: Ayo <ramon.aycojr@gmail.com>
Date: Sun, 19 Nov 2023 00:12:30 +0100
Subject: [PATCH] refactor: remove constructor; move initializeProps to
 connectedCallback

---
 sample.html         | 2 +-
 src/WebComponent.js | 8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/sample.html b/sample.html
index 64c6577..a521ae2 100644
--- a/sample.html
+++ b/sample.html
@@ -3,7 +3,7 @@
   <head>
     <title>WC Base Test</title>
     <script type="module">
-      import WebComponent from "https://unpkg.com/web-component-base/index.js";
+      import WebComponent from "./src/WebComponent.js";
 
       class HelloWorld extends WebComponent {
         static properties = ["my-name"];
diff --git a/src/WebComponent.js b/src/WebComponent.js
index 2a3f4b2..4071e78 100644
--- a/src/WebComponent.js
+++ b/src/WebComponent.js
@@ -65,11 +65,6 @@ export class WebComponent extends HTMLElement {
    */
   #props;
 
-  constructor() {
-    super();
-    this.#initializeProps();
-  }
-
   /**
    * Triggered after view is initialized. Best for querying DOM nodes that will only exist after render.
    * @returns {void}
@@ -111,6 +106,7 @@ export class WebComponent extends HTMLElement {
   }
 
   connectedCallback() {
+    this.#initializeProps();
     this.onInit();
     this.render();
     this.afterViewInit();
@@ -131,7 +127,6 @@ export class WebComponent extends HTMLElement {
     if (previousValue !== currentValue) {
       this[property] = currentValue === "" || currentValue;
       this[camelCaps] = this[property]; // remove on v2
-      this.#initializeProps();
       this.props[camelCaps] = this[property];
 
       this.render();
@@ -171,7 +166,6 @@ export class WebComponent extends HTMLElement {
         );
 
       if (oldValue != newValue) {
-        console.log("value changed", oldValue, newValue);
         const kebab = getKebab(prop);
         setter(kebab, newValue);
       }
