lion/packages/ui/components/overlays
Denilson Sá Maia ef7f16a51c fix(overlays): don't call _setupOverlayCtrl() in OverlayMixin if the component is not connected
In our application, there is a very complicated logic that creates a bunch of form fields based on some data. It's very complicated, we hate that logic; but it exists, it works, and it is being used in production.

Somewhere in that logic, under a very specific case, a datepicker form field is created, connected, and then immediately disconnected. Don't ask me why, I said it is complicated.

This commit fixes a bug in OverlayMixin. The `connectedCallback` calls `_setupOverlayCtrl()` asynchronously, after a `Promise.then()`. Thus, by the time this setup function is called, the component has already been disconnected (and `disconnectedCallback()` has already been called).

The fix is simple: don't try to setup the overlay if the component is no longer connected.
2025-07-26 15:05:49 +02:00
..
src fix(overlays): don't call _setupOverlayCtrl() in OverlayMixin if the component is not connected 2025-07-26 15:05:49 +02:00
test fix(overlays): add tabindex="-1" to prevent tooltips get focus in Safari and Firefox 2025-01-21 10:40:40 +01:00
test-helpers fix(overlays): no hiding of nested overlays having hideOnEsc configured 2024-11-05 17:02:03 +01:00
test-suites fix(overlays): rework setup and teardown logic of OverlayMixin 2025-01-13 15:33:28 +01:00
translations feat: add Turkish (tr) translations to form-core, input-datepicker & pagination (#2516) 2025-05-15 16:56:48 +02:00
types feat(dialog): add is-alert-dialog option (#2445) 2025-01-21 09:21:34 +01:00