Commit graph

2636 commits

Author SHA1 Message Date
Danny Moerkerke
8b9c8050e5
Fix/upload response (#2000)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

* chore: corrected property names in demo and removed demo of prefilled state

* chore: renamed `_fileSelectResponse` back to `uploadResponse` and restored demo of prefilled state

---------

Co-authored-by: gvangeest <gerjan.van.geest@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-07 12:57:34 +02:00
Thijs Louisse
6893421779
chore: SlotRerenderObject aligned with reactive cycle (docs + changelog) (#1999) 2023-06-07 09:16:28 +02:00
gerjanvangeest
d2de984f0b
Feat/input file (#1881)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

---------

Co-authored-by: Danny Moerkerke <danny.moerkerke@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-06 11:30:43 +02:00
SynnefonK
649bcc6320
Update verify.yml (#1996) 2023-06-06 10:47:17 +02:00
Farzan Najipour
c8052af068
chore: workflow improvement (#1989)
* Update verify.yml with setup-common-steps

This commit updates the verify.yml file to include the setup-common-steps job. The setup-common-steps job is responsible for setting up the common steps required for the verify workflow. By adding this job, we ensure that the necessary setup is performed before running the verify job.

The update includes the following changes:

- Added the setup-common-steps job to the jobs section.
- Added the needs keyword to the verify, browser-tests, node-tests, and node-tests-windows jobs, specifying that they depend on the setup-common-steps job.

* Update actions/setup-node and actions/checkout versions

This commit updates the versions of actions/setup-node and actions/checkout in the release.yml file.

* Rename 'setup-common-steps' to 'init' in verify.yml

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* Update setup-node and action/checkout to v3

* Update setup-node and action/checkout to v3 and rename setup-common-steps to init

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2023-06-05 09:17:16 +02:00
Gyulai Levente
bdc7455610
feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount (#1988)
* feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount

* Remove test for feature what is not supported anymore
* Add documentation
* Add test for customizable currency slot
2023-06-01 08:55:42 +02:00
SynnefonK
ac2f2155f2
Merge pull request #1990 from ing-bank/subclasser-example/button
Subclasser example/button
2023-05-31 12:16:18 +02:00
Thijs Louisse
8293059fea chore: fix combobox extension demos 2023-05-30 19:13:30 +02:00
Thijs Louisse
b66662931f chore: extension example for bootstrap buttons 2023-05-30 18:45:51 +02:00
Thijs Louisse
32ab5bfd41 fix(button): only pre-style non-shorthands for easier extension 2023-05-30 18:44:41 +02:00
Thijs Louisse
3257060c39 chore: rename "Examples" to "Extensions" for clarity 2023-05-30 18:42:57 +02:00
SynnefonK
7089ea54e3
Merge pull request #1963 from Sciurus7/autofocus-ui
fix(form-core) sync autofocus to focusable node (fixes #1775)
2023-05-25 10:34:39 +02:00
Monika Nawój
e310c08af1
fix(LionInputDatePicker): remove endless loop on InvalidDate modelValue (#1984)
* refactor: used IsDate validator instead of custom isValidDate function

* fix: used IsDate validator to validate modelValue before it's passed to lion-calendar's selctedDate

* test: Updated lion-input-datepicker tests to include example of handling invalid modelValue

* docs: Updated docs to include example with invalid modelValue

* refactor: updated returned type of __getSyncDownValue method

* changset: updated changeset for @lion/ui

* refactor: linting fix

* refactor:  import path updated

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* refactor: label added to Faulty prefilled datepicker input

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* test: updated test to include more obvious invalid date value

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2023-05-24 11:51:26 +02:00
SynnefonK
d4085cc8c0
Merge pull request #1980 from ing-bank/chore/readme-update
chore: readme update
2023-05-24 09:33:20 +02:00
gerjanvangeest
73730dd566 chore: readme update 2023-05-22 14:19:11 +02:00
Thijs Louisse
ede8412cbc
Merge pull request #1981 from ing-bank/changeset-release/master
Version Packages
2023-05-17 15:08:58 +02:00
github-actions[bot]
0d7d170709 Version Packages 2023-05-17 10:08:17 +00:00
gerjanvangeest
88e6ca03ca
fix(localize): parseNumbers as heuristic if there is only 1 separator and 2 or less decimals e.g. 12.34 (#1976) 2023-05-17 12:07:00 +02:00
gerjanvangeest
56b3d334f6 chore(dialog): add focus tests 2023-05-16 12:01:18 +02:00
SynnefonK
9a845344fb
Merge pull request #1952 from ing-bank/chore/explicit-npm-registry
chore: make default public npm registry explicit
2023-05-09 18:42:43 +02:00
Konstantinos Norgias
232579897c chore: make default public npm registry explicit 2023-05-09 18:32:42 +02:00
Thijs Louisse
9f0b358b18
Merge pull request #1975 from ing-bank/dependabot/npm_and_yarn/engine.io-and-socket.io-6.4.2
chore(deps): bump engine.io and socket.io
2023-05-09 16:20:42 +02:00
dependabot[bot]
3eca6daa46
chore(deps): bump engine.io and socket.io
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together.

Updates `engine.io` from 6.2.1 to 6.4.2
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/engine.io/compare/6.2.1...6.4.2)

Updates `socket.io` from 4.5.4 to 4.6.1
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io/compare/4.5.4...4.6.1)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-05-04 00:57:12 +00:00
Thijs Louisse
7b2a234c6c
Merge pull request #1949 from ing-bank/changeset-release/master
Version Packages
2023-05-02 10:03:09 +02:00
github-actions[bot]
703fb72034 Version Packages 2023-05-01 15:28:23 +00:00
Gerjan van Geest
4bf1633d0b chore(select-rich): update docs 2023-05-01 17:27:06 +02:00
dependabot[bot]
7707fda9b6 chore(deps): bump nunjucks from 3.2.3 to 3.2.4
Bumps [nunjucks](https://github.com/mozilla/nunjucks) from 3.2.3 to 3.2.4.
- [Release notes](https://github.com/mozilla/nunjucks/releases)
- [Changelog](https://github.com/mozilla/nunjucks/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mozilla/nunjucks/compare/v3.2.3...v3.2.4)

---
updated-dependencies:
- dependency-name: nunjucks
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-21 00:07:41 +02:00
gvangeest
eab0dcca78 chore: add missing import of lion-checkbox-indeterminate 2023-04-20 14:51:35 +02:00
Danny Moerkerke
12f1800806 fix: lion-calendar: when determining if user interacted with a day button we no longer examine event.target but event.composedPath()[0] since it otherwise fails in Firefox 111+ 2023-04-19 15:34:03 +02:00
Sciurus7
251de2c84e fix(form-core) use updated over attributeChangedCallback 2023-04-17 16:42:48 +02:00
Sciurus7
2683a73080 fix(form-core) sync autofocus to focusable node 2023-04-14 13:39:05 +02:00
Danny Moerkerke
5b8d655f10
Fix/dialog scroll to top ios (#1957)
* fix: possible fix for iOS focus issue WIP

* chore: added test for elementToFocusAfterHide WIP

* chore: dialog tests for elementToFocusAFterHide

* chore: added test to assert element specified in `elementToFocusAfterHide` config key of lion-dialog is scrolled into the viewport

* chore: - added test to assert that element specified in dialog config key `elementToFocusAfterHide` is not focused when the dialog is closed if the user deliberately moved focus to another element while the dialog was open
       - added changeset

* chore: - removed unneeded button
       - renamed this.__activeElement to this.__activeElementRightBeforeHide in OverlayController.js
       - set this.__activeElementRightBeforeHide to this.contentNode.getRootNode().activeElement instead of document.activeElement

* chore: moved test to assert if element specified in dialog config key elementToFocusAfterHide is in viewport when dialog is closed to OverlayController.test.js

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-04-13 15:04:23 +02:00
Ioannis
19b17a99a3
chore: added missing word "Systems" (#1955) 2023-04-13 10:50:31 +02:00
Danny Moerkerke
593d330158
chore: wrote a blogpost on @lion/ui (#1946)
* chore: wrote a blogpost on @lion/ui

* Update docs/blog/introducing-lion-ui.md

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* Update docs/blog/introducing-lion-ui.md

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* Update introducing-lion-ui.md

Removed placeholder cover image

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2023-04-05 09:39:46 +02:00
Barni
a5f35158c0
feat(@lion/ui): add _previousIconTemplate and _nextIconTemplate to LionCalendar (#1954) 2023-04-03 17:00:30 +02:00
Tobias Kuppens Groot
b88af36eec chore: update codeowners
Signed-off-by: Tobias Kuppens Groot <tkuppensgroo@uos.de>
2023-03-29 10:12:34 +02:00
gvangeest
ddea63b381 fix(combobox): update option list after clear 2023-03-22 13:07:34 +01:00
gvangeest
5516bec4ba chore(overlays): add documentation about role=none is used 2023-03-20 14:18:53 +01:00
github-actions[bot]
0ec0d6dc9f Version Packages 2023-03-20 09:30:27 +01:00
gerjanvangeest
a2b81b2693
feat(combobox): add requireOptionMatch flag and MatchesOption validator
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2023-03-16 18:18:40 +01:00
barni52
1f018bafdf feat(@lion/ui): add _invokerIconTemplate to LionInputDatepicker 2023-03-16 15:30:02 +01:00
Thijs Louisse
adfa29a049 fix(switch): remove one of the two nested role="switch" 2023-03-15 11:31:43 +01:00
gvangeest
0d4c42ab64 fix(listbox): allow use of arrow keys when focus is not on listbox 2023-03-15 11:10:48 +01:00
Danny Moerkerke
3256892ce9
fix: checked-changed event is no longer fired on element initialization when checked is set through attribute 2023-03-15 10:59:04 +01:00
Pascal Schneider
183c86af26
fix: more sensible default for German iban validator translation 2023-03-15 09:42:48 +01:00
Danny Moerkerke
075d5077bd
Merge pull request #1934 from ing-bank/fix/accordion-selector-fix
fix: changed selectors for invokers and content to only select slotte…
2023-03-15 09:35:53 +01:00
Danny Moerkerke
7cba2ef859 chore: added test 2023-03-14 13:40:40 +01:00
Konstantinos Norgias
0e760f71db chore: a higher sharp version that can be built on Mac 2023-03-11 00:05:44 +01:00
jorenbroekema
42a463eee1 fix(ui/overlays): set <dialog> wrapping el padding to 0 2023-03-11 00:05:23 +01:00
Danny Moerkerke
3f1c83a180 fix: changed selectors for invokers and content to only select slotted elements that are direct descendants. This is to prevent that slotted elements in accordion content and invokers are also selected and the amount of invokers and content is incorrect 2023-03-09 15:33:24 +01:00