Commit graph

115 commits

Author SHA1 Message Date
Guilherme Amorim
e923ba40a3
Fix(lion-radio-group): Resetting a group containing options with formatters (#2101)
* fix(lion-radio-group): Resetting a group containing options with formatters doesn't check the default value

* refactor: update test name
2023-10-18 17:10:26 +02:00
Guilherme Amorim
7235a4f703
fix(lion-combobox): The event emitted during clear has stale value (#2104) 2023-10-18 17:00:30 +02:00
Gyulai Levente
be36bf3b1b
fix(input-amount): Link currency to label after setting currency from… (#2091) 2023-10-17 14:55:13 +02:00
barna
63a8e725db
fix(lion-calendar): Make calendar buttons selectable on firefox through datepicker (#2080) 2023-10-17 14:52:53 +02:00
alejandrofernandezcanton
b1320a9a9c
fix(overlay): avoid calling push in iterable object to avoid error loading overlays (#2088) 2023-10-17 14:44:51 +02:00
Gyulai Levente
dcf3a4b0bd
fix(combobox): Fix search issues when modifying the middle of the input word (#2085) 2023-10-17 13:52:10 +02:00
gerjanvangeest
6ccfb27868
fix(input-datepicker): only disable dates if validator is of type error (#2076) 2023-09-12 15:10:43 +02:00
Gyulai Levente
d1f92a3ad7
fix(lion-calendar): Make disabled dates not selectable via keyboard navigation (#2058)
* fix(calendar): Make disabled dates not selectable

* Add changeset

* chore(calendar): add skipped test for select date on [Enter]

---------

Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2023-09-12 15:10:23 +02:00
gerjanvangeest
d597c077b4
fix(localize): fix type of localizeNameSpaces (#2073) 2023-09-11 16:45:16 +02:00
Sciurus7
cecf5ed573
fix(lion-accordion): make a copy when changing expanded (#2047) 2023-09-11 14:55:30 +02:00
Gyulai Levente
857d47a933
fix(accordion): navigating with tab confuses the arrow key navigation (#2056)
* fix(accordion): Handle focusin event, when tabbing to an invoker

* fix(accordion): Add changeset

* fix(accordion): Test if the index equals to the focusedIndex
2023-09-11 14:43:52 +02:00
gerjanvangeest
9b9485dbaa
fix(calendar): focusCentralDate function should only use buttons inside the dates table (#2072) 2023-09-11 14:24:39 +02:00
Gyulai Levente
b89d889fd5
fix(calendar): render exactly 6 weeks in every months (#2037) 2023-09-07 15:01:09 +02:00
Fábio Santos
ebe13e14b0
fix(overlays): undefined document.body (#2070)
* Fix undefined `document.body`

* Add changeset
2023-09-06 13:34:04 +02:00
Gio Adrian Fortuno
b0a74f2831
fix(progress-indicator): accept 0 as a valid value (#2068)
* fix(progress-indicator): accept 0 as a valid value

* chore: added changeset
2023-09-04 13:02:34 +02:00
Thijs Louisse
e16de38cd6 chore: enhance execution on empty api 2023-08-30 13:46:40 +02:00
Thijs Louisse
4cc72b1251 feat: allow Required validator on Fieldset and Form; "static executesOnEmpty" flag on Validators 2023-08-30 13:46:40 +02:00
Víctor Lara
5eafa1ffc1
fix(overlays): add aria-hidden to arrow (#2030) 2023-07-10 08:18:08 +02:00
gerjanvangeest
b44bfc5d1f
feat: enable navigation to, selecting & give accessible message for calendar disabled dates (#1978)
Co-authored-by: Konstantinos Norgias <Konstantinos.Norgias@ing.com>
2023-07-04 10:36:18 +02:00
Danny Moerkerke
137a1b6cf5
Feat/is dragging prop (#2025)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* feat: added isDragging property
2023-06-27 09:18:41 +02:00
Danny Moerkerke
0745ce8526
Fix/input file types (#2021)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* chore: exported correct types for lion-input-file

* fix: fixed type errors
2023-06-22 10:48:49 +02:00
Danny Moerkerke
259e0dd468
Fix/remove file (#2018)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: removed composed: true and bubbles: true and set eventlistener directly on lion-selected-file-list

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* fix: fixed test

* Update packages/ui/components/input-file/test/lion-input-file.test.js

* chore: format

* fix

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2023-06-20 17:32:05 +02:00
gerjanvangeest
7ec90dcb06
chore: add checkboxIndeterminate test suite (#2013) 2023-06-14 16:24:34 +02:00
gerjanvangeest
02e61285dd
Revert "fix: create exports for test-suites and test-helpers (#2010)" (#2012)
This reverts commit 3cfc9f9744.
2023-06-13 15:14:47 +02:00
gerjanvangeest
1ea5730aa5
fix(localize): align currency symbol usage for all browsers (#2011) 2023-06-13 14:57:26 +02:00
gerjanvangeest
3cfc9f9744
fix: create exports for test-suites and test-helpers (#2010) 2023-06-13 08:47:56 +02:00
gerjanvangeest
dbc3fc2db6
fix(combobox): submit form on [Enter] (#2005)
fix(combobox): submit form on [Enter]
2023-06-08 18:14:14 +02:00
Danny Moerkerke
8b9c8050e5
Fix/upload response (#2000)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

* chore: corrected property names in demo and removed demo of prefilled state

* chore: renamed `_fileSelectResponse` back to `uploadResponse` and restored demo of prefilled state

---------

Co-authored-by: gvangeest <gerjan.van.geest@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-07 12:57:34 +02:00
Thijs Louisse
6893421779
chore: SlotRerenderObject aligned with reactive cycle (docs + changelog) (#1999) 2023-06-07 09:16:28 +02:00
gerjanvangeest
d2de984f0b
Feat/input file (#1881)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

---------

Co-authored-by: Danny Moerkerke <danny.moerkerke@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-06 11:30:43 +02:00
Gyulai Levente
bdc7455610
feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount (#1988)
* feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount

* Remove test for feature what is not supported anymore
* Add documentation
* Add test for customizable currency slot
2023-06-01 08:55:42 +02:00
SynnefonK
ac2f2155f2
Merge pull request #1990 from ing-bank/subclasser-example/button
Subclasser example/button
2023-05-31 12:16:18 +02:00
Thijs Louisse
32ab5bfd41 fix(button): only pre-style non-shorthands for easier extension 2023-05-30 18:44:41 +02:00
SynnefonK
7089ea54e3
Merge pull request #1963 from Sciurus7/autofocus-ui
fix(form-core) sync autofocus to focusable node (fixes #1775)
2023-05-25 10:34:39 +02:00
Monika Nawój
e310c08af1
fix(LionInputDatePicker): remove endless loop on InvalidDate modelValue (#1984)
* refactor: used IsDate validator instead of custom isValidDate function

* fix: used IsDate validator to validate modelValue before it's passed to lion-calendar's selctedDate

* test: Updated lion-input-datepicker tests to include example of handling invalid modelValue

* docs: Updated docs to include example with invalid modelValue

* refactor: updated returned type of __getSyncDownValue method

* changset: updated changeset for @lion/ui

* refactor: linting fix

* refactor:  import path updated

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* refactor: label added to Faulty prefilled datepicker input

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>

* test: updated test to include more obvious invalid date value

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2023-05-24 11:51:26 +02:00
gerjanvangeest
88e6ca03ca
fix(localize): parseNumbers as heuristic if there is only 1 separator and 2 or less decimals e.g. 12.34 (#1976) 2023-05-17 12:07:00 +02:00
gerjanvangeest
56b3d334f6 chore(dialog): add focus tests 2023-05-16 12:01:18 +02:00
Danny Moerkerke
12f1800806 fix: lion-calendar: when determining if user interacted with a day button we no longer examine event.target but event.composedPath()[0] since it otherwise fails in Firefox 111+ 2023-04-19 15:34:03 +02:00
Sciurus7
251de2c84e fix(form-core) use updated over attributeChangedCallback 2023-04-17 16:42:48 +02:00
Sciurus7
2683a73080 fix(form-core) sync autofocus to focusable node 2023-04-14 13:39:05 +02:00
Danny Moerkerke
5b8d655f10
Fix/dialog scroll to top ios (#1957)
* fix: possible fix for iOS focus issue WIP

* chore: added test for elementToFocusAfterHide WIP

* chore: dialog tests for elementToFocusAFterHide

* chore: added test to assert element specified in `elementToFocusAfterHide` config key of lion-dialog is scrolled into the viewport

* chore: - added test to assert that element specified in dialog config key `elementToFocusAfterHide` is not focused when the dialog is closed if the user deliberately moved focus to another element while the dialog was open
       - added changeset

* chore: - removed unneeded button
       - renamed this.__activeElement to this.__activeElementRightBeforeHide in OverlayController.js
       - set this.__activeElementRightBeforeHide to this.contentNode.getRootNode().activeElement instead of document.activeElement

* chore: moved test to assert if element specified in dialog config key elementToFocusAfterHide is in viewport when dialog is closed to OverlayController.test.js

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-04-13 15:04:23 +02:00
Barni
a5f35158c0
feat(@lion/ui): add _previousIconTemplate and _nextIconTemplate to LionCalendar (#1954) 2023-04-03 17:00:30 +02:00
gvangeest
ddea63b381 fix(combobox): update option list after clear 2023-03-22 13:07:34 +01:00
gvangeest
5516bec4ba chore(overlays): add documentation about role=none is used 2023-03-20 14:18:53 +01:00
gerjanvangeest
a2b81b2693
feat(combobox): add requireOptionMatch flag and MatchesOption validator
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2023-03-16 18:18:40 +01:00
barni52
1f018bafdf feat(@lion/ui): add _invokerIconTemplate to LionInputDatepicker 2023-03-16 15:30:02 +01:00
Thijs Louisse
adfa29a049 fix(switch): remove one of the two nested role="switch" 2023-03-15 11:31:43 +01:00
gvangeest
0d4c42ab64 fix(listbox): allow use of arrow keys when focus is not on listbox 2023-03-15 11:10:48 +01:00
Danny Moerkerke
3256892ce9
fix: checked-changed event is no longer fired on element initialization when checked is set through attribute 2023-03-15 10:59:04 +01:00
Pascal Schneider
183c86af26
fix: more sensible default for German iban validator translation 2023-03-15 09:42:48 +01:00