Commit graph

55 commits

Author SHA1 Message Date
Robin Van Roy
713429ac80
feat: adds display options configurability to the success validation 2025-08-07 17:20:34 +02:00
Thijs Louisse
76946d22b4 fix: add @slot and @customElement for better ce-manifest output 2025-07-31 21:57:46 +02:00
Thijs Louisse
64b72a049e fix(form-core): make sure renamed Required validator are identified as such, while remaining compatible with multiple versions 2025-07-29 18:46:46 +02:00
Thijs Louisse
57eec5b599 fix: make sure helpText and label respond to empty strings 2025-07-29 18:46:46 +02:00
Denilson Sá Maia
1d3a00c022 fix(form-core): don't remove event listeners if _focusableNode was not set
This fix is similar to the previous commit.

Under very specific circumstances on a very complicated application logic, a file input field (that
extends from FocusMixin) gets created and immediately destroyed. This unfortunately causes an
error, because the `disconnectedCallback()` gets called to remove the event listeners for a
component that hasn't been fully set up.

> Uncaught TypeError: this._focusableNode is null
2025-07-26 15:05:49 +02:00
selcen.sonmez
a0d334dc54
feat: add Turkish (tr) translations to form-core, input-datepicker & pagination (#2516)
* feat(input-datepicker): add Turkish translations

* chore: add changeset for Turkish translation

* feat(input-datepicker): add Turkish translations

* chore: consolidate all Turkish translations into a single changeset
2025-05-15 16:56:48 +02:00
Mete Abduraman
07b089e80f
fix(validate-mixin): determine required or result validators based on characteristics (#2498)
* fix(validate-mixin): determine if a required validator or result validator has been registered based on characteristics

* chore(validate-mixin): create changeset
2025-05-08 08:42:12 +02:00
Thijs Louisse
c3021f8e7f fix(form-core): make sure that slots with property fallbacks ignore initialization updates (undefined on firstUpdated) 2025-04-30 08:33:31 +02:00
ByoungYong Kim
22b8f24804
Fix indeterminate checkbox edge cases (#2458)
* Add failing tests

* Fix the issues with indeterminate checkbox

* Update the fix

* Clean up the code

* Add changeset

* Fix a type issue

* Refactor the code

* Fix a bug regarding disabled checked sub checkbox

* Add test case where subCheckboxes are added and removed dynamically

* Make a few node reference optional as it spits undefined error when the element is removed
2025-02-04 11:08:57 +01:00
gerjanvangeest
795237d19e
fix(form-core): add aria-hidden=true to the graphic element of the choiceInput (#2447) 2025-01-20 09:46:10 +01:00
Thijs Louisse
d5258d56fd
fix(ui): [form-core] enhance formatter and parser meta; reset _isPasting on task instead of microtask
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2025-01-15 16:33:02 +01:00
gerjanvangeest
35e66052b6
fix(input-amount): parse amount always on locale once the amount is formatted (#2439)
* fix(input-amount): parse amount always  on locale once the amount is formatted

* chore: add unit test

* chore: add some description

* chore: update playwright script to install dependencies

* Update .github/workflows/verify-pr.yml

* chore: set formatOptions temp and cleanup for programmatic api

* feat(form-core): add "user-edit" mode to formatOptions while editing existing value of a form control

* chore: enhance code readability and robustness

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-15 09:59:02 +01:00
Thijs Louisse
9dcb361dfb chore: add remaining internal usages of isActiveElement in tests 2024-11-28 17:19:16 +01:00
Thijs Louisse
3e13adedc2
fix: make web-test-runner using documentOrShadowRoot.activeElement debuggable 2024-11-21 09:01:13 +01:00
Thijs Louisse
6da73f7a36 chore: allow tests to run w/o polyfill
Co-authored-by: aghArdeshir <ardeshirizadinl@gmail.com>
2024-11-12 16:21:36 +01:00
Hardik Pithva
9b92fa216e
fix(form-core): allow to use '_$isValidator$' instead of instanceof check (supporting multiple versions of Validator)
* fix(form-core): make use of `validatorName` and `type` to check validator instance

* fix(form-core): check for nullability for disabled prop

* fix: add `_$isValidator$` property to improve the check

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* test: add check for _$isValidator$

* chore: catch edge cases in cem script

* chore: cleanup, docs, and add prop on ctor to be more unobtrusive

* chore: changeset

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-11-12 13:28:08 +01:00
Thijs Louisse
1626dbd460 fix(ui): improve test experience in dev-mode 2024-10-30 15:51:55 +01:00
gerjanvangeest
7c2b4692d3
fix(validation-feedback): do not display type of the validation feedback message, if there is no message 2024-10-29 17:53:54 +01:00
gerjanvangeest
bc175b5609 chore: update portal url 2024-10-29 12:15:39 +01:00
Thijs Louisse
dbb964077f chore: update/clean devDependencies for better security and perf 2024-10-16 14:14:26 +02:00
gerjanvangeest
3dbee0c9b0
fix: add translations to the type of validation message (#2226) 2024-06-17 09:28:51 +02:00
Dan Carlo Canlas
57597bb9ba
fix(form-core): Implement conversion of name attribute value to string type 2024-05-22 23:11:01 +02:00
Kristján Oddsson
c7c83d1d8b
update prettier
* update prettier to v3.x
* update prettify in @lion/nodejs-helpers to match updated prettier
* remove redundant await for promise
* remove `@types/prettier` as it's now included in `prettier`
* format lit template snippets with `jsx`
2024-05-17 21:43:23 +02:00
Thijs Louisse
aea90ae036 chore(root): cleanup and update dependencies 2024-05-14 13:47:11 +02:00
gerjanvangeest
4c69c7e34f
chore: update eslint-plugin-lit-a11y version (#2259) 2024-04-16 15:16:40 +02:00
Max Larionov
37deecd2a3 feat: support cross-root registration with form-element-register event 2024-04-02 15:33:45 +02:00
Oleksii Kadurin
00a7e39aae feat(ui): adopt @open-wc/scoped-elements mixin v3
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-03-27 18:02:15 +01:00
gerjanvangeest
e72fd6d6ea feat(form-core): add select and upload specific required messages 2024-03-06 15:52:36 +01:00
Thijs Louisse
eb46728826 fix: migrate deprecated performUpdate api to scheduleUpdate 2024-02-21 23:36:53 +01:00
gerjanvangeest
92a5cd1e3d fix(form-core): remove fieldset label from input-field aria-labelledby, add opt-in via data-label 2024-02-19 17:39:22 +01:00
gerjanvangeest
19256d31bf fix(form-core): set aria-disabled next to the disabled attribute for NVDA screen reader 2024-02-19 16:00:19 +01:00
gerjanvangeest
659cbff18c fix(form-core): order aria-labelledby and aria-describedby based on slot order instead of dom order 2024-02-19 15:59:32 +01:00
Thijs Louisse
bdb038e197 chore: test/lint/swc fixes + changeset providence 2023-11-09 11:38:39 +01:00
Thijs Louisse
45fe0b4bb3 chore(ui): lint and types fixes 2023-11-08 19:08:54 +01:00
Thijs Louisse
60032a2df0 fix(ui): make compatible with latest playwright browsers 2023-11-08 19:01:21 +01:00
Thijs Louisse
c6663068a7 fix(ui): cleanup IE edge case in getAriaElementsInRightDomOrder 2023-11-08 19:01:21 +01:00
Guilherme Amorim
be4e25a108
feat: support (multiselect) choice-groups with allow-custom-choice 2023-11-08 15:05:09 +01:00
Oleksii Kadurin
f421bd7326
fix: update documentation and unit tests for validation 2023-11-07 11:21:41 +01:00
Thijs Louisse
e16de38cd6 chore: enhance execution on empty api 2023-08-30 13:46:40 +02:00
Thijs Louisse
4cc72b1251 feat: allow Required validator on Fieldset and Form; "static executesOnEmpty" flag on Validators 2023-08-30 13:46:40 +02:00
gerjanvangeest
02e61285dd
Revert "fix: create exports for test-suites and test-helpers (#2010)" (#2012)
This reverts commit 3cfc9f9744.
2023-06-13 15:14:47 +02:00
gerjanvangeest
3cfc9f9744
fix: create exports for test-suites and test-helpers (#2010) 2023-06-13 08:47:56 +02:00
gerjanvangeest
d2de984f0b
Feat/input file (#1881)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

---------

Co-authored-by: Danny Moerkerke <danny.moerkerke@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-06 11:30:43 +02:00
Sciurus7
251de2c84e fix(form-core) use updated over attributeChangedCallback 2023-04-17 16:42:48 +02:00
Sciurus7
2683a73080 fix(form-core) sync autofocus to focusable node 2023-04-14 13:39:05 +02:00
gerjanvangeest
a2b81b2693
feat(combobox): add requireOptionMatch flag and MatchesOption validator
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2023-03-16 18:18:40 +01:00
Thijs Louisse
cee40e5588 chore(@lion/ui): all tests side effect free wrt localize 2023-02-01 16:06:30 +01:00
Thijs Louisse
467ba6bf0b feat(@lion/ui): localize side effect free internally 2023-02-01 16:06:30 +01:00
Thomas Allmer
11f6f19a09 fix(ui): use scoped-elements version that exposes types 2022-11-28 13:28:39 +01:00
Thijs Louisse
2572012d8e chore: enhance SlotMixin docs 2022-11-23 16:19:09 +01:00