Commit graph

55 commits

Author SHA1 Message Date
gerjanvangeest
dd598125ef
feat(dialog): add is-alert-dialog option (#2445)
* feat(dialog): add is-alert-dialog option

* chore: make alert-dialog example simpler
2025-01-21 09:21:34 +01:00
Thijs Louisse
8377e8d17d fix(overlays): rework setup and teardown logic of OverlayMixin
Add a failing test

chore: broken test fix

chore: harden overlay teardown tests and cleanup select-rich
2025-01-13 15:33:28 +01:00
Thijs Louisse
e5ff2b01d2 fix(overlays): overlayController teardown cleanup 2025-01-07 09:39:29 +01:00
Thijs Louisse
382a9aab64 fix: make sure that voiceover + safari modals are accessible 2024-11-28 17:19:16 +01:00
Thijs Louisse
3e13adedc2
fix: make web-test-runner using documentOrShadowRoot.activeElement debuggable 2024-11-21 09:01:13 +01:00
Krisztian Horvath
86ca2e072e
fix(overlays): fix memory leaks of adopt-styles and OverlayMixin
* fix(overlays): fix memory leaks of adopt-styles and OverlayMixin

* fix(overlays): support reconnecting the OverlayController to the OverlayManager

* chore: move unregister logic to OverlayController

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-11-12 17:25:37 +01:00
Gyulai Levente
2a989f47cf
fix(overlays): clicking outside iframe not closing the overlay 2024-11-12 17:24:21 +01:00
Thijs Louisse
360641c487 fix(overlays): no hiding of nested overlays having hideOnEsc configured 2024-11-05 17:02:03 +01:00
Thijs Louisse
1626dbd460 fix(ui): improve test experience in dev-mode 2024-10-30 15:51:55 +01:00
gerjanvangeest
bc175b5609 chore: update portal url 2024-10-29 12:15:39 +01:00
ka9de
bca25bc41e
fix(ui/overlays): overlay growing margin (#2331) 2024-08-28 13:59:48 +02:00
okadurin
89360b56db fix: clean code for overlay isModal 2024-08-28 13:31:28 +02:00
Oleksii Kadurin
e0f0ea4937
Update packages/ui/components/overlays/test/OverlayController.test.js
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2024-08-28 11:29:32 +02:00
okadurin
1d128d4973 fix dialog aria-expand attribute 2024-08-28 10:13:29 +02:00
okadurin
54219c52ea fix dialog aria-expand attribute 2024-08-28 09:26:41 +02:00
okadurin
719991fdd3 fix dialog aria-expand attribute 2024-08-27 16:55:45 +02:00
okadurin
5f92a722e6 Revert "fix: add aria-expanded attribute only for the non-modal dialogs"
This reverts commit fa832d900b.
2024-08-27 16:48:27 +02:00
okadurin
fa832d900b fix: add aria-expanded attribute only for the non-modal dialogs 2024-08-27 16:46:29 +02:00
Rajkeshwar Prasad
e0ef676a36
opened-changed event detail exposes opened state (#2334)
* opened-changed event detail exposes opened state

* Fixed lint issue

* Generated changeset

---------

Co-authored-by: Rajkeshwar Prasad <rajkeshwarp@azuga.com>
Co-authored-by: Rajkeshwar Prasad <--global>
2024-08-22 13:12:50 +02:00
Oleksii Kadurin
58796deb0e
fix: add slot support to deepContains function 2024-08-01 18:55:36 +02:00
gerjanvangeest
f9ba215675 fix(overlays): prevent closing of a modal dialog on pressing Esc and hidesOnEsc is set to false 2024-07-03 16:19:00 +02:00
gerjanvangeest
e4efb6dc03
chore: add description for opened to the jsdoc (#2305) 2024-06-24 11:39:52 +02:00
gerjanvangeest
4c69c7e34f
chore: update eslint-plugin-lit-a11y version (#2259) 2024-04-16 15:16:40 +02:00
gerjanvangeest
61db0eda9f fix(overlays): skip local-positioning tests for firefox, added a todo to fix later
* fix(overlays): skip local-positioning tests for Firefox, and added a todo to fix later

* Update packages/ui/components/overlays/test/local-positioning.test.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* feat(core): add Firefox to browserDetection

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-03-27 18:02:16 +01:00
Oleksii Kadurin
00a7e39aae feat(ui): adopt @open-wc/scoped-elements mixin v3
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-03-27 18:02:15 +01:00
Thijs Louisse
91fad70130 fix(ui): only use elementToFocusAfterHide when provided as HTMLElement 2024-03-08 13:43:01 +01:00
Alberto López-Barranco
c80bca7c83
fix(overlay-controller): do not scroll to invoker if it is visible (#2155)
* fix(overlay-controller): do not scroll to invoker if it is visible on screen

When closing an overlay, srollIntoView forced the invoker element to be placed in the middle of the screen. This fix prevents the scroll if the invoker is already visible, but still scrolls it into view if needed.

* chore: changeset
2023-12-11 12:44:01 +01:00
gerjanvangeest
d997e5233e
fix(tooltip): hide tooltip if the invoker gets disabled (#2154) 2023-12-06 13:37:23 +01:00
Iván Gómez Alonso
322b06521c
fix(ui): use traditional style on ios for adopt-styles 2023-11-24 12:02:06 +01:00
alejandrofernandezcanton
b1320a9a9c
fix(overlay): avoid calling push in iterable object to avoid error loading overlays (#2088) 2023-10-17 14:44:51 +02:00
Fábio Santos
ebe13e14b0
fix(overlays): undefined document.body (#2070)
* Fix undefined `document.body`

* Add changeset
2023-09-06 13:34:04 +02:00
Víctor Lara
5eafa1ffc1
fix(overlays): add aria-hidden to arrow (#2030) 2023-07-10 08:18:08 +02:00
gerjanvangeest
02e61285dd
Revert "fix: create exports for test-suites and test-helpers (#2010)" (#2012)
This reverts commit 3cfc9f9744.
2023-06-13 15:14:47 +02:00
gerjanvangeest
3cfc9f9744
fix: create exports for test-suites and test-helpers (#2010) 2023-06-13 08:47:56 +02:00
Danny Moerkerke
5b8d655f10
Fix/dialog scroll to top ios (#1957)
* fix: possible fix for iOS focus issue WIP

* chore: added test for elementToFocusAfterHide WIP

* chore: dialog tests for elementToFocusAFterHide

* chore: added test to assert element specified in `elementToFocusAfterHide` config key of lion-dialog is scrolled into the viewport

* chore: - added test to assert that element specified in dialog config key `elementToFocusAfterHide` is not focused when the dialog is closed if the user deliberately moved focus to another element while the dialog was open
       - added changeset

* chore: - removed unneeded button
       - renamed this.__activeElement to this.__activeElementRightBeforeHide in OverlayController.js
       - set this.__activeElementRightBeforeHide to this.contentNode.getRootNode().activeElement instead of document.activeElement

* chore: moved test to assert if element specified in dialog config key elementToFocusAfterHide is in viewport when dialog is closed to OverlayController.test.js

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-04-13 15:04:23 +02:00
gvangeest
5516bec4ba chore(overlays): add documentation about role=none is used 2023-03-20 14:18:53 +01:00
jorenbroekema
42a463eee1 fix(ui/overlays): set <dialog> wrapping el padding to 0 2023-03-11 00:05:23 +01:00
Thijs Louisse
af2e0293a1 fix(ui): [overlays]: enhance adoptStyles fallback and make testable 2023-01-12 11:35:01 +01:00
Thijs Louisse
973b6ff9ac chore: small cleanup and RichSelect demo fix 2022-12-20 19:46:57 +01:00
Thijs Louisse
7ac0a42224 fix(ui): overlay fixes (responsive backdrop/select-rich/tooltip) 2022-12-16 08:47:48 +01:00
Thijs Louisse
5e70716862 fix(ui): prevent infinite tooltip loops 2022-12-15 16:52:02 +01:00
Thijs Louisse
fafd922251 fix(ui): add adopted stylesheets once; attach correctly to body 2022-12-12 14:31:14 +01:00
Thijs Louisse
a96c9692af chore: fix elementToFocusAfterHide when shadow dom is used 2022-12-09 15:54:28 +01:00
Thijs Louisse
0bc604d600 fix: demos and overlay styles
chore: overlay documentation fixes
2022-12-09 15:54:28 +01:00
Thijs Louisse
64c0e26c20 feat: use dialog element for top layer functionality of all overlays 2022-12-09 15:54:28 +01:00
Thijs Louisse
f0e6ee922c feat(ui): export side effect free singletons for deduping multiple instances before "main" singleton instance is registered 2022-11-28 18:02:48 +01:00
Thijs Louisse
de51dae20b fix(ui): use the correct names for singleton registrations 2022-11-28 18:02:48 +01:00
Thomas Allmer
dec62b3b0d fix(ui): type requestUpdate 2022-11-22 19:29:37 +01:00
Thijs Louisse
36260d39d1 chore: add exception in test for "keepBodySize" on MacSafari, since body.body.global-overlays-scroll-lock-ios-fix renders scrollbar 2022-11-21 12:59:54 +01:00
Thijs Louisse
5d76318e45 chore: test "preventScroll edge cases" iOS and MacSafari 2022-11-21 12:59:54 +01:00