Commit graph

235 commits

Author SHA1 Message Date
Thijs Louisse
1dce98d4a8 fix(ui): fix focus first erroneous for listbox 2024-07-23 17:14:49 +02:00
gerjanvangeest
f9ba215675 fix(overlays): prevent closing of a modal dialog on pressing Esc and hidesOnEsc is set to false 2024-07-03 16:19:00 +02:00
ByoungYong Kim
5917423bc9 Fix a lint error, remove unnecessary lines 2024-06-27 11:39:18 +02:00
ByoungYong Kim
d75976a238 fix: Fix a bug when the same file is added on the single file input, the model value gets empty 2024-06-27 10:33:06 +02:00
ByoungYong Kim
74940911a0 fix: add files more than once doesn't overwrite anymore 2024-06-27 10:32:50 +02:00
gerjanvangeest
e4efb6dc03
chore: add description for opened to the jsdoc (#2305) 2024-06-24 11:39:52 +02:00
gerjanvangeest
b2d7d9b4a4
Fix/input file a11y (#2304)
* fix(input-file): improve accessibility

* chore: update the message

* chore: add the translations

* chore: fix linting

* chore: add changeset
2024-06-17 10:52:21 +02:00
gerjanvangeest
3dbee0c9b0
fix: add translations to the type of validation message (#2226) 2024-06-17 09:28:51 +02:00
gerjanvangeest
8e450423da
chore: add api tables to all components (#2297)
* chore: add api tables to all components

* chore: only use eleventyignore as ignore files for rocket
2024-06-10 15:30:20 +02:00
gerjanvangeest
b50b960daa
fix(combobox): update the code to when show and hide the overlay, to be more robust (#2301) 2024-06-10 15:10:08 +02:00
Dan Carlo Canlas
57597bb9ba
fix(form-core): Implement conversion of name attribute value to string type 2024-05-22 23:11:01 +02:00
gerjanvangeest
08a1cb1688
fix(tabs): make tab panels focusable (#2281) 2024-05-22 09:24:20 +02:00
Dozom
08d13e1a30
fix(slotmixin): now prints console error when shadowRoot is not found 2024-05-21 16:20:07 +02:00
Kristján Oddsson
c7c83d1d8b
update prettier
* update prettier to v3.x
* update prettify in @lion/nodejs-helpers to match updated prettier
* remove redundant await for promise
* remove `@types/prettier` as it's now included in `prettier`
* format lit template snippets with `jsx`
2024-05-17 21:43:23 +02:00
Thijs Louisse
aea90ae036 chore(root): cleanup and update dependencies 2024-05-14 13:47:11 +02:00
Thijs Louisse
519cb9c91a fix: cleanup dependencies, code and deprecated cli commands (extend-docs, search, etc.) 2024-05-14 13:47:10 +02:00
gerjanvangeest
36f0bbce3c
fix(select-rich): only close the overlay on tab when trapsKeyboardFocus is false (#2273) 2024-04-29 10:44:01 +02:00
gerjanvangeest
a53ded7ef8
fix(localize): make use of formatDate locale option to parse the date correctly (#2270) 2024-04-23 14:42:00 +02:00
Kristján Oddsson
c8093bd55b
Update eslint proper (#2254)
* update eslint

* Fix ESLint violations

* just ignore the rules for now
2024-04-23 10:31:22 +02:00
SomaH
3a1482f751
Fix select rich key interaction not setting correct isTriggeredByUser value (#2262)
* fix: select-rich keyboard navigation not marked as isTriggeredByUser

* Add changeset
2024-04-23 10:27:17 +02:00
gerjanvangeest
4c69c7e34f
chore: update eslint-plugin-lit-a11y version (#2259) 2024-04-16 15:16:40 +02:00
okadurin
ac783460aa fix: optimize the way we focus the input field for LionInputTelDropdown 2024-04-15 11:18:37 +02:00
Thijs Louisse
2da9a400a3 feat(ui): [core] allow browserDetection to be run in ssr context 2024-04-10 12:12:40 +02:00
gerjanvangeest
e8e9c07ec5
fix(input-amount): returns Unparseable as a modelValue if a wrong value has been entered (#2242)
* fix(input-amount): returns Unparseable as a modelValue if a wrong value has been entered

* fix(input-amount): do not break when a large amount has been entered

* Update docs/components/input-amount/overview.md

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* Update packages/ui/components/input-amount/test/parsers.test.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-04-10 11:20:48 +02:00
Wessam Zaghloul
d2edadd3b0
fix(select-rich): readonly works with keyboard interaction (#2235) 2024-04-03 10:26:21 +02:00
ByoungYong Kim
f6b3f43a03
feat(select-rich): export getSelectRichMembers test helper
* chore: fix a misleading test

* chore: add gitignored file to prettier ignore

* chore: add getSelectRichMembers test helpers

* feat(select-rich): export getSelectRichMembers test helper

---------

Co-authored-by: ByoungYong Kim <9986886+ryubro@users.noreply.github.com>
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2024-04-03 09:20:19 +02:00
Thijs Louisse
f0333bbc1c feat(ui): [SlotMixin] allow to (re)render scoped elements as direct light dom child 2024-04-02 16:40:03 +02:00
Max Larionov
37deecd2a3 feat: support cross-root registration with form-element-register event 2024-04-02 15:33:45 +02:00
gerjanvangeest
395595198c chore(ui): release 0.6.0
chore: update beta release steps

chore: prepare release

chore: regenerate pkg-lock

chrore: try prev working pkg-lock
2024-03-27 18:05:48 +01:00
okadurin
7ecf043679 fix: type errors for SlotMixin.test.js 2024-03-27 18:03:36 +01:00
Thijs Louisse
8b90d52064 feat: allow SlotRerenderObject to to first render on connectedCallback via firstRenderOnConnected 2024-03-27 18:02:16 +01:00
gerjanvangeest
61db0eda9f fix(overlays): skip local-positioning tests for firefox, added a todo to fix later
* fix(overlays): skip local-positioning tests for Firefox, and added a todo to fix later

* Update packages/ui/components/overlays/test/local-positioning.test.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* feat(core): add Firefox to browserDetection

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-03-27 18:02:16 +01:00
gerjanvangeest
a847f99388 fix(textarea): fix box-sizing inside tests to make it work cross browser (#2210) 2024-03-27 18:02:16 +01:00
gerjanvangeest
2fab9e5559 fix(input-tel-dropdown): use ScopedElementsMixin in to run test-suite with select-rich (#2209) 2024-03-27 18:02:16 +01:00
Oleksii Okadurin
8fd440d9d0 fix(ui): type fixes ScopedElements 2024-03-27 18:02:16 +01:00
Oleksii Okadurin
ea71f6194b fix(ui): LionInputStepper focus issue 2024-03-27 18:02:16 +01:00
gerjanvangeest
31e079d591 feat(form): set focus to the first erroneous form element on submit 2024-03-27 18:02:16 +01:00
Oleksii Kadurin
00a7e39aae feat(ui): adopt @open-wc/scoped-elements mixin v3
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-03-27 18:02:15 +01:00
gerjanvangeest
8bd27555a8 chore: update to lit3 and other dependencies
BREAKING CHANGE: update to latest major versions of lit, autosize, awesome-phonenumber & ibantools

- fix(validation-messages): get correct validation min and max dates in French (#2163)

- feat(ui): update to lit version 3 and update lion prod dependencies, and create an alpha release

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2024-03-27 18:00:34 +01:00
Thijs Louisse
8b7cc43f26 feat: allow SlotRerenderObject to first render on connectedCallback via firstRenderOnConnected 2024-03-15 13:19:59 +01:00
Thijs Louisse
91fad70130 fix(ui): only use elementToFocusAfterHide when provided as HTMLElement 2024-03-08 13:43:01 +01:00
gerjanvangeest
cf616e1e6b fix(input-tel-dropdown): prevent jumping to input field on each arrow key in windows/linux
Apply suggestions from code review
2024-03-06 16:15:15 +01:00
gerjanvangeest
bf2a2e02ef chore: fix failing test with switching locale 2024-03-06 15:52:36 +01:00
gerjanvangeest
e72fd6d6ea feat(form-core): add select and upload specific required messages 2024-03-06 15:52:36 +01:00
Danny Moerkerke
36bf8c6ff5
fix: uncommented a previously commented line since this is probably a mistake and breaks functionality
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: uncommented a previously commented line since this is probably a mistake and breaks functionality

* Update packages/ui/components/input-file/src/LionInputFile.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-03-06 15:21:09 +01:00
Thijs Louisse
eb46728826 fix: migrate deprecated performUpdate api to scheduleUpdate 2024-02-21 23:36:53 +01:00
gerjanvangeest
9b9e78951f fix(checkbox-group): add role=list and role=listitem to checkbox-indeterminate and its children 2024-02-19 17:51:09 +01:00
gerjanvangeest
92a5cd1e3d fix(form-core): remove fieldset label from input-field aria-labelledby, add opt-in via data-label 2024-02-19 17:39:22 +01:00
gerjanvangeest
87005afbd2
feat(input-stepper): a11y enhancement & added translations (#2173) 2024-02-19 17:01:32 +01:00
gerjanvangeest
19256d31bf fix(form-core): set aria-disabled next to the disabled attribute for NVDA screen reader 2024-02-19 16:00:19 +01:00
gerjanvangeest
059b018793 fix(input-range): add screen-reader labels for minimum and maximum value 2024-02-19 15:59:56 +01:00
gerjanvangeest
659cbff18c fix(form-core): order aria-labelledby and aria-describedby based on slot order instead of dom order 2024-02-19 15:59:32 +01:00
Thijs Louisse
5073ea4760 feat: split up validate-messages per entrypoint for smarter bundling 2024-02-13 11:58:37 +01:00
gerjanvangeest
69c9da8fe1
fix(validation-messages): get correct validation min and max dates in French (#2163) 2024-01-03 14:01:47 +01:00
Alberto López-Barranco
c80bca7c83
fix(overlay-controller): do not scroll to invoker if it is visible (#2155)
* fix(overlay-controller): do not scroll to invoker if it is visible on screen

When closing an overlay, srollIntoView forced the invoker element to be placed in the middle of the screen. This fix prevents the scroll if the invoker is already visible, but still scrolls it into view if needed.

* chore: changeset
2023-12-11 12:44:01 +01:00
gerjanvangeest
d997e5233e
fix(tooltip): hide tooltip if the invoker gets disabled (#2154) 2023-12-06 13:37:23 +01:00
Gyulai Levente
db96e8cc07
fix(tabs): set selectedIndex only if differ from previous selectedIndex 2023-12-01 09:57:19 +01:00
SynnefonK
cb25a60397
chore: fix DE locale typo for validation messages (#2115)
* chore: fix DE locale typo for validation messages

* Update packages/ui/components/validate-messages/translations/de.js

Co-authored-by: tkgroot <tkuppensgroo@uos.de>

* Update packages/ui/components/validate-messages/translations/de.js

Co-authored-by: tkgroot <tkuppensgroo@uos.de>

* chore: add changeset (#2146)

Signed-off-by: Tobias Kuppens Groot <tkuppensgroo@uos.de>

---------

Signed-off-by: Tobias Kuppens Groot <tkuppensgroo@uos.de>
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
Co-authored-by: tkgroot <tkuppensgroo@uos.de>
2023-11-29 11:19:56 +01:00
gerjanvangeest
9b5edf30fb
fix(localize): parseDate by default to 2000 instead of 1900 when date is below 49 (#2148) 2023-11-29 10:52:21 +01:00
Sergey Ilinsky
bf782223a7
Fix/reuse UUID missing parent callback disabled property (#2090)
* refactor: reuse uuid function from the core

* fix: invoke parent class callback

* fix: do not run disabled property reflection unless it was part of the changeset
2023-11-27 14:07:18 +01:00
Iván Gómez Alonso
322b06521c
fix(ui): use traditional style on ios for adopt-styles 2023-11-24 12:02:06 +01:00
Thijs Louisse
bdb038e197 chore: test/lint/swc fixes + changeset providence 2023-11-09 11:38:39 +01:00
Thijs Louisse
45fe0b4bb3 chore(ui): lint and types fixes 2023-11-08 19:08:54 +01:00
Thijs Louisse
f601d59d77 chore: fix test and generate pkg-lock 2023-11-08 19:03:28 +01:00
Thijs Louisse
9731550f62 fix(ui): combobox a11y 2023-11-08 19:02:55 +01:00
Thijs Louisse
60032a2df0 fix(ui): make compatible with latest playwright browsers 2023-11-08 19:01:21 +01:00
Thijs Louisse
c6663068a7 fix(ui): cleanup IE edge case in getAriaElementsInRightDomOrder 2023-11-08 19:01:21 +01:00
Guilherme Amorim
be4e25a108
feat: support (multiselect) choice-groups with allow-custom-choice 2023-11-08 15:05:09 +01:00
Oleksii Kadurin
c459ded9d8
fix: autocomplete for combobox (reset activeIndex when needed) 2023-11-07 12:58:59 +01:00
Oleksii Kadurin
f421bd7326
fix: update documentation and unit tests for validation 2023-11-07 11:21:41 +01:00
Guilherme Amorim
e923ba40a3
Fix(lion-radio-group): Resetting a group containing options with formatters (#2101)
* fix(lion-radio-group): Resetting a group containing options with formatters doesn't check the default value

* refactor: update test name
2023-10-18 17:10:26 +02:00
Guilherme Amorim
7235a4f703
fix(lion-combobox): The event emitted during clear has stale value (#2104) 2023-10-18 17:00:30 +02:00
Gyulai Levente
be36bf3b1b
fix(input-amount): Link currency to label after setting currency from… (#2091) 2023-10-17 14:55:13 +02:00
barna
63a8e725db
fix(lion-calendar): Make calendar buttons selectable on firefox through datepicker (#2080) 2023-10-17 14:52:53 +02:00
alejandrofernandezcanton
b1320a9a9c
fix(overlay): avoid calling push in iterable object to avoid error loading overlays (#2088) 2023-10-17 14:44:51 +02:00
Gyulai Levente
dcf3a4b0bd
fix(combobox): Fix search issues when modifying the middle of the input word (#2085) 2023-10-17 13:52:10 +02:00
gerjanvangeest
6ccfb27868
fix(input-datepicker): only disable dates if validator is of type error (#2076) 2023-09-12 15:10:43 +02:00
Gyulai Levente
d1f92a3ad7
fix(lion-calendar): Make disabled dates not selectable via keyboard navigation (#2058)
* fix(calendar): Make disabled dates not selectable

* Add changeset

* chore(calendar): add skipped test for select date on [Enter]

---------

Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2023-09-12 15:10:23 +02:00
gerjanvangeest
d597c077b4
fix(localize): fix type of localizeNameSpaces (#2073) 2023-09-11 16:45:16 +02:00
Sciurus7
cecf5ed573
fix(lion-accordion): make a copy when changing expanded (#2047) 2023-09-11 14:55:30 +02:00
Gyulai Levente
857d47a933
fix(accordion): navigating with tab confuses the arrow key navigation (#2056)
* fix(accordion): Handle focusin event, when tabbing to an invoker

* fix(accordion): Add changeset

* fix(accordion): Test if the index equals to the focusedIndex
2023-09-11 14:43:52 +02:00
gerjanvangeest
9b9485dbaa
fix(calendar): focusCentralDate function should only use buttons inside the dates table (#2072) 2023-09-11 14:24:39 +02:00
Gyulai Levente
b89d889fd5
fix(calendar): render exactly 6 weeks in every months (#2037) 2023-09-07 15:01:09 +02:00
Fábio Santos
ebe13e14b0
fix(overlays): undefined document.body (#2070)
* Fix undefined `document.body`

* Add changeset
2023-09-06 13:34:04 +02:00
Gio Adrian Fortuno
b0a74f2831
fix(progress-indicator): accept 0 as a valid value (#2068)
* fix(progress-indicator): accept 0 as a valid value

* chore: added changeset
2023-09-04 13:02:34 +02:00
Thijs Louisse
e16de38cd6 chore: enhance execution on empty api 2023-08-30 13:46:40 +02:00
Thijs Louisse
4cc72b1251 feat: allow Required validator on Fieldset and Form; "static executesOnEmpty" flag on Validators 2023-08-30 13:46:40 +02:00
Víctor Lara
5eafa1ffc1
fix(overlays): add aria-hidden to arrow (#2030) 2023-07-10 08:18:08 +02:00
gerjanvangeest
b44bfc5d1f
feat: enable navigation to, selecting & give accessible message for calendar disabled dates (#1978)
Co-authored-by: Konstantinos Norgias <Konstantinos.Norgias@ing.com>
2023-07-04 10:36:18 +02:00
Danny Moerkerke
137a1b6cf5
Feat/is dragging prop (#2025)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* feat: added isDragging property
2023-06-27 09:18:41 +02:00
Danny Moerkerke
0745ce8526
Fix/input file types (#2021)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* chore: exported correct types for lion-input-file

* fix: fixed type errors
2023-06-22 10:48:49 +02:00
Danny Moerkerke
259e0dd468
Fix/remove file (#2018)
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: removed composed: true and bubbles: true and set eventlistener directly on lion-selected-file-list

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* fix: fixed test

* Update packages/ui/components/input-file/test/lion-input-file.test.js

* chore: format

* fix

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2023-06-20 17:32:05 +02:00
gerjanvangeest
7ec90dcb06
chore: add checkboxIndeterminate test suite (#2013) 2023-06-14 16:24:34 +02:00
gerjanvangeest
02e61285dd
Revert "fix: create exports for test-suites and test-helpers (#2010)" (#2012)
This reverts commit 3cfc9f9744.
2023-06-13 15:14:47 +02:00
gerjanvangeest
1ea5730aa5
fix(localize): align currency symbol usage for all browsers (#2011) 2023-06-13 14:57:26 +02:00
gerjanvangeest
3cfc9f9744
fix: create exports for test-suites and test-helpers (#2010) 2023-06-13 08:47:56 +02:00
gerjanvangeest
dbc3fc2db6
fix(combobox): submit form on [Enter] (#2005)
fix(combobox): submit form on [Enter]
2023-06-08 18:14:14 +02:00
Danny Moerkerke
8b9c8050e5
Fix/upload response (#2000)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

* chore: corrected property names in demo and removed demo of prefilled state

* chore: renamed `_fileSelectResponse` back to `uploadResponse` and restored demo of prefilled state

---------

Co-authored-by: gvangeest <gerjan.van.geest@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-07 12:57:34 +02:00
Thijs Louisse
6893421779
chore: SlotRerenderObject aligned with reactive cycle (docs + changelog) (#1999) 2023-06-07 09:16:28 +02:00
gerjanvangeest
d2de984f0b
Feat/input file (#1881)
* feat(input-file): create input-file component

* chore: improvements after review

* chore: update after review

* chore: update translations

* chore: - fixed demo with form submit, submit was not prevented
       - fixed checking allowed file extensions
       - fixed clicking on select file button in drag and drop area

* chore: since the input-file does not upload files itself but enables user to select files, I replaced "upload" and "upload" with "select" and "selected" where applicable

* chore: - removed unused properties allowedFileTypes and allowedFileExtensions from lion-input-file
       - cleaned up docs

* chore: - changed type Array.<type> to Array<type>
       - removed redundant type definition

* fix: - FocusMixin: moved registering events for from connectedCallback to firstUpdated since _focusableNode is sometimes not available yet
     - SlotMixin: changed updated to update in since slots were rendered too late (related to previous fix in FocusMixin.js)

* fix: renamed lion-uploaded-file-list.js to lion-selected-file-list.js

* fix: fixed test for lion-selected-file-list

* fix: fixed typ

* wip

* fix: - fixed issue with multiple file selection where element would not select valid files after invalid ones
     - added getMessage method to FileValidation that returns empty string to prevent message being shown that error message must be configured
     - fixed tests

* chore: replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.

* fix: - replaced `uploadOnFormSubmit` with `uploadOnSelect` and flipped the default value to false. When `uploadOnSelect` is set to true, the file will be uploaded as soon as it is selected.
     - fixed issue where a valid file was not selected and added to the file list if it was preceded by an invalid file

* chore: removed redundant README.md

* fix: fixed failing test

* chore: added missing type annotation

* chore: annotated event param as optional

---------

Co-authored-by: Danny Moerkerke <danny.moerkerke@ing.com>
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-06-06 11:30:43 +02:00