Commit graph

403 commits

Author SHA1 Message Date
ByoungYong Kim
22b8f24804
Fix indeterminate checkbox edge cases (#2458)
* Add failing tests

* Fix the issues with indeterminate checkbox

* Update the fix

* Clean up the code

* Add changeset

* Fix a type issue

* Refactor the code

* Fix a bug regarding disabled checked sub checkbox

* Add test case where subCheckboxes are added and removed dynamically

* Make a few node reference optional as it spits undefined error when the element is removed
2025-02-04 11:08:57 +01:00
github-actions[bot]
eea6726289 Version Packages 2025-01-30 16:53:27 +01:00
gerjanvangeest
35b600a64b Update packages/ui/components/select-rich/test/lion-select-rich-interaction.test.js
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-30 16:14:11 +01:00
gerjanvangeest
175e920151 Update packages/ui/components/select-rich/test/lion-select-rich-interaction.test.js
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-30 16:14:11 +01:00
gerjanvangeest
41fecd367e fix(select-rich): allow arrowLeft and arrowRight to change the value when navigateWithinInvoker is true and dropdown is closed 2025-01-30 16:14:11 +01:00
Thijs Louisse
29b729ed84 fix(ui): [input-amount] make sure that previous locale is not used for parsing on user-edit with <= 2 decimals 2025-01-30 15:53:09 +01:00
Jakub Gurgacz
b9833795b1
Update polish translations for MinNumber and MaxNumber (#2459)
* Update polish translations for MinNumber and MaxNumber

Polish translations of the MinNumber and MaxNumber validation error messages indicate that min, max is an open interval.

* add changeset
2025-01-29 11:14:47 +01:00
github-actions[bot]
04a61d1e10 Version Packages 2025-01-29 10:33:28 +01:00
Oleksii Kadurin
a1d6dd90a8
Set aria-disabled to true or delete it (#2452)
fix: remove aria-disabled attribute
2025-01-22 12:16:56 +01:00
gerjanvangeest
2155e455ee fix(overlays): add tabindex="-1" to prevent tooltips get focus in Safari and Firefox 2025-01-21 10:40:40 +01:00
Thijs Louisse
5344fdeb66 fix(ui/core): rerender direct host child with right slot attr when root is switched 2025-01-21 10:39:52 +01:00
gerjanvangeest
81e2a1d2d1
fix(calendar): add translations for disabled dates (#2450) 2025-01-21 09:35:42 +01:00
gerjanvangeest
dd598125ef
feat(dialog): add is-alert-dialog option (#2445)
* feat(dialog): add is-alert-dialog option

* chore: make alert-dialog example simpler
2025-01-21 09:21:34 +01:00
gerjanvangeest
795237d19e
fix(form-core): add aria-hidden=true to the graphic element of the choiceInput (#2447) 2025-01-20 09:46:10 +01:00
github-actions[bot]
43b694e7f8 Version Packages 2025-01-15 16:39:49 +01:00
Thijs Louisse
d5258d56fd
fix(ui): [form-core] enhance formatter and parser meta; reset _isPasting on task instead of microtask
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2025-01-15 16:33:02 +01:00
gerjanvangeest
35e66052b6
fix(input-amount): parse amount always on locale once the amount is formatted (#2439)
* fix(input-amount): parse amount always  on locale once the amount is formatted

* chore: add unit test

* chore: add some description

* chore: update playwright script to install dependencies

* Update .github/workflows/verify-pr.yml

* chore: set formatOptions temp and cleanup for programmatic api

* feat(form-core): add "user-edit" mode to formatOptions while editing existing value of a form control

* chore: enhance code readability and robustness

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-15 09:59:02 +01:00
Thijs Louisse
8377e8d17d fix(overlays): rework setup and teardown logic of OverlayMixin
Add a failing test

chore: broken test fix

chore: harden overlay teardown tests and cleanup select-rich
2025-01-13 15:33:28 +01:00
Thijs Louisse
fef94cd016 chore: clean test logs 2025-01-07 09:39:29 +01:00
Thijs Louisse
e5ff2b01d2 fix(overlays): overlayController teardown cleanup 2025-01-07 09:39:29 +01:00
github-actions[bot]
9825cbf656
Version Packages (#2429)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-12-19 09:21:01 +01:00
gerjanvangeest
a256f737c0
fix(input-tel): remove the country telephone code from the modelValue on init (#2432) 2024-12-19 09:15:02 +01:00
Tono Arnau
0652492621
fix(input-datepicker): update spanish translation for openDatePickerLabel (#2433)
* fix(input-datepicker): update spanish translation for openDatePickerLabel

* chore: update ui version
2024-12-18 15:16:24 +01:00
Oleksii Kadurin
e11788492f
do not show overlay when _showOverlayCondition is "false" (#2421)
fix: show overlay based on subclassers' _showOverlayCondition
2024-12-12 17:03:30 +01:00
gerjanvangeest
67f5735538
fix(input-stepper): move role=spinbutton to input node (#2426)
* fix(input-stepper): move role=spinbutton to input node

* chore: rename __boundOnEnterButton and __boundOnLeaveButton
2024-12-11 15:41:32 +01:00
github-actions[bot]
5b235fec11 Version Packages 2024-12-04 12:59:20 +00:00
gerjanvangeest
d1f5e088ff
chore(input-stepper): remove valueTextMapping attribute (#2425) 2024-12-04 13:58:11 +01:00
Thijs Louisse
3d49a4100b chore(core): prevent click on disabled elements 2024-12-04 12:01:42 +01:00
gerjanvangeest
5dc2205d7d
feat(input-stepper): add aria-valuemin, aria-valuemax and an option t… (#2423)
* feat(input-stepper): add aria-valuemin, aria-valuemax and an option to set aria-valuetext

* chore: change valueText into an Object

* chore: remove reflect of valueText

* Update packages/ui/components/input-stepper/src/LionInputStepper.js

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>

* Update packages/ui/components/input-stepper/src/LionInputStepper.js

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>

* chore: rename valueText to valueTextMapping

---------

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>
2024-12-04 11:59:09 +01:00
Thijs Louisse
9dcb361dfb chore: add remaining internal usages of isActiveElement in tests 2024-11-28 17:19:16 +01:00
Thijs Louisse
382a9aab64 fix: make sure that voiceover + safari modals are accessible 2024-11-28 17:19:16 +01:00
github-actions[bot]
3d9d8f383c Version Packages 2024-11-28 08:41:51 +00:00
Oleksii Kadurin
eac4312030
fix: announce current page for pagination (#2419)
fix: announce current page for pagination
2024-11-28 09:40:43 +01:00
github-actions[bot]
104c49449e
Version Packages (#2415)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-11-25 14:17:48 +01:00
ByoungYong Kim
a51e28d7a5
Fix the issue that dynamically updated disabled date doesn't update the central date (#2411)
* Fix the issue that dynamically updated disabled date doesn't update the central date

* Fix types

* Remove setTimeout

* Add changeset

* Improve the changeset description
2024-11-21 15:40:12 +01:00
Thijs Louisse
3e13adedc2
fix: make web-test-runner using documentOrShadowRoot.activeElement debuggable 2024-11-21 09:01:13 +01:00
github-actions[bot]
d80a8e9dff Version Packages 2024-11-13 08:22:17 +01:00
Krisztian Horvath
86ca2e072e
fix(overlays): fix memory leaks of adopt-styles and OverlayMixin
* fix(overlays): fix memory leaks of adopt-styles and OverlayMixin

* fix(overlays): support reconnecting the OverlayController to the OverlayManager

* chore: move unregister logic to OverlayController

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-11-12 17:25:37 +01:00
Gyulai Levente
2a989f47cf
fix(overlays): clicking outside iframe not closing the overlay 2024-11-12 17:24:21 +01:00
Thijs Louisse
6da73f7a36 chore: allow tests to run w/o polyfill
Co-authored-by: aghArdeshir <ardeshirizadinl@gmail.com>
2024-11-12 16:21:36 +01:00
Thijs Louisse
510f8b931f fix(core): no registration of same class twice w/o scoped-registries polyfill 2024-11-12 16:21:36 +01:00
github-actions[bot]
8dc51c1066
Version Packages (#2406)
* Version Packages

* Update packages/ui/CHANGELOG.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-11-12 14:33:15 +01:00
Hardik Pithva
9b92fa216e
fix(form-core): allow to use '_$isValidator$' instead of instanceof check (supporting multiple versions of Validator)
* fix(form-core): make use of `validatorName` and `type` to check validator instance

* fix(form-core): check for nullability for disabled prop

* fix: add `_$isValidator$` property to improve the check

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* test: add check for _$isValidator$

* chore: catch edge cases in cem script

* chore: cleanup, docs, and add prop on ctor to be more unobtrusive

* chore: changeset

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2024-11-12 13:28:08 +01:00
github-actions[bot]
0bee6e3e0b Version Packages 2024-11-06 12:04:34 +01:00
Thijs Louisse
0582868e41 fix: expand script that corrects types after build 2024-11-06 11:59:33 +01:00
Riovir
a4f654a32b fix(ui/types): export FocusHost type from types/form-core.js 2024-11-05 22:34:16 +01:00
github-actions[bot]
f393e6d783 Version Packages 2024-11-05 17:11:50 +01:00
Thijs Louisse
360641c487 fix(overlays): no hiding of nested overlays having hideOnEsc configured 2024-11-05 17:02:03 +01:00
github-actions[bot]
a5b2c2d977 Version Packages 2024-10-31 12:14:07 +01:00
Thijs Louisse
2c38a919bc fix(core): make scoped-elements ssr-compatible
fix(core): ssr-support scopedElements
2024-10-31 10:48:51 +01:00
Thijs Louisse
fb3bdd6a17 chore(localize): cleanup of LocalizeManager 2024-10-31 10:48:51 +01:00
Thijs Louisse
da5ae6743a fix(localize): make LocalizeManager run with lit-ssr 2024-10-31 10:48:51 +01:00
Thijs Louisse
1626dbd460 fix(ui): improve test experience in dev-mode 2024-10-30 15:51:55 +01:00
gerjanvangeest
7c2b4692d3
fix(validation-feedback): do not display type of the validation feedback message, if there is no message 2024-10-29 17:53:54 +01:00
github-actions[bot]
16681c85e3 Version Packages 2024-10-29 12:43:49 +01:00
gerjanvangeest
bc175b5609 chore: update portal url 2024-10-29 12:15:39 +01:00
Thijs Louisse
7baecb5e19 fix(ui/localize.js): make LocalizeManager ssr-compatible 2024-10-29 12:09:42 +01:00
gerjanvangeest
2d4fb0ecdb
fix(form-core): add focusableNode to choiceGroupMixin to make _setFo… (#2382)
* fix(form-core): add focusableNode to choiceGroupMixin to make \_setFocusOnFirstErroneousFormElement function work for checkbox-group and radio-group

* chore: rewrite check for _setFocusOnFirstErroneousFormElement to make it work without focusableNode inside LionChoiceGroup
2024-10-22 15:44:01 +02:00
github-actions[bot]
ed1c9517e4 Version Packages 2024-10-16 12:16:06 +00:00
Thijs Louisse
dbb964077f chore: update/clean devDependencies for better security and perf 2024-10-16 14:14:26 +02:00
Krisztian Horvath
5530eefb88
fix(ui/calendar): use correct firstUpdated type signature (#2379) 2024-10-14 16:22:36 +02:00
Oleksii Kadurin
27af6be0db
fix: tests for keyboard typing (#2371) 2024-10-14 16:03:13 +02:00
gerjanvangeest
96b09e56d1
fix(accordion): make accordion closeable again (#2376) 2024-10-14 14:33:20 +02:00
github-actions[bot]
577e05eb94
Version Packages (#2374)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-10-07 08:39:44 +02:00
John Clifford
4696ad72c9
feat(accordion): add exclusive option (#2372)
* Added exclusive feature for accordion

* Changed position of exclusive accordion

* chore: accordion [exclusive] option

* chore: accordion [exclusive] option

* chore: fixes and cleanups

* chore: get docs of accordion back

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2024-10-03 15:52:39 +02:00
gerjanvangeest
5ce7fee5f2
fix(validate-messages): set correct fieldName to required select validation message (#2373) 2024-10-03 09:09:38 +02:00
github-actions[bot]
b25478e4cc
Version Packages (#2365)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-09-18 11:16:35 +02:00
ByoungYong Kim
bb1f347699
fix the bug that disabled date becomes central date (#2361)
* fix the bug that disabled date becomes central date

* add test

* Fix tests

* Fix lint error

* Add changeset

* Fix a typo
2024-09-16 11:12:10 +02:00
ByoungYong Kim
9f7935c1a3
Use model value chain instead of hard-coding formatted value and value (#2362)
* Use model value chain instead of hard-coding formatted value and value

* Add test

* Add changeset
2024-09-12 14:50:22 +02:00
github-actions[bot]
a59d362cc1
Version Packages (#2343)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-09-11 08:21:50 +02:00
ByoungYong Kim
f628ecfb15 Remove test for no-longer supported feature 2024-09-03 14:42:40 +02:00
ByoungYong Kim
e4ffdd9e54 Fix the bug 2024-09-03 14:42:40 +02:00
ByoungYong Kim
1a4f49719d Add test 2024-09-03 14:42:40 +02:00
ka9de
bca25bc41e
fix(ui/overlays): overlay growing margin (#2331) 2024-08-28 13:59:48 +02:00
okadurin
89360b56db fix: clean code for overlay isModal 2024-08-28 13:31:28 +02:00
Oleksii Kadurin
e0f0ea4937
Update packages/ui/components/overlays/test/OverlayController.test.js
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2024-08-28 11:29:32 +02:00
okadurin
1d128d4973 fix dialog aria-expand attribute 2024-08-28 10:13:29 +02:00
okadurin
54219c52ea fix dialog aria-expand attribute 2024-08-28 09:26:41 +02:00
Oleksii Kadurin
e9b64bf253
Update packages/ui/components/dialog/test/lion-dialog.test.js
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
2024-08-28 09:26:02 +02:00
okadurin
719991fdd3 fix dialog aria-expand attribute 2024-08-27 16:55:45 +02:00
okadurin
5f92a722e6 Revert "fix: add aria-expanded attribute only for the non-modal dialogs"
This reverts commit fa832d900b.
2024-08-27 16:48:27 +02:00
okadurin
fa832d900b fix: add aria-expanded attribute only for the non-modal dialogs 2024-08-27 16:46:29 +02:00
gerjanvangeest
02a9427a7d
fix(combobox): when multiple choice reset all listbox options on select (#2332)
* fix(combobox): when multiple choice reset all listbox options on select

* Apply suggestions from code review

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* chore: clear options also on click

* chore: adopt code to show list when only when showAllOnEmpty is true

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2024-08-27 10:48:12 +02:00
Ardeshir Izadi
0a71670069
chore: Missing closing tag in button test suite (#2348) 2024-08-26 09:28:04 +02:00
gerjanvangeest
61bf8cb4b1
fix(select-rich): sets and removes the button role and aria attributes on change of singleOption (#2341) 2024-08-22 15:08:28 +02:00
Rajkeshwar Prasad
e0ef676a36
opened-changed event detail exposes opened state (#2334)
* opened-changed event detail exposes opened state

* Fixed lint issue

* Generated changeset

---------

Co-authored-by: Rajkeshwar Prasad <rajkeshwarp@azuga.com>
Co-authored-by: Rajkeshwar Prasad <--global>
2024-08-22 13:12:50 +02:00
github-actions[bot]
19d4dd271f Version Packages 2024-08-07 08:30:34 +00:00
gerjanvangeest
cdf0a9e8f0
fix(input-stepper): add parseNumber and formatNumber to format the va… (#2312)
* fix(input-stepper): add parseNumber and formatNumber to format the value based on locale

* Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js

* Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js
2024-08-07 10:29:02 +02:00
Oleksii Kadurin
58796deb0e
fix: add slot support to deepContains function 2024-08-01 18:55:36 +02:00
Thijs Louisse
436d5eebbe
Merge pull request #2310 from ing-bank/fix/modal-dialog-esc
fix(overlays): prevent closing of a modal dialog on pressing Esc and …
2024-07-24 16:09:31 +02:00
github-actions[bot]
2ff8369cf9 Version Packages 2024-07-23 15:16:25 +00:00
Thijs Louisse
1dce98d4a8 fix(ui): fix focus first erroneous for listbox 2024-07-23 17:14:49 +02:00
gerjanvangeest
f9ba215675 fix(overlays): prevent closing of a modal dialog on pressing Esc and hidesOnEsc is set to false 2024-07-03 16:19:00 +02:00
github-actions[bot]
a0ea788ed6 Version Packages 2024-06-27 11:50:04 +00:00
ByoungYong Kim
5917423bc9 Fix a lint error, remove unnecessary lines 2024-06-27 11:39:18 +02:00
ByoungYong Kim
d75976a238 fix: Fix a bug when the same file is added on the single file input, the model value gets empty 2024-06-27 10:33:06 +02:00
ByoungYong Kim
74940911a0 fix: add files more than once doesn't overwrite anymore 2024-06-27 10:32:50 +02:00
gerjanvangeest
e4efb6dc03
chore: add description for opened to the jsdoc (#2305) 2024-06-24 11:39:52 +02:00
gerjanvangeest
b2d7d9b4a4
Fix/input file a11y (#2304)
* fix(input-file): improve accessibility

* chore: update the message

* chore: add the translations

* chore: fix linting

* chore: add changeset
2024-06-17 10:52:21 +02:00
gerjanvangeest
3dbee0c9b0
fix: add translations to the type of validation message (#2226) 2024-06-17 09:28:51 +02:00