ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2929 commits 2 branches 0 tags 107 MiB
Commit graph

287 commits

Author SHA1 Message Date
Oleksii Kadurin
e11788492f
do not show overlay when _showOverlayCondition is "false" (#2421) 
fix: show overlay based on subclassers' _showOverlayCondition
 2024-12-12 17:03:30 +01:00
gerjanvangeest
67f5735538
fix(input-stepper): move role=spinbutton to input node (#2426) 
* fix(input-stepper): move role=spinbutton to input node

* chore: rename __boundOnEnterButton and __boundOnLeaveButton
 2024-12-11 15:41:32 +01:00
gerjanvangeest
d1f5e088ff
chore(input-stepper): remove valueTextMapping attribute (#2425) 2024-12-04 13:58:11 +01:00
Thijs Louisse
3d49a4100b chore(core): prevent click on disabled elements 2024-12-04 12:01:42 +01:00
gerjanvangeest
5dc2205d7d
feat(input-stepper): add aria-valuemin, aria-valuemax and an option t… (#2423) 
* feat(input-stepper): add aria-valuemin, aria-valuemax and an option to set aria-valuetext

* chore: change valueText into an Object

* chore: remove reflect of valueText

* Update packages/ui/components/input-stepper/src/LionInputStepper.js

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>

* Update packages/ui/components/input-stepper/src/LionInputStepper.js

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>

* chore: rename valueText to valueTextMapping

---------

Co-authored-by: Oleksii Kadurin <ovkadurin@gmail.com>
 2024-12-04 11:59:09 +01:00
Thijs Louisse
9dcb361dfb chore: add remaining internal usages of isActiveElement in tests 2024-11-28 17:19:16 +01:00
Thijs Louisse
382a9aab64 fix: make sure that voiceover + safari modals are accessible 2024-11-28 17:19:16 +01:00
Oleksii Kadurin
eac4312030
fix: announce current page for pagination (#2419) 
fix: announce current page for pagination
 2024-11-28 09:40:43 +01:00
ByoungYong Kim
a51e28d7a5
Fix the issue that dynamically updated disabled date doesn't update the central date (#2411) 
* Fix the issue that dynamically updated disabled date doesn't update the central date

* Fix types

* Remove setTimeout

* Add changeset

* Improve the changeset description
 2024-11-21 15:40:12 +01:00
Thijs Louisse
3e13adedc2
fix: make web-test-runner using documentOrShadowRoot.activeElement debuggable 2024-11-21 09:01:13 +01:00
Krisztian Horvath
86ca2e072e
fix(overlays): fix memory leaks of adopt-styles and OverlayMixin 
* fix(overlays): fix memory leaks of adopt-styles and OverlayMixin

* fix(overlays): support reconnecting the OverlayController to the OverlayManager

* chore: move unregister logic to OverlayController

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
 2024-11-12 17:25:37 +01:00
Gyulai Levente
2a989f47cf
fix(overlays): clicking outside iframe not closing the overlay 2024-11-12 17:24:21 +01:00
Thijs Louisse
6da73f7a36 chore: allow tests to run w/o polyfill 
Co-authored-by: aghArdeshir <ardeshirizadinl@gmail.com>
 2024-11-12 16:21:36 +01:00
Thijs Louisse
510f8b931f fix(core): no registration of same class twice w/o scoped-registries polyfill 2024-11-12 16:21:36 +01:00
Hardik Pithva
9b92fa216e
fix(form-core): allow to use '_$isValidator$' instead of instanceof check (supporting multiple versions of Validator) 
* fix(form-core): make use of `validatorName` and `type` to check validator instance

* fix(form-core): check for nullability for disabled prop

* fix: add `_$isValidator$` property to improve the check

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* fix: disable dot notation to avoid the renaming for the prop during build/minification

* test: add check for _$isValidator$

* chore: catch edge cases in cem script

* chore: cleanup, docs, and add prop on ctor to be more unobtrusive

* chore: changeset

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
 2024-11-12 13:28:08 +01:00
Thijs Louisse
0582868e41 fix: expand script that corrects types after build 2024-11-06 11:59:33 +01:00
Thijs Louisse
360641c487 fix(overlays): no hiding of nested overlays having hideOnEsc configured 2024-11-05 17:02:03 +01:00
Thijs Louisse
2c38a919bc fix(core): make scoped-elements ssr-compatible 
fix(core): ssr-support scopedElements
 2024-10-31 10:48:51 +01:00
Thijs Louisse
fb3bdd6a17 chore(localize): cleanup of LocalizeManager 2024-10-31 10:48:51 +01:00
Thijs Louisse
da5ae6743a fix(localize): make LocalizeManager run with lit-ssr 2024-10-31 10:48:51 +01:00
Thijs Louisse
1626dbd460 fix(ui): improve test experience in dev-mode 2024-10-30 15:51:55 +01:00
gerjanvangeest
7c2b4692d3
fix(validation-feedback): do not display type of the validation feedback message, if there is no message 2024-10-29 17:53:54 +01:00
gerjanvangeest
bc175b5609 chore: update portal url 2024-10-29 12:15:39 +01:00
Thijs Louisse
7baecb5e19 fix(ui/localize.js): make LocalizeManager ssr-compatible 2024-10-29 12:09:42 +01:00
gerjanvangeest
2d4fb0ecdb
fix(form-core): add focusableNode to choiceGroupMixin to make _setFo… (#2382) 
* fix(form-core): add focusableNode to choiceGroupMixin to make \_setFocusOnFirstErroneousFormElement function work for checkbox-group and radio-group

* chore: rewrite check for _setFocusOnFirstErroneousFormElement to make it work without focusableNode inside LionChoiceGroup
 2024-10-22 15:44:01 +02:00
Thijs Louisse
dbb964077f chore: update/clean devDependencies for better security and perf 2024-10-16 14:14:26 +02:00
Krisztian Horvath
5530eefb88
fix(ui/calendar): use correct firstUpdated type signature (#2379) 2024-10-14 16:22:36 +02:00
Oleksii Kadurin
27af6be0db
fix: tests for keyboard typing (#2371) 2024-10-14 16:03:13 +02:00
gerjanvangeest
96b09e56d1
fix(accordion): make accordion closeable again (#2376) 2024-10-14 14:33:20 +02:00
John Clifford
4696ad72c9
feat(accordion): add exclusive option (#2372) 
* Added exclusive feature for accordion

* Changed position of exclusive accordion

* chore: accordion [exclusive] option

* chore: accordion [exclusive] option

* chore: fixes and cleanups

* chore: get docs of accordion back

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
 2024-10-03 15:52:39 +02:00
gerjanvangeest
5ce7fee5f2
fix(validate-messages): set correct fieldName to required select validation message (#2373) 2024-10-03 09:09:38 +02:00
ByoungYong Kim
bb1f347699
fix the bug that disabled date becomes central date (#2361) 
* fix the bug that disabled date becomes central date

* add test

* Fix tests

* Fix lint error

* Add changeset

* Fix a typo
 2024-09-16 11:12:10 +02:00
ByoungYong Kim
9f7935c1a3
Use model value chain instead of hard-coding formatted value and value (#2362) 
* Use model value chain instead of hard-coding formatted value and value

* Add test

* Add changeset
 2024-09-12 14:50:22 +02:00
ByoungYong Kim
f628ecfb15 Remove test for no-longer supported feature 2024-09-03 14:42:40 +02:00
ByoungYong Kim
e4ffdd9e54 Fix the bug 2024-09-03 14:42:40 +02:00
ByoungYong Kim
1a4f49719d Add test 2024-09-03 14:42:40 +02:00
ka9de
bca25bc41e
fix(ui/overlays): overlay growing margin (#2331) 2024-08-28 13:59:48 +02:00
okadurin
89360b56db fix: clean code for overlay isModal 2024-08-28 13:31:28 +02:00
Oleksii Kadurin
e0f0ea4937
Update packages/ui/components/overlays/test/OverlayController.test.js 
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
 2024-08-28 11:29:32 +02:00
okadurin
1d128d4973 fix dialog aria-expand attribute 2024-08-28 10:13:29 +02:00
okadurin
54219c52ea fix dialog aria-expand attribute 2024-08-28 09:26:41 +02:00
Oleksii Kadurin
e9b64bf253
Update packages/ui/components/dialog/test/lion-dialog.test.js 
Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
 2024-08-28 09:26:02 +02:00
okadurin
719991fdd3 fix dialog aria-expand attribute 2024-08-27 16:55:45 +02:00
okadurin
5f92a722e6 Revert "fix: add aria-expanded attribute only for the non-modal dialogs" 
This reverts commit fa832d900b.
 2024-08-27 16:48:27 +02:00
okadurin
fa832d900b fix: add aria-expanded attribute only for the non-modal dialogs 2024-08-27 16:46:29 +02:00
gerjanvangeest
02a9427a7d
fix(combobox): when multiple choice reset all listbox options on select (#2332) 
* fix(combobox): when multiple choice reset all listbox options on select

* Apply suggestions from code review

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* chore: clear options also on click

* chore: adopt code to show list when only when showAllOnEmpty is true

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
 2024-08-27 10:48:12 +02:00
Ardeshir Izadi
0a71670069
chore: Missing closing tag in button test suite (#2348) 2024-08-26 09:28:04 +02:00
gerjanvangeest
61bf8cb4b1
fix(select-rich): sets and removes the button role and aria attributes on change of singleOption (#2341) 2024-08-22 15:08:28 +02:00
Rajkeshwar Prasad
e0ef676a36
opened-changed event detail exposes opened state (#2334) 
* opened-changed event detail exposes opened state

* Fixed lint issue

* Generated changeset

---------

Co-authored-by: Rajkeshwar Prasad <rajkeshwarp@azuga.com>
Co-authored-by: Rajkeshwar Prasad <--global>
 2024-08-22 13:12:50 +02:00
gerjanvangeest
cdf0a9e8f0
fix(input-stepper): add parseNumber and formatNumber to format the va… (#2312) 
* fix(input-stepper): add parseNumber and formatNumber to format the value based on locale

* Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js

* Update packages/ui/components/input-stepper/test/lion-input-stepper.test.js
 2024-08-07 10:29:02 +02:00
Oleksii Kadurin
58796deb0e
fix: add slot support to deepContains function 2024-08-01 18:55:36 +02:00
Thijs Louisse
436d5eebbe
Merge pull request #2310 from ing-bank/fix/modal-dialog-esc 
fix(overlays): prevent closing of a modal dialog on pressing Esc and …
 2024-07-24 16:09:31 +02:00
Thijs Louisse
1dce98d4a8 fix(ui): fix focus first erroneous for listbox 2024-07-23 17:14:49 +02:00
gerjanvangeest
f9ba215675 fix(overlays): prevent closing of a modal dialog on pressing Esc and hidesOnEsc is set to false 2024-07-03 16:19:00 +02:00
ByoungYong Kim
5917423bc9 Fix a lint error, remove unnecessary lines 2024-06-27 11:39:18 +02:00
ByoungYong Kim
d75976a238 fix: Fix a bug when the same file is added on the single file input, the model value gets empty 2024-06-27 10:33:06 +02:00
ByoungYong Kim
74940911a0 fix: add files more than once doesn't overwrite anymore 2024-06-27 10:32:50 +02:00
gerjanvangeest
e4efb6dc03
chore: add description for opened to the jsdoc (#2305) 2024-06-24 11:39:52 +02:00
gerjanvangeest
b2d7d9b4a4
Fix/input file a11y (#2304) 
* fix(input-file): improve accessibility

* chore: update the message

* chore: add the translations

* chore: fix linting

* chore: add changeset
 2024-06-17 10:52:21 +02:00
gerjanvangeest
3dbee0c9b0
fix: add translations to the type of validation message (#2226) 2024-06-17 09:28:51 +02:00
gerjanvangeest
8e450423da
chore: add api tables to all components (#2297) 
* chore: add api tables to all components

* chore: only use eleventyignore as ignore files for rocket
 2024-06-10 15:30:20 +02:00
gerjanvangeest
b50b960daa
fix(combobox): update the code to when show and hide the overlay, to be more robust (#2301) 2024-06-10 15:10:08 +02:00
Dan Carlo Canlas
57597bb9ba
fix(form-core): Implement conversion of name attribute value to string type 2024-05-22 23:11:01 +02:00
gerjanvangeest
08a1cb1688
fix(tabs): make tab panels focusable (#2281) 2024-05-22 09:24:20 +02:00
Dozom
08d13e1a30
fix(slotmixin): now prints console error when shadowRoot is not found 2024-05-21 16:20:07 +02:00
Kristján Oddsson
c7c83d1d8b
update prettier 
* update prettier to v3.x
* update prettify in @lion/nodejs-helpers to match updated prettier
* remove redundant await for promise
* remove `@types/prettier` as it's now included in `prettier`
* format lit template snippets with `jsx`
 2024-05-17 21:43:23 +02:00
Thijs Louisse
aea90ae036 chore(root): cleanup and update dependencies 2024-05-14 13:47:11 +02:00
Thijs Louisse
519cb9c91a fix: cleanup dependencies, code and deprecated cli commands (extend-docs, search, etc.) 2024-05-14 13:47:10 +02:00
gerjanvangeest
36f0bbce3c
fix(select-rich): only close the overlay on tab when trapsKeyboardFocus is false (#2273) 2024-04-29 10:44:01 +02:00
gerjanvangeest
a53ded7ef8
fix(localize): make use of formatDate locale option to parse the date correctly (#2270) 2024-04-23 14:42:00 +02:00
Kristján Oddsson
c8093bd55b
Update eslint proper (#2254) 
* update eslint

* Fix ESLint violations

* just ignore the rules for now
 2024-04-23 10:31:22 +02:00
SomaH
3a1482f751
Fix select rich key interaction not setting correct isTriggeredByUser value (#2262) 
* fix: select-rich keyboard navigation not marked as isTriggeredByUser

* Add changeset
 2024-04-23 10:27:17 +02:00
gerjanvangeest
4c69c7e34f
chore: update eslint-plugin-lit-a11y version (#2259) 2024-04-16 15:16:40 +02:00
okadurin
ac783460aa fix: optimize the way we focus the input field for LionInputTelDropdown 2024-04-15 11:18:37 +02:00
Thijs Louisse
2da9a400a3 feat(ui): [core] allow browserDetection to be run in ssr context 2024-04-10 12:12:40 +02:00
gerjanvangeest
e8e9c07ec5
fix(input-amount): returns Unparseable as a modelValue if a wrong value has been entered (#2242) 
* fix(input-amount): returns Unparseable as a modelValue if a wrong value has been entered

* fix(input-amount): do not break when a large amount has been entered

* Update docs/components/input-amount/overview.md

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* Update packages/ui/components/input-amount/test/parsers.test.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
 2024-04-10 11:20:48 +02:00
Wessam Zaghloul
d2edadd3b0
fix(select-rich): readonly works with keyboard interaction (#2235) 2024-04-03 10:26:21 +02:00
ByoungYong Kim
f6b3f43a03
feat(select-rich): export getSelectRichMembers test helper 
* chore: fix a misleading test

* chore: add gitignored file to prettier ignore

* chore: add getSelectRichMembers test helpers

* feat(select-rich): export getSelectRichMembers test helper

---------

Co-authored-by: ByoungYong Kim <9986886+ryubro@users.noreply.github.com>
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
 2024-04-03 09:20:19 +02:00
Thijs Louisse
f0333bbc1c feat(ui): [SlotMixin] allow to (re)render scoped elements as direct light dom child 2024-04-02 16:40:03 +02:00
Max Larionov
37deecd2a3 feat: support cross-root registration with form-element-register event 2024-04-02 15:33:45 +02:00
gerjanvangeest
395595198c chore(ui): release 0.6.0 
chore: update beta release steps

chore: prepare release

chore: regenerate pkg-lock

chrore: try prev working pkg-lock
 2024-03-27 18:05:48 +01:00
okadurin
7ecf043679 fix: type errors for SlotMixin.test.js 2024-03-27 18:03:36 +01:00
Thijs Louisse
8b90d52064 feat: allow SlotRerenderObject to to first render on connectedCallback via firstRenderOnConnected 2024-03-27 18:02:16 +01:00
gerjanvangeest
61db0eda9f fix(overlays): skip local-positioning tests for firefox, added a todo to fix later 
* fix(overlays): skip local-positioning tests for Firefox, and added a todo to fix later

* Update packages/ui/components/overlays/test/local-positioning.test.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>

* feat(core): add Firefox to browserDetection

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
 2024-03-27 18:02:16 +01:00
gerjanvangeest
a847f99388 fix(textarea): fix box-sizing inside tests to make it work cross browser (#2210) 2024-03-27 18:02:16 +01:00
gerjanvangeest
2fab9e5559 fix(input-tel-dropdown): use ScopedElementsMixin in to run test-suite with select-rich (#2209) 2024-03-27 18:02:16 +01:00
Oleksii Okadurin
8fd440d9d0 fix(ui): type fixes ScopedElements 2024-03-27 18:02:16 +01:00
Oleksii Okadurin
ea71f6194b fix(ui): LionInputStepper focus issue 2024-03-27 18:02:16 +01:00
gerjanvangeest
31e079d591 feat(form): set focus to the first erroneous form element on submit 2024-03-27 18:02:16 +01:00
Oleksii Kadurin
00a7e39aae feat(ui): adopt @open-wc/scoped-elements mixin v3 
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
 2024-03-27 18:02:15 +01:00
gerjanvangeest
8bd27555a8 chore: update to lit3 and other dependencies 
BREAKING CHANGE: update to latest major versions of lit, autosize, awesome-phonenumber & ibantools

- fix(validation-messages): get correct validation min and max dates in French (#2163)

- feat(ui): update to lit version 3 and update lion prod dependencies, and create an alpha release

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
 2024-03-27 18:00:34 +01:00
Thijs Louisse
8b7cc43f26 feat: allow SlotRerenderObject to first render on connectedCallback via firstRenderOnConnected 2024-03-15 13:19:59 +01:00
Thijs Louisse
91fad70130 fix(ui): only use elementToFocusAfterHide when provided as HTMLElement 2024-03-08 13:43:01 +01:00
gerjanvangeest
cf616e1e6b fix(input-tel-dropdown): prevent jumping to input field on each arrow key in windows/linux 
Apply suggestions from code review
 2024-03-06 16:15:15 +01:00
gerjanvangeest
bf2a2e02ef chore: fix failing test with switching locale 2024-03-06 15:52:36 +01:00
gerjanvangeest
e72fd6d6ea feat(form-core): add select and upload specific required messages 2024-03-06 15:52:36 +01:00
Danny Moerkerke
36bf8c6ff5
fix: uncommented a previously commented line since this is probably a mistake and breaks functionality 
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: uncommented a previously commented line since this is probably a mistake and breaks functionality

* Update packages/ui/components/input-file/src/LionInputFile.js

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
 2024-03-06 15:21:09 +01:00
Thijs Louisse
eb46728826 fix: migrate deprecated performUpdate api to scheduleUpdate 2024-02-21 23:36:53 +01:00
gerjanvangeest
9b9e78951f fix(checkbox-group): add role=list and role=listitem to checkbox-indeterminate and its children 2024-02-19 17:51:09 +01:00
gerjanvangeest
92a5cd1e3d fix(form-core): remove fieldset label from input-field aria-labelledby, add opt-in via data-label 2024-02-19 17:39:22 +01:00