Commit graph

2004 commits

Author SHA1 Message Date
Thijs Louisse
9a80ba9c55 chore: test for disconnected overlay 2025-07-28 15:58:44 +02:00
Denilson Sá Maia
1d3a00c022 fix(form-core): don't remove event listeners if _focusableNode was not set
This fix is similar to the previous commit.

Under very specific circumstances on a very complicated application logic, a file input field (that
extends from FocusMixin) gets created and immediately destroyed. This unfortunately causes an
error, because the `disconnectedCallback()` gets called to remove the event listeners for a
component that hasn't been fully set up.

> Uncaught TypeError: this._focusableNode is null
2025-07-26 15:05:49 +02:00
Denilson Sá Maia
ef7f16a51c fix(overlays): don't call _setupOverlayCtrl() in OverlayMixin if the component is not connected
In our application, there is a very complicated logic that creates a bunch of form fields based on some data. It's very complicated, we hate that logic; but it exists, it works, and it is being used in production.

Somewhere in that logic, under a very specific case, a datepicker form field is created, connected, and then immediately disconnected. Don't ask me why, I said it is complicated.

This commit fixes a bug in OverlayMixin. The `connectedCallback` calls `_setupOverlayCtrl()` asynchronously, after a `Promise.then()`. Thus, by the time this setup function is called, the component has already been disconnected (and `disconnectedCallback()` has already been called).

The fix is simple: don't try to setup the overlay if the component is no longer connected.
2025-07-26 15:05:49 +02:00
Riovir
4460db7630 fix(dedupe-mixin): resolve version conflict between v1 and v2
@open-wc/scoped-elements 3.0.5 depends on the v1 version of the @open-wc/dedupe-mixin. The 3.0.6 version however depends on the v2. This causes a version conflict with @lion/ui.
2025-07-26 13:02:39 +02:00
github-actions[bot]
226f0cf003
Version Packages (#2540)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-07-17 16:47:11 +02:00
Bilal Özlü
9a4a8735b0
fix: editing negative numbers (#2538)
* fix: editing negative numbers

* fix: editing negative numbers (changeset added)
2025-07-17 14:20:26 +02:00
github-actions[bot]
eef0c48e41
Version Packages (#2533)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-07-07 09:46:02 +02:00
Stijn Van Asschodt
85666d6c49
feat(input-tel): use first preferred region to set a default region
* feat(input-tel): use first preferred region to set a default region

Takes priority over locale, but comes after user input

* chore(input-tel): add changeset
2025-07-03 21:00:05 +02:00
Stijn Van Asschodt
dc5d224e98
fix(input-tel): use full locale to translate country names in dropdown (#2526)
* fix(input-tel): use full locale to translate country names in dropdown

* test(input-tel): add test for nameForLocale in input tel dropdown

* test(input-tel): update name for locale test suite to fr-BE locale
2025-07-02 09:56:50 +02:00
github-actions[bot]
af6e47e4b5
Version Packages (#2519)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-05-21 11:17:18 +02:00
gerjanvangeest
cbe8f8656b
fix(input-file): set buttonLabel initially (#2524)
* fix(input-file): set buttonLabel initially

* chore(input-file): add test for locale change
2025-05-21 09:54:39 +02:00
selcen.sonmez
a0d334dc54
feat: add Turkish (tr) translations to form-core, input-datepicker & pagination (#2516)
* feat(input-datepicker): add Turkish translations

* chore: add changeset for Turkish translation

* feat(input-datepicker): add Turkish translations

* chore: consolidate all Turkish translations into a single changeset
2025-05-15 16:56:48 +02:00
gerjanvangeest
bcf269d92f
chore(input-stepper): small edit after previous input-stepper fix (#2523) 2025-05-15 08:05:51 +02:00
manuel
cf4a8fd1b0
feat(input-stepper): align value with step size (#2511)
* feat(input-stepper): add alignToStep property to align value with step size

* Create silver-eyes-count.md

* refactor: make alignTosTep property behavior as default behavior and remove property attribute

* test(input-stepper): handle min value as Infinity and update tests for decrement/increment behavior

---------

Co-authored-by: Manuel Servais <manuel.servais@ing.com>
2025-05-14 16:46:00 +02:00
Vladimir Skorokhod
f9f55193c3
LionInputFile: Customize the text content of the selected files for screen reader if uploadOnSelect is enabled (#2509)
* update lion input file component and en translations

* update tests for input file

* add changeset

* add german and russian translations

* chore: add NL translations and fix small 2 bugs in fileNameDescriptionLabels

* fix lint error

---------

Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2025-05-13 13:00:20 +02:00
Mete Abduraman
07b089e80f
fix(validate-mixin): determine required or result validators based on characteristics (#2498)
* fix(validate-mixin): determine if a required validator or result validator has been registered based on characteristics

* chore(validate-mixin): create changeset
2025-05-08 08:42:12 +02:00
github-actions[bot]
6d7e6a6487 Version Packages 2025-04-30 09:31:49 +02:00
Thijs Louisse
3c77296c40 chore: redo release, so that @lion/ui 0.11.4 will be published 2025-04-30 09:29:34 +02:00
github-actions[bot]
50be120c4f Version Packages 2025-04-30 09:20:55 +02:00
Thijs Louisse
c3021f8e7f fix(form-core): make sure that slots with property fallbacks ignore initialization updates (undefined on firstUpdated) 2025-04-30 08:33:31 +02:00
ByoungYong Kim
1769e291d4
Revert version package PR (#2513)
* chore: wireit actions v2

* Update wireit version

* Revert "Version Packages (#2508)"

This reverts commit 2f47f23494.
2025-04-28 08:57:01 +02:00
github-actions[bot]
2f47f23494
Version Packages (#2508)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-04-24 15:44:28 +02:00
gerjanvangeest
23cd9841ed
fix(combobox): do not submit form if overlay of combobox is opened and ENTER is hit (#2481) 2025-04-08 15:07:42 +02:00
Thijs Louisse
9827228b83 fix(providence): use globby again 2025-03-20 10:29:39 +01:00
github-actions[bot]
87a1cb4d5b Version Packages 2025-03-19 10:41:20 +01:00
Oleksii Kadurin
ebd31ed90a
Add tests for combobox (#2491)
add a test for combobox
2025-03-17 10:49:04 +01:00
Sebastian Kamiński
a181a035e9
fix: bug that accepted 3 digit year (#2489)
* fix: bug that accepted 3 digit year

* fix: bug that accepted 3 digit year

* Update packages/ui/components/localize/test/date/parseDate.test.js

---------

Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>
2025-03-13 08:34:56 +01:00
github-actions[bot]
593b753f0f
Version Packages (#2470)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-03-06 11:05:47 +01:00
Dominik Hufnagel
b2464bc170 fix: remove unused typed method 2025-02-24 16:24:18 +01:00
gerjanvangeest
d86c1f7439
fix(select-rich): block arrow key interaction when singleOption is set (#2474) 2025-02-13 14:35:52 +01:00
gerjanvangeest
933a0ea089
chore: add sorting to api tables (#2476) 2025-02-13 14:10:02 +01:00
ByoungYong Kim
22b8f24804
Fix indeterminate checkbox edge cases (#2458)
* Add failing tests

* Fix the issues with indeterminate checkbox

* Update the fix

* Clean up the code

* Add changeset

* Fix a type issue

* Refactor the code

* Fix a bug regarding disabled checked sub checkbox

* Add test case where subCheckboxes are added and removed dynamically

* Make a few node reference optional as it spits undefined error when the element is removed
2025-02-04 11:08:57 +01:00
github-actions[bot]
eea6726289 Version Packages 2025-01-30 16:53:27 +01:00
gerjanvangeest
35b600a64b Update packages/ui/components/select-rich/test/lion-select-rich-interaction.test.js
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-30 16:14:11 +01:00
gerjanvangeest
175e920151 Update packages/ui/components/select-rich/test/lion-select-rich-interaction.test.js
Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-30 16:14:11 +01:00
gerjanvangeest
41fecd367e fix(select-rich): allow arrowLeft and arrowRight to change the value when navigateWithinInvoker is true and dropdown is closed 2025-01-30 16:14:11 +01:00
Thijs Louisse
29b729ed84 fix(ui): [input-amount] make sure that previous locale is not used for parsing on user-edit with <= 2 decimals 2025-01-30 15:53:09 +01:00
Jakub Gurgacz
b9833795b1
Update polish translations for MinNumber and MaxNumber (#2459)
* Update polish translations for MinNumber and MaxNumber

Polish translations of the MinNumber and MaxNumber validation error messages indicate that min, max is an open interval.

* add changeset
2025-01-29 11:14:47 +01:00
github-actions[bot]
04a61d1e10 Version Packages 2025-01-29 10:33:28 +01:00
Oleksii Kadurin
a1d6dd90a8
Set aria-disabled to true or delete it (#2452)
fix: remove aria-disabled attribute
2025-01-22 12:16:56 +01:00
gerjanvangeest
2155e455ee fix(overlays): add tabindex="-1" to prevent tooltips get focus in Safari and Firefox 2025-01-21 10:40:40 +01:00
Thijs Louisse
5344fdeb66 fix(ui/core): rerender direct host child with right slot attr when root is switched 2025-01-21 10:39:52 +01:00
gerjanvangeest
81e2a1d2d1
fix(calendar): add translations for disabled dates (#2450) 2025-01-21 09:35:42 +01:00
gerjanvangeest
dd598125ef
feat(dialog): add is-alert-dialog option (#2445)
* feat(dialog): add is-alert-dialog option

* chore: make alert-dialog example simpler
2025-01-21 09:21:34 +01:00
gerjanvangeest
795237d19e
fix(form-core): add aria-hidden=true to the graphic element of the choiceInput (#2447) 2025-01-20 09:46:10 +01:00
github-actions[bot]
43b694e7f8 Version Packages 2025-01-15 16:39:49 +01:00
Thijs Louisse
d5258d56fd
fix(ui): [form-core] enhance formatter and parser meta; reset _isPasting on task instead of microtask
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
2025-01-15 16:33:02 +01:00
gerjanvangeest
35e66052b6
fix(input-amount): parse amount always on locale once the amount is formatted (#2439)
* fix(input-amount): parse amount always  on locale once the amount is formatted

* chore: add unit test

* chore: add some description

* chore: update playwright script to install dependencies

* Update .github/workflows/verify-pr.yml

* chore: set formatOptions temp and cleanup for programmatic api

* feat(form-core): add "user-edit" mode to formatOptions while editing existing value of a form control

* chore: enhance code readability and robustness

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
2025-01-15 09:59:02 +01:00
Thijs Louisse
8377e8d17d fix(overlays): rework setup and teardown logic of OverlayMixin
Add a failing test

chore: broken test fix

chore: harden overlay teardown tests and cleanup select-rich
2025-01-13 15:33:28 +01:00
Thijs Louisse
fef94cd016 chore: clean test logs 2025-01-07 09:39:29 +01:00