Commit graph

22 commits

Author SHA1 Message Date
okadurin
89360b56db fix: clean code for overlay isModal 2024-08-28 13:31:28 +02:00
okadurin
54219c52ea fix dialog aria-expand attribute 2024-08-28 09:26:41 +02:00
okadurin
719991fdd3 fix dialog aria-expand attribute 2024-08-27 16:55:45 +02:00
okadurin
5f92a722e6 Revert "fix: add aria-expanded attribute only for the non-modal dialogs"
This reverts commit fa832d900b.
2024-08-27 16:48:27 +02:00
okadurin
fa832d900b fix: add aria-expanded attribute only for the non-modal dialogs 2024-08-27 16:46:29 +02:00
gerjanvangeest
f9ba215675 fix(overlays): prevent closing of a modal dialog on pressing Esc and hidesOnEsc is set to false 2024-07-03 16:19:00 +02:00
Thijs Louisse
91fad70130 fix(ui): only use elementToFocusAfterHide when provided as HTMLElement 2024-03-08 13:43:01 +01:00
Alberto López-Barranco
c80bca7c83
fix(overlay-controller): do not scroll to invoker if it is visible (#2155)
* fix(overlay-controller): do not scroll to invoker if it is visible on screen

When closing an overlay, srollIntoView forced the invoker element to be placed in the middle of the screen. This fix prevents the scroll if the invoker is already visible, but still scrolls it into view if needed.

* chore: changeset
2023-12-11 12:44:01 +01:00
Fábio Santos
ebe13e14b0
fix(overlays): undefined document.body (#2070)
* Fix undefined `document.body`

* Add changeset
2023-09-06 13:34:04 +02:00
Danny Moerkerke
5b8d655f10
Fix/dialog scroll to top ios (#1957)
* fix: possible fix for iOS focus issue WIP

* chore: added test for elementToFocusAfterHide WIP

* chore: dialog tests for elementToFocusAFterHide

* chore: added test to assert element specified in `elementToFocusAfterHide` config key of lion-dialog is scrolled into the viewport

* chore: - added test to assert that element specified in dialog config key `elementToFocusAfterHide` is not focused when the dialog is closed if the user deliberately moved focus to another element while the dialog was open
       - added changeset

* chore: - removed unneeded button
       - renamed this.__activeElement to this.__activeElementRightBeforeHide in OverlayController.js
       - set this.__activeElementRightBeforeHide to this.contentNode.getRootNode().activeElement instead of document.activeElement

* chore: moved test to assert if element specified in dialog config key elementToFocusAfterHide is in viewport when dialog is closed to OverlayController.test.js

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
2023-04-13 15:04:23 +02:00
gvangeest
5516bec4ba chore(overlays): add documentation about role=none is used 2023-03-20 14:18:53 +01:00
jorenbroekema
42a463eee1 fix(ui/overlays): set <dialog> wrapping el padding to 0 2023-03-11 00:05:23 +01:00
Thijs Louisse
af2e0293a1 fix(ui): [overlays]: enhance adoptStyles fallback and make testable 2023-01-12 11:35:01 +01:00
Thijs Louisse
973b6ff9ac chore: small cleanup and RichSelect demo fix 2022-12-20 19:46:57 +01:00
Thijs Louisse
7ac0a42224 fix(ui): overlay fixes (responsive backdrop/select-rich/tooltip) 2022-12-16 08:47:48 +01:00
Thijs Louisse
5e70716862 fix(ui): prevent infinite tooltip loops 2022-12-15 16:52:02 +01:00
Thijs Louisse
fafd922251 fix(ui): add adopted stylesheets once; attach correctly to body 2022-12-12 14:31:14 +01:00
Thijs Louisse
a96c9692af chore: fix elementToFocusAfterHide when shadow dom is used 2022-12-09 15:54:28 +01:00
Thijs Louisse
0bc604d600 fix: demos and overlay styles
chore: overlay documentation fixes
2022-12-09 15:54:28 +01:00
Thijs Louisse
64c0e26c20 feat: use dialog element for top layer functionality of all overlays 2022-12-09 15:54:28 +01:00
Thomas Allmer
c1982965c3 feat: introduce wireit and ts use node16 resolution 2022-11-07 11:39:40 +01:00
Thomas Allmer
d938e464b4 chore: introduce a component src folder 2022-10-31 16:55:07 +01:00
Renamed from packages/ui/components/overlays/OverlayController.js (Browse further)