Commit graph

52 commits

Author SHA1 Message Date
Joren Broekema
33f639e885 fix(button): delay adding prevent event leakage handler by one frame 2021-02-01 10:38:59 +01:00
Joren Broekema
3fefc359b8 fix(button): add user-select rule with prefixes 2021-01-07 12:01:59 +01:00
Joren Broekema
0566c5475e
Merge pull request #1155 from ing-bank/fix/select-rich-inside-overlay
Fix/select rich inside overlay
2021-01-06 17:42:51 +01:00
Joren Broekema
718843e5ba fix(button): set user-select to none to make btn text not selectable 2021-01-06 17:33:51 +01:00
Jorge del Casar
98f1bb7e1c fix: normalize dependencies
Co-authored-by: jorenbroekema <Joren.Broekema@ing.com>
2021-01-06 10:53:38 +01:00
Thijs Louisse
27020f12af fix(button): make click event target predictable (always host) 2020-11-11 18:04:46 +01:00
Thijs Louisse
84ec97a640 fix(button): do not override aria-labelledby from user 2020-11-11 14:20:46 +01:00
Joren Broekema
b910d6f730 fix(button): set width/height clickarea 100% 2020-10-19 13:07:49 +02:00
jorenbroekema
f7ab53910d fix(button): set display to inline-flex for inline content 2020-10-16 12:24:46 +02:00
Jorge del Casar
26b605939f
refactor(button): several improvements (#1019)
- remove click-area --> move styles to host::before
- reduce css so that extending styles makes sense. Merge .btn with host
- reduce the template and remove the if else construction inside the template
- hide focus styles if they're not needed, for example, when an element receives focus via the mouse.
- improve __clickDelegationHandler. Use current slotted native button instead of create new one
- fix vertical align when 2 buttons are inline and one has icon. Example included.
- add min-with to ensure target size for mobile, not only height
- add test to check event.target in all situations (inside and outside form)
2020-10-15 12:13:46 +02:00
Thijs Louisse
6679fe7743 chore: types button and combobox 2020-10-08 16:06:50 +02:00
Thijs Louisse
e42071d8dc fix: types for overlays, tooltip, button 2020-09-09 12:21:22 +02:00
Joren Broekema
9f9d49ebcf fix(button): add mouseupHandler also on 'this', remove iron test helpers 2020-06-30 17:17:58 +02:00
Mathieu Puech
7eec6f3765 fix(button): prevent scrolling when repeating space key 2020-06-23 13:29:44 -04:00
qa46hx
8d8cb79b16 chore(tabs): improve readme for storybook 2020-06-10 10:27:27 +02:00
Hzunax
31ccb4a10f fix(button): aria-disabled for button and switch 2020-05-28 20:24:55 +02:00
Joren Broekema
a451d4fc8a chore: apply prettier formatting changes 2020-04-29 10:05:06 +02:00
Jorge del Casar
78cd503b5e fix(button): adjust button to more sensible default styling (#674) 2020-04-29 10:05:06 +02:00
Davide
9731771c23 fix: add display:none for hidden (#692) 2020-04-29 10:05:06 +02:00
Joren Broekema
2b2d6b34aa fix(button): prevent clickarea from blocking sibling content 2020-03-25 17:02:10 +01:00
Thijs Louisse
ce0630f32b fix: normalize subclasser apis 2020-02-27 11:07:12 +01:00
Thijs Louisse
97678dd49b chore: cleanup todos 2020-02-26 14:32:52 +01:00
Wessel Loth
166427871d fix(button): ie11 error when setting attribute in constructor 2020-02-14 15:16:31 +01:00
Wessel Loth
954adc5659 fix(button): run regexp once instead of every render cycle
chore: add browserDetection utility to @lion/core

Use it to fix test involving checking the userAgent in LionButton

chore: add browserDetection util to aria element sorting
2020-02-06 11:16:24 +01:00
90
52aaa756a7
fix(button): using space on button should not scroll page (#531) 2020-01-30 12:58:02 +01:00
erik
e1a417b041 feat: integrate and pass automated a11y testing 2019-12-03 15:15:01 +01:00
erik
0d7d513405 fix(button): make click event work in ie11 2019-11-18 12:53:38 +01:00
Joren Broekema
5999ea9569 fix: refactor slot selection 2019-11-15 15:50:18 +01:00
Joren Broekema
fdedcf2894 fix(button): make button more accessible 2019-11-13 11:01:37 +01:00
Joren Broekema
7995dfced5 chore(button): re-add and test 'type=reset' feature with native form 2019-10-21 08:22:39 +02:00
qa46hx
d19ca7cc5c fix(button): fix form integration, fires only once, submit preventable
Co-authored-by: Joren Broekema <Joren.Broekema@ing.com>
2019-10-21 07:58:27 +02:00
Joren Broekema
1a22c9bc5f fix(button): guard against _nativeButton not defined 2019-10-09 16:41:39 +02:00
Joren Broekema
aa8bfc626d chore(button): fix failing tests 2019-09-26 10:13:28 +02:00
Joren Broekema
a5752fcb6d fix(button): fix implicit form submission IE11 due to visibility hidden 2019-09-23 11:33:25 +02:00
Joren Broekema
94818e40fb fix(button): change redispatch click logic so form submit fires properly 2019-09-19 17:40:57 +02:00
erik
f2c15ce2c7 fix(button): make JAWS/IE11 work with inner button 2019-08-29 10:27:47 +02:00
Thomas Allmer
b3a1f912bc fix(button): sync type property instead of delegating 2019-08-13 17:28:23 +02:00
Mikhail Bashkirov
06124e06bf fix(button): prevent unnecessary keydown/keyup handlers 2019-07-26 16:45:49 +02:00
Mikhail Bashkirov
f3303ae014 fix(button): remove active when mouse/key up on other element (fix #210) 2019-07-26 16:44:55 +02:00
Mikhail Bashkirov
471d662cb2 feat(button): move active to host for cross-browser support (fix #188) 2019-07-26 16:43:10 +02:00
Mikhail Bashkirov
e269b5d040 fix(button): click event fired twice in IE11 (fix #179) 2019-07-26 16:43:09 +02:00
Thomas Allmer
732411cab2 feat(button): use DisabledWithTabIndexMixin 2019-07-25 16:01:13 +02:00
Thomas Allmer
d4299dec71 feat(button): reduce to minimal css 2019-07-25 15:25:16 +02:00
Thomas Allmer
f478b988f8 feat(button): add template hooks for before/after default slot 2019-07-25 15:25:16 +02:00
Mikhail Bashkirov
b7eb537d1d fix(button): make redispatch method protected 2019-07-12 16:14:23 +02:00
Mikhail Bashkirov
59e456e11f fix(button): put host element into click event target (fix #89) 2019-07-12 16:14:23 +02:00
Mikhail Bashkirov
b71177f667 fix(button): redispatch click event with all original properties 2019-07-12 16:14:22 +02:00
Mikhail Bashkirov
4a8c6ebbed fix(button): remove unnecessary instance method bind 2019-07-12 14:02:01 +02:00
Mikhail Bashkirov
d8098902c7 fix(button): indicate visually the active state on enter/space 2019-06-13 10:56:24 +02:00
Thomas Allmer
76ccb94435 fix(button): do not override user provided tabindex 2019-05-16 13:14:09 +02:00