ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2923 commits 2 branches 0 tags 107 MiB
Commit graph

81 commits

Author SHA1 Message Date
sainzrow
765a1a298c
fix(combobox): add support for disabled and readonly states 
* fix(combobox): don't use setAttribute for disabled/enabled attributes

How to reproduce this bug:

1. Go to https://lion.js.org/components/combobox/overview/ or just use the combobox in your application.
2. Inspect the combobox in the browser. Click on the `<lion-combobox>` element at the DOM inspector.
3. At the JavaScript console, print `$0.disabled`. Observe it is currently `false`, and the user can interact with it normally.
4. (optional) Run `$0.disabled =true`. Observe the user cannot interact with it anymore. That's expected.
5. Run `$0.disabled = false`.

BUG: The user cannot interact with the combobox anymore, despite `disabled` being false.

Root cause: If you inspect the `<input>` element, you can see it has `disabled="false"`.

The [specs](https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#enabling-and-disabling-form-controls:-the-disabled-attribute) say:

> The `disabled` content attribute is a [boolean attribute](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attribute).
>
> A form control is **disabled** if any of the following are true:
> * the element is a `button`, `input`, `select`, `textarea`, or form-associated custom element, and the `disabled` attribute is specified on this element (regardless of its value);

And [also](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attribute):

> A number of attributes are **boolean attributes**. The presence of a boolean attribute on an element represents the true value, and the absence of the attribute represents the false value.

Thanks to @thematho for finding the root cause.

* fix(combobox): add support for disabled and readonly states with corresponding tests

* Update packages/ui/components/combobox/src/LionCombobox.js

Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>

* Update packages/ui/components/combobox/src/LionCombobox.js

Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>

* Update packages/ui/components/combobox/src/LionCombobox.js

Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>

* fix(combobox): added accessibility tests

---------

Co-authored-by: Denilson Sá Maia <denilsonsa@gmail.com>
Co-authored-by: Thijs Louisse <t_louisse@hotmail.com>
 2025-07-28 16:29:32 +02:00
Thijs Louisse
c6ef6b134d chore: update to @lit/reactive-element 2.1.0 2025-04-30 08:33:31 +02:00
Thijs Louisse
0c3425c2b9
chore: wireit actions v2 + update wireit version 
* chore: wireit actions v2

* Update wireit version

---------

Co-authored-by: ByoungYong Kim <ryubro@users.noreply.github.com>
 2025-04-28 08:54:12 +02:00
Thijs Louisse
9827228b83 fix(providence): use globby again 2025-03-20 10:29:39 +01:00
Pavlik Kiselev
11bbc5fff5
feat: migrated the navigation metadata from inline MD title decorations to frontmatter 
* feat: migrated the navigation metadata from inline MD title decorations to frontmatter

* fix: fixed frontmatter metadate for api-table MDs

* fix: fixed frontmatter eslint issue
 2025-03-19 10:08:22 +01:00
Thijs Louisse
1025969bd9 chore: update scoped-registry-polyfill devDep 2025-02-27 15:59:52 +01:00
Thijs Louisse
103df25306 fix(providence): pin oxc-parser; fix default edge cases 2025-02-03 11:26:33 +01:00
Thijs Louisse
0d3b2fdeb5 fix(providence): update oxc-parser 2025-01-31 19:53:20 +01:00
Thijs Louisse
71992cc0fb feat(providence): update version of oxc; cleanup; include .ts(x) and jsx by default 2025-01-15 10:37:36 +01:00
Tono Arnau
0652492621
fix(input-datepicker): update spanish translation for openDatePickerLabel (#2433) 
* fix(input-datepicker): update spanish translation for openDatePickerLabel

* chore: update ui version
 2024-12-18 15:16:24 +01:00
Thijs Louisse
0582868e41 fix: expand script that corrects types after build 2024-11-06 11:59:33 +01:00
Thijs Louisse
2c38a919bc fix(core): make scoped-elements ssr-compatible 
fix(core): ssr-support scopedElements
 2024-10-31 10:48:51 +01:00
Thijs Louisse
615472cc0a feat(providence): oxc for main analyzers and traversal; parsers as peerDeps 2024-10-29 12:09:03 +01:00
Thijs Louisse
dbb964077f chore: update/clean devDependencies for better security and perf 2024-10-16 14:14:26 +02:00
John Clifford
4696ad72c9
feat(accordion): add exclusive option (#2372) 
* Added exclusive feature for accordion

* Changed position of exclusive accordion

* chore: accordion [exclusive] option

* chore: accordion [exclusive] option

* chore: fixes and cleanups

* chore: get docs of accordion back

---------

Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
Co-authored-by: gerjanvangeest <Gerjan.van.Geest@ing.com>
 2024-10-03 15:52:39 +02:00
Ardeshir Izadi
709cc5193a
chore: update "@custom-elements-manifest/analyzer" to 0.10.3 (#2346) 2024-08-26 09:28:32 +02:00
gerjanvangeest
8e450423da
chore: add api tables to all components (#2297) 
* chore: add api tables to all components

* chore: only use eleventyignore as ignore files for rocket
 2024-06-10 15:30:20 +02:00
Thijs Louisse
aea90ae036 chore(root): cleanup and update dependencies 2024-05-14 13:47:11 +02:00
Thijs Louisse
519cb9c91a fix: cleanup dependencies, code and deprecated cli commands (extend-docs, search, etc.) 2024-05-14 13:47:10 +02:00
Kristján Oddsson
c8093bd55b
Update eslint proper (#2254) 
* update eslint

* Fix ESLint violations

* just ignore the rules for now
 2024-04-23 10:31:22 +02:00
Kristján Oddsson
b872f9548a
Update typescript (#2256) 2024-04-23 10:28:26 +02:00
gerjanvangeest
4c69c7e34f
chore: update eslint-plugin-lit-a11y version (#2259) 2024-04-16 15:16:40 +02:00
Kristján Oddsson
11c518d14f
Update eslint plugins and configs (#2253) 
* Update all eslint configs and plugins

* Downgrade `eslint-plugin-lit-a11y`
 2024-04-16 09:51:20 +02:00
Oleksii Kadurin
ffa0bd5057
Merge pull request #2255 from ing-bank/fix/dropdown-tel 
fix: optimize the way we focus the input field for LionInputTelDropdown
 2024-04-16 08:59:39 +02:00
Kristján Oddsson
29104e800a
changeset is a dev dependencies (#2258) 2024-04-16 08:46:21 +02:00
okadurin
ac783460aa fix: optimize the way we focus the input field for LionInputTelDropdown 2024-04-15 11:18:37 +02:00
Kristján Oddsson
a393a9829c
Remove unused whatwg-fetch dependency (#2252) 2024-04-15 09:43:26 +02:00
gerjanvangeest
395595198c chore(ui): release 0.6.0 
chore: update beta release steps

chore: prepare release

chore: regenerate pkg-lock

chrore: try prev working pkg-lock
 2024-03-27 18:05:48 +01:00
gerjanvangeest
a847f99388 fix(textarea): fix box-sizing inside tests to make it work cross browser (#2210) 2024-03-27 18:02:16 +01:00
Oleksii Kadurin
00a7e39aae feat(ui): adopt @open-wc/scoped-elements mixin v3 
Co-authored-by: Thijs Louisse <Thijs.Louisse@ing.com>
 2024-03-27 18:02:15 +01:00
gerjanvangeest
8bd27555a8 chore: update to lit3 and other dependencies 
BREAKING CHANGE: update to latest major versions of lit, autosize, awesome-phonenumber & ibantools

- fix(validation-messages): get correct validation min and max dates in French (#2163)

- feat(ui): update to lit version 3 and update lion prod dependencies, and create an alpha release

---------

Co-authored-by: gerjanvangeest <gerjanvangeest@users.noreply.github.com>
 2024-03-27 18:00:34 +01:00
Riovir
e6b8dd144c
fix(ui): Fix multiple Lit versions - pin @open-wc/scoped-elements to 2.2.0 (#2224) (#2225) 
* fix(ui): pin @open-wc/scoped-elements to 2.2.3 (#2224)
 2024-03-20 09:05:12 +01:00
Thijs Louisse
5b64da8acc
fix: web-dev-server update (#2190) 2024-02-12 12:05:20 +01:00
Thijs Louisse
bdb038e197 chore: test/lint/swc fixes + changeset providence 2023-11-09 11:38:39 +01:00
Thijs Louisse
45fe0b4bb3 chore(ui): lint and types fixes 2023-11-08 19:08:54 +01:00
dependabot[bot]
c1d66f1e04 chore(deps): bump @babel/traverse from 7.20.1 to 7.23.2 
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.1 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-08 17:07:50 +01:00
alejandrofernandezcanton
b1320a9a9c
fix(overlay): avoid calling push in iterable object to avoid error loading overlays (#2088) 2023-10-17 14:44:51 +02:00
Konstantinos Norgias
7ee9191260 chore: a higher sharp version that can be built on Mac 2023-10-04 17:10:16 +02:00
Thijs Louisse
2034a1b52e chore: regenerate pkg-lock 2023-08-30 14:45:01 +02:00
dependabot[bot]
625ced5889 chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-08-30 14:03:32 +02:00
Kristján Oddsson
c2c9af5785 packge-lock.json changes 2023-08-30 13:46:21 +02:00
narzac
296463d0d9 feat: init nodejs-helpers package, add bypass-import-map, bypass-export-map, and run part of lion prepublish 2023-08-18 14:32:09 +02:00
Joren Broekema
9cdac8e947
fix: clone response when reading the response for error (#2049) 2023-08-01 10:45:27 +02:00
Joren Broekema
7a875ef1b4
feat: parsing body for failed ajax responses (#2039) 2023-07-18 13:44:22 +02:00
Víctor Lara
5eafa1ffc1
fix(overlays): add aria-hidden to arrow (#2030) 2023-07-10 08:18:08 +02:00
Danny Moerkerke
259e0dd468
Fix/remove file (#2018) 
* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: lion-selected-filelist, restored composed: true and bubbles: true for 'file-remove-requested' event, otherwise removing files for subclassers won't work

* fix: removed composed: true and bubbles: true and set eventlistener directly on lion-selected-file-list

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* Update packages/ui/components/input-file/src/LionInputFile.js

* fix: fixed test

* Update packages/ui/components/input-file/test/lion-input-file.test.js

* chore: format

* fix

---------

Co-authored-by: Thijs Louisse <thijs.louisse@ing.com>
 2023-06-20 17:32:05 +02:00
dependabot[bot]
ccc762d876 chore(deps): bump socket.io-parser from 4.2.1 to 4.2.4 
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.1 to 4.2.4.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.2.1...4.2.4)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-06-08 18:08:23 +02:00
Konstantinos Norgias
33c0ff13da chore: add changeset & docs on how to enable VS Code autocomplete 2023-06-08 17:54:19 +02:00
Thijs Louisse
d620dade55 feat: expose vscode custom-data 2023-06-08 17:22:58 +02:00
Gyulai Levente
bdc7455610
feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount (#1988) 
* feat(@lion/ui): add _currencyDisplayNodeSlot to LionInputAmount

* Remove test for feature what is not supported anymore
* Add documentation
* Add test for customizable currency slot
 2023-06-01 08:55:42 +02:00