ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(overlays): don't use hidesOnOutsideEsc in configs, as it disallows nested overlays (a11y concern)

Browse source
This commit is contained in:
Thijs Louisse 2025-07-29 15:13:37 +02:00 committed by Thijs Louisse
parent f19befe9c4
commit fb0813bc6d
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/gorgeous-chefs-fly.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': minor
---
[overlays]: don't use hidesOnOutsideEsc in configs, as it disallows nested overlays (a11y concern)

1
packages/ui/components/overlays/src/configurations/withDropdownConfig.js
View file

@ -9,7 +9,6 @@ export const withDropdownConfig = () =>
placementMode: 'local', placementMode: 'local',
inheritsReferenceWidth: 'min', inheritsReferenceWidth: 'min',
hidesOnOutsideClick: true, hidesOnOutsideClick: true,
hidesOnOutsideEsc: true,
hidesOnEsc: true, hidesOnEsc: true,
popperConfig: { popperConfig: {
placement: 'bottom-start', placement: 'bottom-start',

1
packages/ui/components/overlays/src/configurations/withTooltipConfig.js
View file

@ -18,7 +18,6 @@ export const withTooltipConfig = ({
placementMode: 'local', placementMode: 'local',
elementToFocusAfterHide: undefined, elementToFocusAfterHide: undefined,
hidesOnEsc: true, hidesOnEsc: true,
hidesOnOutsideEsc: true,
handlesAccessibility: true, handlesAccessibility: true,
isTooltip: true, isTooltip: true,
invokerRelation, invokerRelation,