ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1238 from ing-bank/fix/prev-validation-result

Browse source 
fix(form-core): prevValidationResult initialize as empty array
This commit is contained in:
Joren Broekema 2021-02-23 14:53:16 +01:00 committed by GitHub
commit ee85fa036e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/loud-planes-doubt.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/form-core': patch
---
Make sure prev validation result is always an array (of validators) and not undefined.

2
packages/form-core/src/validate/ResultValidator.js
View file

@ -10,7 +10,7 @@ export class ResultValidator extends Validator {
/** /**
* @param {Object} context * @param {Object} context
* @param {Validator[]} context.regularValidationResult * @param {Validator[]} context.regularValidationResult
* @param {Validator[] | undefined} context.prevValidationResult * @param {Validator[]} context.prevValidationResult
* @param {Validator[]} [context.validators] * @param {Validator[]} [context.validators]
* @returns {boolean} * @returns {boolean}
*/ */

2
packages/form-core/src/validate/ValidateMixin.js
View file

@ -161,6 +161,8 @@ export const ValidateMixinImplementation = superclass =>
* @type {Validator[]} * @type {Validator[]}
*/ */
this.__validationResult = []; this.__validationResult = [];
/** @type {Validator[]} */
this.__prevValidationResult = [];
this.__onValidatorUpdated = this.__onValidatorUpdated.bind(this); this.__onValidatorUpdated = this.__onValidatorUpdated.bind(this);
this._updateFeedbackComponent = this._updateFeedbackComponent.bind(this); this._updateFeedbackComponent = this._updateFeedbackComponent.bind(this);