Merge pull request #2031 from ing-bank/fix/empty-response

fix: avoid JSON.parsing empty responses

.changeset/chilly-bananas-talk.md

@@ -0,0 +1,5 @@
+---
+"@lion/ajax": patch
+---
+
+fix: avoid JSON.parsing empty responses

packages/ajax/src/Ajax.js

@@ -193,9 +193,11 @@ export class Ajax {
 
     /** @type {any} */
     let body = responseText;
+
     if (
-      !response.headers.get('content-type') ||
+      body.length &&
-      response.headers.get('content-type')?.includes('json')
+      (!response.headers.get('content-type') ||
+        response.headers.get('content-type')?.includes('json'))
     ) {
       try {
         body = JSON.parse(responseText);

packages/ajax/test/Ajax.test.js

@@ -221,6 +221,13 @@ describe('Ajax', () => {
       }
       expect(thrown).to.be.true;
     });
+
+    it('doesnt throw on empty response', async () => {
+      fetchStub.returns(Promise.resolve(new Response('', responseInit())));
+
+      const { response } = await ajax.fetchJson('/foo');
+      expect(response.ok);
+    });
   });
 
   describe('request and response interceptors', () => {