ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2031 from ing-bank/fix/empty-response

Browse source 
fix: avoid JSON.parsing empty responses
This commit is contained in:
Pascal Schilp 2023-07-06 12:02:43 +02:00 committed by GitHub
commit ecf63407ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/chilly-bananas-talk.md Normal file
View file

@ -0,0 +1,5 @@
---
"@lion/ajax": patch
---
fix: avoid JSON.parsing empty responses

6
packages/ajax/src/Ajax.js
View file

@ -193,9 +193,11 @@ export class Ajax {
/** @type {any} */
let body = responseText;
if (
!response.headers.get('content-type') ||
response.headers.get('content-type')?.includes('json')
body.length &&
(!response.headers.get('content-type') ||
response.headers.get('content-type')?.includes('json'))
) {
try {
body = JSON.parse(responseText);

7
packages/ajax/test/Ajax.test.js
View file

@ -221,6 +221,13 @@ describe('Ajax', () => {
}
expect(thrown).to.be.true;
});
it('doesnt throw on empty response', async () => {
fetchStub.returns(Promise.resolve(new Response('', responseInit())));
const { response } = await ajax.fetchJson('/foo');
expect(response.ok);
});
});
describe('request and response interceptors', () => {