From eb46728826b22e4c7b984f02ea272987bebeb7ea Mon Sep 17 00:00:00 2001 From: Thijs Louisse Date: Wed, 21 Feb 2024 17:25:02 +0100 Subject: [PATCH] fix: migrate deprecated `performUpdate` api to `scheduleUpdate` --- .changeset/fresh-moles-reflect.md | 5 +++++ .../test-suites/FormRegistrationMixins.suite.js | 14 +++++++------- .../ui/components/localize/src/LocalizeMixin.js | 4 ++-- 3 files changed, 14 insertions(+), 9 deletions(-) create mode 100644 .changeset/fresh-moles-reflect.md diff --git a/.changeset/fresh-moles-reflect.md b/.changeset/fresh-moles-reflect.md new file mode 100644 index 000000000..a69a5a121 --- /dev/null +++ b/.changeset/fresh-moles-reflect.md @@ -0,0 +1,5 @@ +--- +'@lion/ui': patch +--- + +migrate deprecated `performUpdate` api to `scheduleUpdate` diff --git a/packages/ui/components/form-core/test-suites/FormRegistrationMixins.suite.js b/packages/ui/components/form-core/test-suites/FormRegistrationMixins.suite.js index db74a8694..f87398391 100644 --- a/packages/ui/components/form-core/test-suites/FormRegistrationMixins.suite.js +++ b/packages/ui/components/form-core/test-suites/FormRegistrationMixins.suite.js @@ -163,20 +163,20 @@ export const runRegistrationSuite = customConfig => { }); it('works for components that have a delayed render', async () => { - class PerformUpdate extends FormRegistrarMixin(LitElement) { - async performUpdate() { + class ScheduleUpdate extends FormRegistrarMixin(LitElement) { + async scheduleUpdate() { // eslint-disable-next-line no-promise-executor-return await new Promise(resolve => setTimeout(() => resolve(undefined), 10)); - await super.performUpdate(); + await super.scheduleUpdate(); } render() { return html``; } } - const tagWrapperString = defineCE(PerformUpdate); + const tagWrapperString = defineCE(ScheduleUpdate); const tagWrapper = unsafeStatic(tagWrapperString); - const el = /** @type {PerformUpdate} */ ( + const el = /** @type {ScheduleUpdate} */ ( await fixture(html` <${tagWrapper}> <${childTag}> @@ -359,10 +359,10 @@ export const runRegistrationSuite = customConfig => { it('works for portals that have a delayed render', async () => { const delayedPortalString = defineCE( class extends FormRegistrarPortalMixin(LitElement) { - async performUpdate() { + async scheduleUpdate() { // eslint-disable-next-line no-promise-executor-return await new Promise(resolve => setTimeout(() => resolve(undefined), 10)); - await super.performUpdate(); + await super.scheduleUpdate(); } render() { diff --git a/packages/ui/components/localize/src/LocalizeMixin.js b/packages/ui/components/localize/src/LocalizeMixin.js index 240f3bba0..d8c886eb0 100644 --- a/packages/ui/components/localize/src/LocalizeMixin.js +++ b/packages/ui/components/localize/src/LocalizeMixin.js @@ -64,11 +64,11 @@ const LocalizeMixinImplementation = superclass => * hook into LitElement to only render once all translations are loaded * @returns {Promise.} */ - async performUpdate() { + async scheduleUpdate() { if (Object.getPrototypeOf(this).constructor.waitForLocalizeNamespaces) { await this.localizeNamespacesLoaded; } - super.performUpdate(); + super.scheduleUpdate(); } connectedCallback() {