From de0e0d52b5a35800a84e3bf93b466ed6eef1339e Mon Sep 17 00:00:00 2001
From: Thomas Allmer <thomas.allmer@ing.com>
Date: Tue, 15 Sep 2020 10:43:28 +0200
Subject: [PATCH] chore: remove not needed index.d.ts files, minor type
 improvements

---
 packages/form-core/index.d.ts                 | 52 -------------------
 packages/input-amount/index.d.ts              |  3 --
 packages/input-amount/src/parsers.js          |  2 +-
 packages/input/index.d.ts                     |  1 -
 .../src/number/getDecimalSeparator.js         |  2 +-
 packages/localize/src/number/getLocale.js     |  2 +-
 packages/tabs/index.d.ts                      |  1 -
 7 files changed, 3 insertions(+), 60 deletions(-)
 delete mode 100644 packages/form-core/index.d.ts
 delete mode 100644 packages/input-amount/index.d.ts
 delete mode 100644 packages/input/index.d.ts
 delete mode 100644 packages/tabs/index.d.ts

diff --git a/packages/form-core/index.d.ts b/packages/form-core/index.d.ts
deleted file mode 100644
index fc1db61f0..000000000
--- a/packages/form-core/index.d.ts
+++ /dev/null
@@ -1,52 +0,0 @@
-export { FocusMixin } from './src/FocusMixin.js';
-export { FormatMixin } from './src/FormatMixin.js';
-export { FormControlMixin } from './src/FormControlMixin.js';
-export { InteractionStateMixin } from './src/InteractionStateMixin.js'; // applies FocusMixin
-export { LionField } from './src/LionField.js';
-export { FormRegisteringMixin } from './src/registration/FormRegisteringMixin.js';
-export { FormRegistrarMixin } from './src/registration/FormRegistrarMixin.js';
-export { FormRegistrarPortalMixin } from './src/registration/FormRegistrarPortalMixin.js';
-export { FormControlsCollection } from './src/registration/FormControlsCollection.js';
-
-// validate
-
-export { ValidateMixin } from './src/validate/ValidateMixin.js';
-export { Unparseable } from './src/validate/Unparseable.js';
-export { Validator } from './src/validate/Validator.js';
-export { ResultValidator } from './src/validate/ResultValidator.js';
-
-export { Required } from './src/validate/validators/Required.js';
-
-export {
-  IsString,
-  EqualsLength,
-  MinLength,
-  MaxLength,
-  MinMaxLength,
-  IsEmail,
-  Pattern,
-} from './src/validate/validators/StringValidators.js';
-
-export {
-  IsNumber,
-  MinNumber,
-  MaxNumber,
-  MinMaxNumber,
-} from './src/validate/validators/NumberValidators.js';
-
-export {
-  IsDate,
-  MinDate,
-  MaxDate,
-  MinMaxDate,
-  IsDateDisabled,
-} from './src/validate/validators/DateValidators.js';
-
-export { DefaultSuccess } from './src/validate/resultValidators/DefaultSuccess.js';
-
-export { LionValidationFeedback } from './src/validate/LionValidationFeedback.js';
-
-export { ChoiceGroupMixin } from './src/choice-group/ChoiceGroupMixin.js';
-export { ChoiceInputMixin } from './src/choice-group/ChoiceInputMixin.js';
-
-export { FormGroupMixin } from './src/form-group/FormGroupMixin.js';
diff --git a/packages/input-amount/index.d.ts b/packages/input-amount/index.d.ts
deleted file mode 100644
index 301152b45..000000000
--- a/packages/input-amount/index.d.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-export { LionInputAmount } from './src/LionInputAmount.js';
-export { formatAmount } from './src/formatters.js';
-export { parseAmount } from './src/parsers.js';
diff --git a/packages/input-amount/src/parsers.js b/packages/input-amount/src/parsers.js
index f04e1bb23..35f0ee8ec 100644
--- a/packages/input-amount/src/parsers.js
+++ b/packages/input-amount/src/parsers.js
@@ -68,7 +68,7 @@ function getParseMode(value, { mode = 'auto' } = {}) {
  * @param {string} [options.locale]
  */
 function parseWithLocale(value, options) {
-  const locale = options && options.locale ? options.locale : null;
+  const locale = options && options.locale ? options.locale : undefined;
   const separator = getDecimalSeparator(locale);
   const regexNumberAndLocaleSeparator = new RegExp(`[0-9${separator}-]`, 'g');
   let numberAndLocaleSeparator = value.match(regexNumberAndLocaleSeparator)?.join('');
diff --git a/packages/input/index.d.ts b/packages/input/index.d.ts
deleted file mode 100644
index 9779cad06..000000000
--- a/packages/input/index.d.ts
+++ /dev/null
@@ -1 +0,0 @@
-export { LionInput } from './src/LionInput.js';
diff --git a/packages/localize/src/number/getDecimalSeparator.js b/packages/localize/src/number/getDecimalSeparator.js
index aa593aa04..5df3b68eb 100644
--- a/packages/localize/src/number/getDecimalSeparator.js
+++ b/packages/localize/src/number/getDecimalSeparator.js
@@ -3,7 +3,7 @@ import { getLocale } from './getLocale.js';
 /**
  * To get the decimal separator
  *
- * @param {string|null} locale To override the browser locale
+ * @param {string} [locale] To override the browser locale
  * @returns {string} The separator
  */
 export function getDecimalSeparator(locale) {
diff --git a/packages/localize/src/number/getLocale.js b/packages/localize/src/number/getLocale.js
index 73f0b1542..0725d2f8d 100644
--- a/packages/localize/src/number/getLocale.js
+++ b/packages/localize/src/number/getLocale.js
@@ -3,7 +3,7 @@ import { localize } from '../localize.js';
 /**
  * Gets the locale to use
  *
- * @param {string|null} [locale] Locale to override browser locale
+ * @param {string} [locale] Locale to override browser locale
  * @returns {string}
  */
 export function getLocale(locale) {
diff --git a/packages/tabs/index.d.ts b/packages/tabs/index.d.ts
deleted file mode 100644
index 96d683b2d..000000000
--- a/packages/tabs/index.d.ts
+++ /dev/null
@@ -1 +0,0 @@
-export { LionTabs } from "./src/LionTabs.js";