ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tabs): set selectedIndex only if differ from previous selectedIndex

Browse source
This commit is contained in:
Gyulai Levente 2023-12-01 09:57:19 +01:00 committed by GitHub
parent c3f7555c73
commit db96e8cc07
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/small-pumpkins-peel.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': patch
---
fix(tabs): set selectedIndex only if value differ from previous value

4
packages/ui/components/tabs/src/LionTabs.js
View file

@ -356,7 +356,11 @@ export class LionTabs extends LitElement {
* @param {number} value The new index
*/
set selectedIndex(value) {
if (value === this.__selectedIndex) {
return;
}
const stale = this.__selectedIndex;
/** @type {number | undefined} */
this.__selectedIndex = value;
this.__updateSelected(false);
this.dispatchEvent(new Event('selected-changed'));

8
packages/ui/components/tabs/test/lion-tabs.test.js
View file

@ -75,6 +75,14 @@ describe('<lion-tabs>', () => {
expect(spy).to.have.been.calledOnce;
});
it('does not send event "selected-changed" after selecting currently selected tab', async () => {
const el = /** @type {LionTabs} */ (await fixture(basicTabs));
const spy = sinon.spy();
el.addEventListener('selected-changed', spy);
el.selectedIndex = 0;
expect(spy).not.to.have.been.called;
});
it('logs warning if unequal amount of tabs and panels', async () => {
const stub = sinon.stub(console, 'warn');
await fixture(html`