From d764bba6445058511edc24d82ff9e100c3bd5094 Mon Sep 17 00:00:00 2001 From: qa46hx Date: Thu, 11 Jun 2020 12:52:15 +0200 Subject: [PATCH] chore(core): small fixes in docs --- packages/core/docs/guidelines/30-guidelines-scoped-elements.md | 2 +- packages/core/docs/rationales/001-side-effects.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/docs/guidelines/30-guidelines-scoped-elements.md b/packages/core/docs/guidelines/30-guidelines-scoped-elements.md index 74f616ed7..e61fabae8 100644 --- a/packages/core/docs/guidelines/30-guidelines-scoped-elements.md +++ b/packages/core/docs/guidelines/30-guidelines-scoped-elements.md @@ -6,7 +6,7 @@ export default { }; ``` -The [CustomElementRegistry](https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry) provides methods for registering custom elements. One of the limitations of working with this global registry is that multiple versions of the same element cannot co-exist. This causes bottlenecks in software delivery that should be managed by the teams and complex build systems. [Scoped Custom Element Registries](https://github.com/w3c/webcomponents/issues/716) is a proposal that will solve the problem. Since this functionality won't be available (especially not cross browser) anytime soon, we've adopted [OpenWC's Scoped Elements](https://open-wc.org/scoped-element). +The [CustomElementRegistry](https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry) provides methods for registering custom elements. One of the limitations of working with this global registry is that multiple versions of the same element cannot co-exist. This causes bottlenecks in software delivery that should be managed by the teams and complex build systems. [Scoped Custom Element Registries](https://github.com/w3c/webcomponents/issues/716) is a proposal that will solve the problem. Since this functionality won't be available (especially not cross browser) anytime soon, we've adopted [OpenWC's Scoped Elements](https://open-wc.org/scoped-elements/). Whenever a lion component uses composition (meaning it uses another lion component inside), we apply ScopedElementsMixin to make sure it uses the right version of this internal component. diff --git a/packages/core/docs/rationales/001-side-effects.md b/packages/core/docs/rationales/001-side-effects.md index be313baa2..9ab7f12d6 100644 --- a/packages/core/docs/rationales/001-side-effects.md +++ b/packages/core/docs/rationales/001-side-effects.md @@ -1,4 +1,4 @@ -# 001 Side Effects +# Side Effects All our packages are side effect free due to the fact that es modules are always side effect free even when changing other es modules. Only code which accesses browser globals like `window`, `console` in the root of the module will be treated a side effect and always included. Everything else can be tree shaken by [rollup](https://rollupjs.org).