ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1524 from Alex-Radu/fix/overlay-is-equal-config

Browse source 
fix(overlays): fix condition in is-equal-config util and add null guard
This commit is contained in:
Thijs Louisse 2021-11-10 11:16:27 +01:00 committed by GitHub
commit cf3b14bce0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/sour-rules-rush.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/overlays': patch
---
fix condition in is-equal-config util and add null guard

2
packages/overlays/src/utils/is-equal-config.js
View file

@ -11,7 +11,7 @@
* @returns {boolean} Whether the configs are equivalent
*/
export function isEqualConfig(a, b) {
if (typeof a !== 'object' || typeof a !== 'object') {
if (typeof a !== 'object' || typeof b !== 'object' || a === null || b === null) {
return a === b;
}
const aProps = Object.keys(a);

12
packages/overlays/test/utils-tests/is-equal-config.test.js
View file

@ -23,6 +23,18 @@ describe('isEqualConfig()', () => {
expect(isEqualConfig(config, config)).eql(true);
});
it('compares null props', () => {
const config = TestConfig();
const nullPropConfig = {
...config,
elementToFocusAfterHide: {
nullProp: null,
},
};
// @ts-ignore
expect(isEqualConfig(nullPropConfig, nullPropConfig)).eql(true);
});
it('compares shallow props', () => {
const config = TestConfig();
expect(isEqualConfig(config, { ...config })).eql(true);