ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(lion-accordion): make a copy when changing expanded (#2047)

Browse source
This commit is contained in:
Sciurus7 2023-09-11 14:55:30 +02:00 committed by GitHub
parent 857d47a933
commit cecf5ed573
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/sixty-cycles-dance.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': patch
---
lion-accordion now replaces expanded with a copy when it changes on click of an invoker button.

2
packages/ui/components/accordion/src/LionAccordion.js
View file

@ -441,7 +441,7 @@ export class LionAccordion extends LitElement {
* @private * @private
*/ */
__toggleExpanded(value) { __toggleExpanded(value) {
const { expanded } = this; const expanded = [...this.expanded];
const index = expanded.indexOf(value); const index = expanded.indexOf(value);
if (index === -1) { if (index === -1) {

8
packages/ui/components/accordion/test/lion-accordion.test.js
View file

@ -80,6 +80,14 @@ describe('<lion-accordion>', () => {
).to.equal('invoker 1'); ).to.equal('invoker 1');
}); });
it('updates expanded with a new array when an invoker is clicked', async () => {
const el = /** @type {LionAccordion} */ (await fixture(basicAccordion));
const invokers = getInvokers(el);
const oldExpanded = el.expanded;
invokers[1].firstElementChild?.dispatchEvent(new Event('click'));
expect(el.expanded).to.not.equal(oldExpanded);
});
it('has [expanded] on current expanded invoker which serves as styling hook', async () => { it('has [expanded] on current expanded invoker which serves as styling hook', async () => {
const el = /** @type {LionAccordion} */ (await fixture(basicAccordion)); const el = /** @type {LionAccordion} */ (await fixture(basicAccordion));
const invokers = getInvokers(el); const invokers = getInvokers(el);