ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(overlays): hideOnEsc should also work while being on the invoker

Browse source
This commit is contained in:
Thomas Allmer 2019-11-29 18:24:22 +01:00
parent 2853444de7
commit c899cf26d2
3 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/input-datepicker/src/LionInputDatepicker.js
View file

@ -262,6 +262,7 @@ export class LionInputDatepicker extends OverlayMixin(LionInputDate) {
_defineOverlayConfig() { _defineOverlayConfig() {
return { return {
...withModalDialogConfig(), ...withModalDialogConfig(),
hidesOnOutsideClick: true,
}; };
} }

2
packages/overlays/src/OverlayController.js
View file

@ -483,8 +483,10 @@ export class OverlayController {
if (phase === 'show') { if (phase === 'show') {
this.__escKeyHandler = ev => ev.key === 'Escape' && this.hide(); this.__escKeyHandler = ev => ev.key === 'Escape' && this.hide();
this.contentNode.addEventListener('keyup', this.__escKeyHandler); this.contentNode.addEventListener('keyup', this.__escKeyHandler);
this.invokerNode.addEventListener('keyup', this.__escKeyHandler);
} else if (phase === 'hide') { } else if (phase === 'hide') {
this.contentNode.removeEventListener('keyup', this.__escKeyHandler); this.contentNode.removeEventListener('keyup', this.__escKeyHandler);
this.invokerNode.removeEventListener('keyup', this.__escKeyHandler);
} }
} }

1
packages/tooltip/src/LionTooltip.js
View file

@ -14,6 +14,7 @@ export class LionTooltip extends OverlayMixin(LitElement) {
return { return {
placementMode: 'local', // have to set a default placementMode: 'local', // have to set a default
elementToFocusAfterHide: null, elementToFocusAfterHide: null,
hidesOnEsc: true,
}; };
} }