ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(fieldset): wait for registration before setting values

Browse source
This commit is contained in:
Lars den Bakker 2019-11-27 16:58:59 +01:00
parent 8db04b8bab
commit c378b1885f
2 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/fieldset/src/LionFieldset.js
View file

@ -266,7 +266,11 @@ export class LionFieldset extends FormRegistrarMixin(
});
}
_setValueMapForAllFormElements(property, values) {
async _setValueMapForAllFormElements(property, values) {
if (!this.__readyForRegistration) {
await this.registrationReady;
}
if (values && typeof values === 'object') {
Object.keys(values).forEach(name => {
if (Array.isArray(this.formElements[name])) {

30
packages/fieldset/test/lion-fieldset.test.js
View file

@ -248,6 +248,36 @@ describe('<lion-fieldset>', () => {
expect(el.formElements.sub.formElements['hobbies[]'][1].disabled).to.be.true;
});
it('can set initial modelValue on creation', async () => {
const initialModelValue = {
lastName: 'Bar',
};
const el = await fixture(html`
<${tag} .modelValue=${initialModelValue}>
<${childTag} name="lastName"></${childTag}>
</${tag}>
`);
await el.registrationReady;
await el.updateComplete;
expect(el.modelValue).to.eql(initialModelValue);
});
it('can set initial serializedValue on creation', async () => {
const initialSerializedValue = {
lastName: 'Bar',
};
const el = await fixture(html`
<${tag} .modelValue=${initialSerializedValue}>
<${childTag} name="lastName"></${childTag}>
</${tag}>
`);
await el.registrationReady;
await el.updateComplete;
expect(el.modelValue).to.eql(initialSerializedValue);
});
describe('validation', () => {
it('validates on init', async () => {
class IsCat extends Validator {