ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #532 from ing-bank/fix/unusedDependencies

Browse source 
fix: remove unused (dev)dependency on lion-button
This commit is contained in:
Thomas Allmer 2020-01-30 15:41:44 +01:00 committed by GitHub
commit bba195cb1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/calendar/package.json
View file

@ -37,7 +37,6 @@
"@lion/localize": "0.8.4"
},
"devDependencies": {
"@lion/button": "0.5.3",
"@open-wc/demoing-storybook": "^1.8.3",
"@open-wc/testing": "^2.5.0",
"sinon": "^7.2.2"

1
packages/input-datepicker/package.json
View file

@ -45,7 +45,6 @@
"@lion/validate": "0.6.4"
},
"devDependencies": {
"@lion/button": "0.5.3",
"@open-wc/demoing-storybook": "^1.8.3",
"@open-wc/testing": "^2.5.0",
"sinon": "^7.2.2"

1
packages/switch/package.json
View file

@ -32,7 +32,6 @@
"*.js"
],
"dependencies": {
"@lion/button": "0.5.3",
"@lion/choice-input": "0.5.4",
"@lion/core": "0.4.2",
"@lion/field": "0.8.4"

7
packages/tooltip/test/lion-tooltip-arrow.test.js
View file

@ -1,5 +1,4 @@
import { expect, fixture, html } from '@open-wc/testing';
import '../../button/lion-button.js';
import '../lion-tooltip-arrow.js';
import '../lion-tooltip.js';
@ -7,7 +6,7 @@ describe('lion-tooltip-arrow', () => {
it('has a visual "arrow" element inside the content node', async () => {
const el = await fixture(html`
<lion-tooltip opened>
<lion-button slot="invoker">Tooltip button</lion-button>
<button slot="invoker">Tooltip button</button>
<div slot="content">Hey there</div>
<lion-tooltip-arrow slot="arrow"></lion-tooltip-arrow>
</lion-tooltip>
@ -21,7 +20,7 @@ describe('lion-tooltip-arrow', () => {
it('reflects popper placement in its own placement property and attribute', async () => {
const el = await fixture(html`
<lion-tooltip .config=${{ popperConfig: { placement: 'right' } }}>
<lion-button slot="invoker">Tooltip button</lion-button>
<button slot="invoker">Tooltip button</button>
<div slot="content">Hey there</div>
<lion-tooltip-arrow slot="arrow"></lion-tooltip-arrow>
</lion-tooltip>
@ -55,7 +54,7 @@ describe('lion-tooltip-arrow', () => {
<div slot="content" style="height: 30px; background-color: red;">
Hey there
</div>
<lion-button slot="invoker">Tooltip button</lion-button>
<button slot="invoker" style="height: 30px;">Tooltip button</button>
<lion-tooltip-arrow slot="arrow"></lion-tooltip-arrow>
</lion-tooltip>
`);

4
packages/tooltip/test/lion-tooltip.test.js
View file

@ -159,7 +159,7 @@ describe('lion-tooltip', () => {
const el = await fixture(html`
<lion-tooltip>
<div slot="content">Hey there</div>
<lion-button slot="invoker">Tooltip button</lion-button>
<button slot="invoker">Tooltip button</button>
</lion-tooltip>
`);
await expect(el).to.be.accessible;
@ -169,7 +169,7 @@ describe('lion-tooltip', () => {
const el = await fixture(html`
<lion-tooltip>
<div slot="content">Hey there</div>
<lion-button slot="invoker">Tooltip button</lion-button>
<button slot="invoker">Tooltip button</button>
</lion-tooltip>
`);
const invoker = el.querySelector('[slot="invoker"]');

25
yarn.lock
View file

@ -2397,11 +2397,6 @@
resolved "https://registry.yarnpkg.com/@open-wc/semantic-dom-diff/-/semantic-dom-diff-0.13.21.tgz#718b9ec5f9a98935fc775e577ad094ae8d8b7dea"
integrity sha512-BONpjHcGX2zFa9mfnwBCLEmlDsOHzT+j6Qt1yfK3MzFXFtAykfzFjAgaxPetu0YbBlCfXuMlfxI4vlRGCGMvFg==
"@open-wc/semantic-dom-diff@^0.15.4":
version "0.15.4"
resolved "https://registry.yarnpkg.com/@open-wc/semantic-dom-diff/-/semantic-dom-diff-0.15.4.tgz#1bbf9adbbf3cb6090f525fc7d4274d17cc016457"
integrity sha512-Wa50FJiB26/jC++snNqOJBr3cYrzUdsFFNLL3HSA7PAscCWEGo5NAdesL/BnehXOCRyMZfpvv+uY9+F8dc7HCQ==
"@open-wc/semantic-dom-diff@^0.15.5":
version "0.15.5"
resolved "https://registry.yarnpkg.com/@open-wc/semantic-dom-diff/-/semantic-dom-diff-0.15.5.tgz#5530a45eea1982706abf72c702828df0e0a61739"
@ -2412,7 +2407,7 @@
resolved "https://registry.yarnpkg.com/@open-wc/storybook-prebuilt/-/storybook-prebuilt-0.4.0.tgz#a8ac47d86e50559ddf17f217df2504a098cd85b8"
integrity sha512-39Kfm3bsHPZioWIvQBuc05EvFakvqotVloe2lq0JPXD0iWxOWvWb4h8UKSvFdJY9RAv1p06OFhyEjpuhrZB9Jw==
"@open-wc/testing-helpers@^1.0.0", "@open-wc/testing-helpers@^1.4.0":
"@open-wc/testing-helpers@^1.0.0":
version "1.4.0"
resolved "https://registry.yarnpkg.com/@open-wc/testing-helpers/-/testing-helpers-1.4.0.tgz#d93b627c1311a1ad2b5fc4de43fc6f9fa8a79177"
integrity sha512-XTR0HGOSBEJz7H31FDhHD2R6GHXI6DksiJsYDzJdLXqF/ORkKFzfu1BXGVOnPZytmJZLvnEr7VmE2YfV0y2Yug==
@ -2456,24 +2451,6 @@
wallaby-webpack "^3.0.0"
webpack "^4.28.0"
"@open-wc/testing@^2.3.4":
version "2.4.2"
resolved "https://registry.yarnpkg.com/@open-wc/testing/-/testing-2.4.2.tgz#b4ae4682b2435167290f04061000251be85c59b0"
integrity sha512-VvTXlwQx3CTasCFuJQCse7JqJzDgkEFoo/6mlKzIwrzA/GJmX7Qko0aLJY7jaxnrotHyN9/njexTUPlOaW2z2g==
dependencies:
"@open-wc/chai-dom-equals" "^0.12.36"
"@open-wc/semantic-dom-diff" "^0.15.4"
"@open-wc/testing-helpers" "^1.4.0"
"@types/chai" "^4.1.7"
"@types/chai-dom" "^0.0.8"
"@types/mocha" "^5.0.0"
"@types/sinon-chai" "^3.2.3"
chai "^4.2.0"
chai-a11y-axe "^1.2.2"
chai-dom "^1.8.1"
mocha "^6.2.2"
sinon-chai "^3.3.0"
"@open-wc/testing@^2.5.0":
version "2.5.0"
resolved "https://registry.yarnpkg.com/@open-wc/testing/-/testing-2.5.0.tgz#b9f0dce6fd0f9aa55ef2383cf6875801cf988191"