Merge pull request #1123 from ing-bank/ci/node-windows
chore: update verify workflow to run node tests on windows
This commit is contained in:
commit
ba3a0dffa8
3 changed files with 8 additions and 2 deletions
5
.changeset/spicy-terms-grin.md
Normal file
5
.changeset/spicy-terms-grin.md
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
---
|
||||
'providence-analytics': patch
|
||||
---
|
||||
|
||||
Relative source path util take posix path for both full path and root path, to ensure the replace happens properly.
|
||||
3
.github/workflows/verify.yml
vendored
3
.github/workflows/verify.yml
vendored
|
|
@ -68,10 +68,11 @@ jobs:
|
|||
|
||||
node-tests:
|
||||
name: Node tests
|
||||
runs-on: ubuntu-latest
|
||||
runs-on: ${{ matrix.os }}
|
||||
strategy:
|
||||
matrix:
|
||||
node-version: [12.x, 14.x]
|
||||
os: [ubuntu-latest, windows-latest]
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
|
||||
|
|
|
|||
|
|
@ -20,7 +20,7 @@ function isRelativeSourcePath(source) {
|
|||
* @param {string} rootPath like '/path/to/repo'
|
||||
*/
|
||||
function toRelativeSourcePath(fullPath, rootPath) {
|
||||
return toPosixPath(fullPath).replace(rootPath, '.');
|
||||
return toPosixPath(fullPath).replace(toPosixPath(rootPath), '.');
|
||||
}
|
||||
|
||||
module.exports = { isRelativeSourcePath, toRelativeSourcePath };
|
||||
|
|
|
|||
Loading…
Reference in a new issue