ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1487 from ing-bank/fix/buttonSideEffects

Browse source 
fix(button): register element registration side effects
This commit is contained in:
Thijs Louisse 2021-08-20 11:10:40 +02:00 committed by GitHub
commit b9d1df2ace
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/thirty-dryers-listen.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/button': patch
---
Add files that result in customElements.define to sideEffect so build tools don't tree shake them

5
packages/button/package.json
View file

@ -33,7 +33,10 @@
"test": "cd ../../ && npm run test:browser -- --group button" "test": "cd ../../ && npm run test:browser -- --group button"
}, },
"sideEffects": [ "sideEffects": [
"lion-button.js" "lion-button.js",
"lion-button-reset.js",
"lion-button-submit.js",
"define.js"
], ],
"dependencies": { "dependencies": {
"@lion/core": "0.18.2" "@lion/core": "0.18.2"