From b96dc40ebeec0f57ff4c830e5276e56dc5355d20 Mon Sep 17 00:00:00 2001
From: jorenbroekema <joren.broekema@gmail.com>
Date: Mon, 21 Feb 2022 10:30:00 +0100
Subject: [PATCH] BREAKING(overlays): make elevation prop setter param type
 number instead of string

---
 .changeset/odd-suns-shake.md               | 5 +++++
 packages/overlays/src/OverlayController.js | 6 +++---
 packages/overlays/src/OverlaysManager.js   | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/odd-suns-shake.md

diff --git a/.changeset/odd-suns-shake.md b/.changeset/odd-suns-shake.md
new file mode 100644
index 000000000..610669fdf
--- /dev/null
+++ b/.changeset/odd-suns-shake.md
@@ -0,0 +1,5 @@
+---
+'@lion/overlays': minor
+---
+
+BREAKING: elevation property setter on OverlayController accepts numbers only, previously this was a number as a string. This syncs it with the getter which returns a number.
diff --git a/packages/overlays/src/OverlayController.js b/packages/overlays/src/OverlayController.js
index e8b83902f..7e0f54eaa 100644
--- a/packages/overlays/src/OverlayController.js
+++ b/packages/overlays/src/OverlayController.js
@@ -416,14 +416,14 @@ export class OverlayController extends EventTargetShim {
   }
 
   /**
-   * @param {string} value
+   * @param {number} value
    */
   set elevation(value) {
     if (this.contentWrapperNode) {
-      this.contentWrapperNode.style.zIndex = value;
+      this.contentWrapperNode.style.zIndex = `${value}`;
     }
     if (this.backdropNode) {
-      this.backdropNode.style.zIndex = value;
+      this.backdropNode.style.zIndex = `${value}`;
     }
   }
 
diff --git a/packages/overlays/src/OverlaysManager.js b/packages/overlays/src/OverlaysManager.js
index 812bf6c88..5409e0281 100644
--- a/packages/overlays/src/OverlaysManager.js
+++ b/packages/overlays/src/OverlaysManager.js
@@ -113,7 +113,7 @@ export class OverlaysManager {
       .reverse()
       .forEach((ctrl, i) => {
         // eslint-disable-next-line no-param-reassign
-        ctrl.elevation = `${i + 1}`;
+        ctrl.elevation = i + 1;
       });
   }