From b21c4fa8819b361f89c4c4d277b968dde79ca057 Mon Sep 17 00:00:00 2001 From: Thomas Allmer Date: Thu, 1 Oct 2020 13:16:57 +0200 Subject: [PATCH] chore: use discussions for feature requests --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- .github/ISSUE_TEMPLATE/feature_request.md | 14 ++------------ CONTRIBUTING.md | 2 +- README.md | 8 ++++++++ 4 files changed, 12 insertions(+), 14 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 3387a1d3c..dff87c772 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -16,7 +16,7 @@ Describe what happens instead. Best via a live code reproduction. To create one click the link below and edit away. Once the error is reproduced fork/safe and link it. -https://webcomponents.dev/edit/kpZmz1CJN580OaXsk56f?sv=1&pm=1 +https://webcomponents.dev/edit/kpZmz1CJN580OaXsk56f?pm=1 ## Additional context diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 78e79865f..d7c820095 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -1,19 +1,9 @@ --- name: Feature Request about: You have an idea about an additional feature -title: '[Feature Request] ...' +title: '[Feature Request] please use the discussions tab' labels: '' assignees: '' --- -## Idea - -By adding `my-flag` we can solve ... - -## Straw Man Proposal - -The api could look like this - -```js - -``` +Please use [discussions](https://github.com/ing-bank/lion/discussions/new) for new feature requests. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5771326ce..5dc63b49d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ Check out ways to contribute to Lion Web Components: ## Feature requests -When you have an idea on how we could improve, please check our [closed issues](https://github.com/ing-bank/lion/issues?q=is%3Aissue+is%3Aclosed+label%3Aenhancement) to see if there are similar ideas. If there are none, please [submit](https://github.com/ing-bank/lion/issues/new/choose) your feature request as an issue. Add a clear description of what you expect from the improvement and what the use case is. The issue will be closed and the community can add 👍 reactions to [vote and show interest](https://github.com/ing-bank/lion/issues?q=label%3A%22votes+needed%22+sort%3Areactions-%2B1-desc). When the feature gets picked up, the issue can be reopened. +When you have an idea on how we could improve, please check our [discussions](https://github.com/ing-bank/lion/discussions) to see if there are similar ideas or feature requests. If there are none, please [start](https://github.com/ing-bank/lion/discussions/new) your feature request as a new discussion topic. Add the title `[Feature Request] My awesome feature` and a description of what you expect from the improvement and what the use case is. ## Existing components: we love pull requests ♥ diff --git a/README.md b/README.md index f89509d99..429e8ebc0 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,14 @@ Additionally imports like `import '@lion/form/lion-form.js'` need to be transfor > Note: These demos may look a little bland but that is on purpose. They only come with functional stylings. > This makes sense as the main use case is to extend those components and if you do you do not want to override existing stylings. +## Issues + +If you encouter an issue with any of the packages we are offering please open a [new bug issue](https://github.com/ing-bank/lion/issues/new?assignees=&labels=&template=bug_report.md&title=). Be sure to include a description of the expected and the current behavior - additional adding a [reproduction](https://webcomponents.dev/edit/kpZmz1CJN580OaXsk56f?pm=1) always helps. + +## Feature requests + +When you have an idea on how we could improve, please check our [discussions](https://github.com/ing-bank/lion/discussions) to see if there are similar ideas or feature requests. If there are none, please [start](https://github.com/ing-bank/lion/discussions/new) your feature request as a new discussion topic. Add the title `[Feature Request] My awesome feature` and a description of what you expect from the improvement and what the use case is. + ## Content Lion web components is logically organized in groups of systems.