From b1320a9a9ce82e107d3be0ad7510a8e014fdfba0 Mon Sep 17 00:00:00 2001 From: alejandrofernandezcanton Date: Tue, 17 Oct 2023 14:44:51 +0200 Subject: [PATCH] fix(overlay): avoid calling push in iterable object to avoid error loading overlays (#2088) --- .changeset/forty-cats-unite.md | 5 +++++ package-lock.json | 4 ++-- packages/ui/components/overlays/src/utils/adopt-styles.js | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/forty-cats-unite.md diff --git a/.changeset/forty-cats-unite.md b/.changeset/forty-cats-unite.md new file mode 100644 index 000000000..e6878f650 --- /dev/null +++ b/.changeset/forty-cats-unite.md @@ -0,0 +1,5 @@ +--- +'@lion/ui': patch +--- + +avoid calling push in iterable object to avoid error loading overlays in old chromium versions diff --git a/package-lock.json b/package-lock.json index a274ff82a..5cc2717fb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -22698,7 +22698,7 @@ }, "packages/ajax": { "name": "@lion/ajax", - "version": "1.2.1", + "version": "1.2.3", "license": "MIT" }, "packages/singleton-manager": { @@ -22707,7 +22707,7 @@ }, "packages/ui": { "name": "@lion/ui", - "version": "0.4.0-prerelease-bypass-export-map.0", + "version": "0.4.1", "license": "MIT", "dependencies": { "@bundled-es-modules/message-format": "^6.0.4", diff --git a/packages/ui/components/overlays/src/utils/adopt-styles.js b/packages/ui/components/overlays/src/utils/adopt-styles.js index bf151ebb5..20644d9a8 100644 --- a/packages/ui/components/overlays/src/utils/adopt-styles.js +++ b/packages/ui/components/overlays/src/utils/adopt-styles.js @@ -119,7 +119,7 @@ export function adoptStyle(renderRoot, style, { teardown = false } = {}) { if (!teardown) { // @ts-ignore // eslint-disable-next-line no-param-reassign - renderRoot.adoptedStyleSheets.push(sheet); + renderRoot.adoptedStyleSheets = [...renderRoot.adoptedStyleSheets, sheet]; } else if (renderRoot.adoptedStyleSheets.includes(sheet)) { renderRoot.adoptedStyleSheets.splice(renderRoot.adoptedStyleSheets.indexOf(sheet), 1); }