diff --git a/packages/select-rich/src/LionSelectInvoker.js b/packages/select-rich/src/LionSelectInvoker.js index 40f9d1243..2a4bb80dc 100644 --- a/packages/select-rich/src/LionSelectInvoker.js +++ b/packages/select-rich/src/LionSelectInvoker.js @@ -42,13 +42,6 @@ export class LionSelectInvoker extends LionButton { this.type = 'button'; } - _requestUpdate(name, oldValue) { - super._requestUpdate(name, oldValue); - if (name === 'readOnly') { - this.disabled = this.readOnly; - } - } - _contentTemplate() { if (this.selectedElement) { const labelNodes = Array.from(this.selectedElement.querySelectorAll('*')); diff --git a/packages/select-rich/test/lion-select-invoker.test.js b/packages/select-rich/test/lion-select-invoker.test.js index a9a9b50b2..fdec095ac 100644 --- a/packages/select-rich/test/lion-select-invoker.test.js +++ b/packages/select-rich/test/lion-select-invoker.test.js @@ -48,13 +48,6 @@ describe('lion-select-invoker', () => { expect(el.getAttribute('tabindex')).to.equal('0'); }); - it('delegates the readonly attribute to disabled', async () => { - const el = await fixture(html` - - `); - expect(el.hasAttribute('disabled')).to.be.true; - }); - describe('Subclassers', () => { it('supports a custom _contentTemplate', async () => { const myTag = defineCE( diff --git a/packages/select-rich/test/lion-select-rich.test.js b/packages/select-rich/test/lion-select-rich.test.js index d780e4e08..55ee4fcaf 100644 --- a/packages/select-rich/test/lion-select-rich.test.js +++ b/packages/select-rich/test/lion-select-rich.test.js @@ -70,7 +70,7 @@ describe('lion-select-rich', () => { expect(el._invokerNode.selectedElement).to.equal(el.querySelectorAll('lion-option')[1]); }); - it('delegates readonly to the invoker, where disabled is added on top of this to disable opening', async () => { + it('delegates readonly to the invoker', async () => { const el = await fixture(html` @@ -81,11 +81,7 @@ describe('lion-select-rich', () => { `); expect(el.hasAttribute('readonly')).to.be.true; - // rich select is not disabled, so value is still serialized in forms when readonly - expect(el.hasAttribute('disabled')).to.be.false; expect(el._invokerNode.hasAttribute('readonly')).to.be.true; - // invoker node has disabled, to disable it from being clicked - expect(el._invokerNode.hasAttribute('disabled')).to.be.true; }); });