ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(icon): non-fatal console error for missing icons (#1884)

Browse source 
* fix(icon): non-fatal console error for missing icons
This commit is contained in:
Joren Broekema 2023-01-23 12:37:18 +01:00 committed by GitHub
parent d204195c16
commit a5330c922c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/cuddly-hats-beg.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': patch
---
Unresolved icons to not cause a fatal error, but console.error instead. Missing assets shouldn't prevent the rest of the application from rendering.

2
package-lock.json generated
View file

@ -22630,7 +22630,7 @@
}, },
"packages/ui": { "packages/ui": {
"name": "@lion/ui", "name": "@lion/ui",
"version": "0.0.12", "version": "0.0.13",
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@bundled-es-modules/message-format": "^6.0.4", "@bundled-es-modules/message-format": "^6.0.4",

15
packages/ui/components/icon/src/LionIcon.js
View file

@ -194,11 +194,18 @@ export class LionIcon extends LitElement {
} }
} else { } else {
const iconIdBeforeResolve = this.iconId; const iconIdBeforeResolve = this.iconId;
const svg = await this._iconManager.resolveIconForId(iconIdBeforeResolve);
// update SVG if it did not change in the meantime to avoid race conditions // Wrap in try-catch so error is non-fatal.
if (this.iconId === iconIdBeforeResolve) { // Failure to load an icon (asset) should not crash the entire app.
this.svg = svg; try {
const svg = await this._iconManager.resolveIconForId(iconIdBeforeResolve);
// update SVG if it did not change in the meantime to avoid race conditions
if (this.iconId === iconIdBeforeResolve) {
this.svg = svg;
}
} catch (e) {
// eslint-disable-next-line no-console
console.error(e);
} }
} }
} }