ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(overlays): check for config contentNode if slot content is undefined

Browse source
This commit is contained in:
Joren Broekema 2020-10-08 15:39:32 +02:00
parent d83f7fc5ce
commit a4c4f1ee8a
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/shiny-cameras-sparkle.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/overlays': patch
---
If a content slot cannot be found, OverlayMixin should check if there is a contentNode imperatively passed through the config.

6
packages/overlays/src/OverlayMixin.js
View file

@ -183,9 +183,9 @@ export const OverlayMixinImplementation = superclass =>
get _overlayContentNode() { get _overlayContentNode() {
if (!this._cachedOverlayContentNode) { if (!this._cachedOverlayContentNode) {
this._cachedOverlayContentNode = Array.from(this.children).find( this._cachedOverlayContentNode =
child => child.slot === 'content', Array.from(this.children).find(child => child.slot === 'content') ||
); this.config.contentNode;
} }
return this._cachedOverlayContentNode; return this._cachedOverlayContentNode;
} }