ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tab): remove scroll while navigating the tabs using up/down arrows (#592)

Browse source
This commit is contained in:
George Serbanescu 2020-02-19 16:44:39 +02:00 committed by Thomas Allmer
parent c8a4c89936
commit 9c6eaf83f1
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/tabs/src/LionTabs.js
View file

@ -25,6 +25,7 @@ const setupButton = ({ element, uid, clickHandler, keydownHandler }) => {
element.setAttribute('aria-controls', `panel-${uid}`); element.setAttribute('aria-controls', `panel-${uid}`);
element.addEventListener('click', clickHandler); element.addEventListener('click', clickHandler);
element.addEventListener('keyup', keydownHandler); element.addEventListener('keyup', keydownHandler);
element.addEventListener('keydown', e => e.preventDefault());
}; };
const cleanButton = (element, clickHandler, keydownHandler) => { const cleanButton = (element, clickHandler, keydownHandler) => {
@ -33,6 +34,7 @@ const cleanButton = (element, clickHandler, keydownHandler) => {
element.removeAttribute('aria-controls'); element.removeAttribute('aria-controls');
element.removeEventListener('click', clickHandler); element.removeEventListener('click', clickHandler);
element.removeEventListener('keyup', keydownHandler); element.removeEventListener('keyup', keydownHandler);
element.removeEventListener('keydown', e => e.preventDefault());
}; };
const selectButton = element => { const selectButton = element => {
@ -168,7 +170,6 @@ export class LionTabs extends LitElement {
switch (e.key) { switch (e.key) {
case 'ArrowDown': case 'ArrowDown':
case 'ArrowRight': case 'ArrowRight':
e.preventDefault();
if (this.selectedIndex + 1 >= this._pairCount) { if (this.selectedIndex + 1 >= this._pairCount) {
this.selectedIndex = 0; this.selectedIndex = 0;
} else { } else {