ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(form-registrar-mixin): ensure becomesReady called only once

Browse source
This commit is contained in:
JaySunSyn 2019-10-10 17:22:56 +02:00
parent 75b3e2c92f
commit 991af25d87
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/field/src/FormRegistrarMixin.js
View file

@ -25,6 +25,7 @@ export const FormRegistrarMixin = dedupeMixin(
super(); super();
this.formElements = []; this.formElements = [];
this.__readyForRegistration = false; this.__readyForRegistration = false;
this.__hasBeenRenedered = false;
this.registrationReady = new Promise(resolve => { this.registrationReady = new Promise(resolve => {
this.__resolveRegistrationReady = resolve; this.__resolveRegistrationReady = resolve;
}); });
@ -38,7 +39,9 @@ export const FormRegistrarMixin = dedupeMixin(
super.connectedCallback(); super.connectedCallback();
} }
formRegistrarManager.add(this); formRegistrarManager.add(this);
formRegistrarManager.becomesReady(this); if (this.__hasBeenRenedered) {
formRegistrarManager.becomesReady(this);
}
} }
disconnectedCallback() { disconnectedCallback() {
@ -57,6 +60,7 @@ export const FormRegistrarMixin = dedupeMixin(
this.__resolveRegistrationReady(); this.__resolveRegistrationReady();
this.__readyForRegistration = true; this.__readyForRegistration = true;
formRegistrarManager.becomesReady(this); formRegistrarManager.becomesReady(this);
this.__hasBeenRenedered = true;
} }
addFormElement(child) { addFormElement(child) {