ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(combobox): fix direct open and closing of the overlay on focus of empty input when showAllOnEmpty

Browse source
This commit is contained in:
gvangeest 2023-02-23 11:34:11 +01:00 committed by Thijs Louisse
parent 44be4edeee
commit 943618fdcb
3 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/chilly-plants-cry.md Normal file
View file

@ -0,0 +1,5 @@
---
'@lion/ui': patch
---
[combobox] fix direct open and closing of the overlay on focus of empty input when `showAllOnEmpty`

1
packages/ui/components/combobox/src/LionCombobox.js
View file

@ -856,6 +856,7 @@ export class LionCombobox extends OverlayMixin(LionListbox) {
...withDropdownConfig(),
elementToFocusAfterHide: undefined,
invokerNode: this._comboboxNode,
visibilityTriggerFunction: undefined,
});
}

19
packages/ui/components/combobox/test/lion-combobox.test.js
View file

@ -670,6 +670,25 @@ describe('lion-combobox', () => {
expect(el.checkedIndex).to.equal(-1);
});
it('has the correct Overlay Config defined', async () => {
const el = /** @type {LionCombobox} */ (
await fixture(html`
<lion-combobox name="foo" .showAllOnEmpty="${true}">
<lion-option .choiceValue="${'Artichoke'}">Artichoke</lion-option>
<lion-option .choiceValue="${'Chard'}">Chard</lion-option>
<lion-option .choiceValue="${'Chicory'}">Chicory</lion-option>
<lion-option .choiceValue="${'Victoria Plum'}">Victoria Plum</lion-option>
</lion-combobox>
`)
);
// @ts-ignore [allow-protected] in test
expect(el._defineOverlayConfig().elementToFocusAfterHide).to.equal(undefined);
// @ts-ignore [allow-protected] in test
expect(el._defineOverlayConfig().invokerNode).to.equal(el._inputNode);
// @ts-ignore [allow-protected] in test
expect(el._defineOverlayConfig().visibilityTriggerFunction).to.equal(undefined);
});
// NB: If this becomes a suite, move to separate file
describe('Subclassers', () => {
it('allows to control overlay visibility via "_showOverlayCondition"', async () => {