ayo/lion
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #995 from palash2601/fix/combobox-modelValue-update

Browse source 
fix(listbox): prevent modelValue change by child components addition
This commit is contained in:
Thijs Louisse 2020-10-06 19:10:07 +02:00 committed by GitHub
commit 942ba65d8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/listbox/src/ListboxMixin.js
View file

@ -670,7 +670,7 @@ const ListboxMixinImplementation = superclass =>
ev.stopPropagation(); ev.stopPropagation();
} }
this.__onChildCheckedChanged(ev); this.__onChildCheckedChanged(ev);
this.requestUpdate('modelValue'); this.requestUpdate('modelValue', this.modelValue);
this.dispatchEvent( this.dispatchEvent(
new CustomEvent('model-value-changed', { detail: { element: ev.target } }), new CustomEvent('model-value-changed', { detail: { element: ev.target } }),
); );