From 9352b577fa79cd688b693e3de8da5db72b6e02bf Mon Sep 17 00:00:00 2001 From: Joren Broekema Date: Mon, 18 Jan 2021 13:41:07 +0100 Subject: [PATCH] fix(overlays): guard for backdrop parent node on teardown --- .changeset/nice-flowers-arrive.md | 5 +++++ packages/overlays/src/OverlayController.js | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/nice-flowers-arrive.md diff --git a/.changeset/nice-flowers-arrive.md b/.changeset/nice-flowers-arrive.md new file mode 100644 index 000000000..16f5b3924 --- /dev/null +++ b/.changeset/nice-flowers-arrive.md @@ -0,0 +1,5 @@ +--- +'@lion/overlays': patch +--- + +Guard backdrop node parentNode when removing the backdrop node on teardown. diff --git a/packages/overlays/src/OverlayController.js b/packages/overlays/src/OverlayController.js index f09371879..8f8bd748e 100644 --- a/packages/overlays/src/OverlayController.js +++ b/packages/overlays/src/OverlayController.js @@ -1016,8 +1016,8 @@ export class OverlayController extends EventTargetShim { this.__backdropNodeToBeTornDown = this.backdropNode; this.__backdropAnimation.then(() => { - if (this.__backdropNodeToBeTornDown) { - /** @type {HTMLElement} */ (this.__backdropNodeToBeTornDown.parentNode).removeChild( + if (this.__backdropNodeToBeTornDown && this.__backdropNodeToBeTornDown.parentNode) { + this.__backdropNodeToBeTornDown.parentNode.removeChild( this.__backdropNodeToBeTornDown, ); }