diff --git a/packages/dialog/test/lion-dialog.test.js b/packages/dialog/test/lion-dialog.test.js index dc9395124..bda0d4d66 100644 --- a/packages/dialog/test/lion-dialog.test.js +++ b/packages/dialog/test/lion-dialog.test.js @@ -3,6 +3,15 @@ import { expect, fixture, html, unsafeStatic } from '@open-wc/testing'; import '../lion-dialog.js'; describe('lion-dialog', () => { + // For some reason, globalRootNode is not cleared properly on disconnectedCallback from previous overlay test fixtures... + // Not sure why this "bug" happens... + beforeEach(() => { + const globalRootNode = document.querySelector('.global-overlays'); + if (globalRootNode) { + globalRootNode.innerHTML = ''; + } + }); + describe('Integration tests', () => { const tagString = 'lion-dialog'; const tag = unsafeStatic(tagString); diff --git a/packages/form-integrations/test/form-reset.test.js b/packages/form-integrations/test/form-reset.test.js index b8bf9f945..bae01453c 100644 --- a/packages/form-integrations/test/form-reset.test.js +++ b/packages/form-integrations/test/form-reset.test.js @@ -1,22 +1,21 @@ -import { elementUpdated, expect, fixture, html } from '@open-wc/testing'; - +import '@lion/button/lion-button'; +import '@lion/checkbox-group/lion-checkbox'; +import '@lion/checkbox-group/lion-checkbox-group'; +import { MinLength, Required } from '@lion/form-core'; +import '@lion/form/lion-form'; import '@lion/input-amount/lion-input-amount'; import '@lion/input-date/lion-input-date'; -import '@lion/textarea/lion-textarea'; import '@lion/input-datepicker/lion-input-datepicker'; import '@lion/input-email/lion-input-email'; import '@lion/input-iban/lion-input-iban'; import '@lion/input-range/lion-input-range'; import '@lion/input/lion-input'; -import '@lion/checkbox-group/lion-checkbox-group'; -import '@lion/checkbox-group/lion-checkbox'; -import '@lion/radio-group/lion-radio-group'; import '@lion/radio-group/lion-radio'; +import '@lion/radio-group/lion-radio-group'; import '@lion/select/lion-select'; import '@lion/switch/lion-switch'; -import '@lion/form/lion-form'; -import '@lion/button/lion-button'; -import { Required, MinLength } from '@lion/form-core'; +import '@lion/textarea/lion-textarea'; +import { elementUpdated, expect, fixture, html } from '@open-wc/testing'; describe(`Submitting/Resetting Form`, async () => { let el; @@ -127,8 +126,6 @@ describe(`Submitting/Resetting Form`, async () => { el.querySelector('#submit_button').click(); await elementUpdated(el); el.formElements.forEach(field => { - console.log(field); - console.log(field.submitted); expect(field.submitted).to.be.true; }); }); diff --git a/packages/localize/test/number/formatNumber.test.js b/packages/localize/test/number/formatNumber.test.js index 610b9793c..17e817e9f 100644 --- a/packages/localize/test/number/formatNumber.test.js +++ b/packages/localize/test/number/formatNumber.test.js @@ -1,8 +1,7 @@ import { expect } from '@open-wc/testing'; import { localize } from '../../src/localize.js'; -import { localizeTearDown } from '../../test-helpers.js'; - import { formatNumber } from '../../src/number/formatNumber.js'; +import { localizeTearDown } from '../../test-helpers.js'; const currencyCode = currency => ({ style: 'currency', currencyDisplay: 'code', currency }); const currencySymbol = currency => ({ style: 'currency', currencyDisplay: 'symbol', currency }); @@ -310,15 +309,17 @@ describe('formatNumber', () => { }); describe('tr-TR', () => { - localize.locale = 'tr-TR'; - expect(formatNumber(123456.789, currencyCode('EUR'))).to.equal('123.456,79 EUR'); - expect(formatNumber(123456.789, currencyCode('USD'))).to.equal('123.456,79 USD'); - expect(formatNumber(123456.789, currencyCode('JPY'))).to.equal('123.457 JPY'); - expect(formatNumber(123456.789, currencyCode('TRY'))).to.equal('123.456,79 TL'); - expect(formatNumber(123456.789, currencySymbol('EUR'))).to.equal('€123.456,79'); - expect(formatNumber(123456.789, currencySymbol('USD'))).to.equal('$123.456,79'); - expect(formatNumber(123456.789, currencySymbol('JPY'))).to.equal('¥123.457'); - expect(formatNumber(123456.789, currencySymbol('TRY'))).to.equal('₺123.456,79'); + it('supports basics', () => { + localize.locale = 'tr-TR'; + expect(formatNumber(123456.789, currencyCode('EUR'))).to.equal('123.456,79 EUR'); + expect(formatNumber(123456.789, currencyCode('USD'))).to.equal('123.456,79 USD'); + expect(formatNumber(123456.789, currencyCode('JPY'))).to.equal('123.457 JPY'); + expect(formatNumber(123456.789, currencyCode('TRY'))).to.equal('123.456,79 TL'); + expect(formatNumber(123456.789, currencySymbol('EUR'))).to.equal('€123.456,79'); + expect(formatNumber(123456.789, currencySymbol('USD'))).to.equal('$123.456,79'); + expect(formatNumber(123456.789, currencySymbol('JPY'))).to.equal('¥123.457'); + expect(formatNumber(123456.789, currencySymbol('TRY'))).to.equal('₺123.456,79'); + }); }); }); }); diff --git a/packages/overlays/test-suites/OverlayMixin.suite.js b/packages/overlays/test-suites/OverlayMixin.suite.js index 3d6f30396..db165174a 100644 --- a/packages/overlays/test-suites/OverlayMixin.suite.js +++ b/packages/overlays/test-suites/OverlayMixin.suite.js @@ -10,23 +10,24 @@ function getGlobalOverlayNodes() { export function runOverlayMixinSuite({ tagString, tag, suffix = '' }) { describe(`OverlayMixin${suffix}`, () => { - let el; - - beforeEach(async () => { - el = await fixture(html` + it('should not be opened by default', async () => { + const el = await fixture(html` <${tag}>