From 9263f39740761da08bc7b7c5a97c0c38168184fc Mon Sep 17 00:00:00 2001
From: Joren Broekema <joren.broekema@ing.com>
Date: Mon, 28 Sep 2020 11:16:27 +0200
Subject: [PATCH] feat(checkbox-group): add types for checkbox-group

---
 .changeset/shaggy-dolls-trade.md              |  5 +++++
 .eslintrc.js                                  |  6 ++++++
 packages/checkbox-group/src/LionCheckbox.js   |  2 +-
 .../checkbox-group/src/LionCheckboxGroup.js   |  4 ++--
 .../test/lion-checkbox-group.test.js          |  9 ++++++++-
 tsconfig.json                                 | 20 ++++++++++---------
 6 files changed, 33 insertions(+), 13 deletions(-)
 create mode 100644 .changeset/shaggy-dolls-trade.md

diff --git a/.changeset/shaggy-dolls-trade.md b/.changeset/shaggy-dolls-trade.md
new file mode 100644
index 000000000..253797d73
--- /dev/null
+++ b/.changeset/shaggy-dolls-trade.md
@@ -0,0 +1,5 @@
+---
+'@lion/checkbox-group': minor
+---
+
+Added types for checkbox-group package.
diff --git a/.eslintrc.js b/.eslintrc.js
index 0f1fa834e..d5293664f 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -1,6 +1,12 @@
 module.exports = {
   extends: ['@open-wc/eslint-config', 'eslint-config-prettier'].map(require.resolve),
   overrides: [
+    {
+      files: ['**/*.js'],
+      rules: {
+        'wc/guard-super-call': 'off', // types will prevent you from calling the super if it's not in the base class, making the guard unnecessary
+      },
+    },
     {
       files: [
         '**/test-suites/**/*.js',
diff --git a/packages/checkbox-group/src/LionCheckbox.js b/packages/checkbox-group/src/LionCheckbox.js
index 002c52b9b..0487e9234 100644
--- a/packages/checkbox-group/src/LionCheckbox.js
+++ b/packages/checkbox-group/src/LionCheckbox.js
@@ -3,7 +3,7 @@ import { ChoiceInputMixin } from '@lion/form-core';
 
 export class LionCheckbox extends ChoiceInputMixin(LionInput) {
   connectedCallback() {
-    if (super.connectedCallback) super.connectedCallback();
+    super.connectedCallback();
     this.type = 'checkbox';
   }
 }
diff --git a/packages/checkbox-group/src/LionCheckboxGroup.js b/packages/checkbox-group/src/LionCheckboxGroup.js
index 682f7988c..c41919f96 100644
--- a/packages/checkbox-group/src/LionCheckboxGroup.js
+++ b/packages/checkbox-group/src/LionCheckboxGroup.js
@@ -3,15 +3,15 @@ import { ChoiceGroupMixin, FormGroupMixin } from '@lion/form-core';
 
 /**
  * A wrapper around multiple checkboxes
- *
- * @extends {LionFieldset}
  */
+// @ts-expect-error https://github.com/microsoft/TypeScript/issues/40110
 export class LionCheckboxGroup extends ChoiceGroupMixin(FormGroupMixin(LitElement)) {
   constructor() {
     super();
     this.multipleChoice = true;
   }
 
+  /** @param {import('lit-element').PropertyValues } changedProperties */
   updated(changedProperties) {
     super.updated(changedProperties);
     if (changedProperties.has('name') && !String(this.name).match(/\[\]$/)) {
diff --git a/packages/checkbox-group/test/lion-checkbox-group.test.js b/packages/checkbox-group/test/lion-checkbox-group.test.js
index 515c4a973..dddbe47d7 100644
--- a/packages/checkbox-group/test/lion-checkbox-group.test.js
+++ b/packages/checkbox-group/test/lion-checkbox-group.test.js
@@ -1,8 +1,15 @@
 import { localizeTearDown } from '@lion/localize/test-helpers.js';
-import { expect, fixture, html } from '@open-wc/testing';
+import { expect, fixture as _fixture, html } from '@open-wc/testing';
 import '../lion-checkbox-group.js';
 import '../lion-checkbox.js';
 
+/**
+ * @typedef {import('../src/LionCheckboxGroup').LionCheckboxGroup} LionCheckboxGroup
+ * @typedef {import('lit-html').TemplateResult} TemplateResult
+ */
+
+const fixture = /** @type {(arg: TemplateResult) => Promise<LionCheckboxGroup>} */ (_fixture);
+
 beforeEach(() => {
   localizeTearDown();
 });
diff --git a/tsconfig.json b/tsconfig.json
index a6837781c..eeaeb5502 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -16,17 +16,19 @@
   },
   "include": [
     "packages/accordion/**/*.js",
-    "packages/core/**/*.js",
-    "packages/tabs/**/*.js",
-    "packages/singleton-manager/**/*.js",
-    "packages/localize/**/*.js",
-    "packages/form-core/**/*.js",
-    "packages/overlays/**/*.js",
-    "packages/tooltip/**/*.js",
     "packages/button/src/**/*.js",
-    "packages/listbox/src/*.js",
+    "packages/checkbox-group/**/*.js",
+    "packages/core/**/*.js",
+    "packages/form-core/**/*.js",
     "packages/input/**/*.js",
-    "packages/input-amount/**/*.js"
+    "packages/input-amount/**/*.js",
+    "packages/listbox/src/*.js",
+    "packages/localize/**/*.js",
+    "packages/overlays/**/*.js",
+    "packages/radio-group/**/*.js",
+    "packages/singleton-manager/**/*.js",
+    "packages/tabs/**/*.js",
+    "packages/tooltip/**/*.js"
   ],
   "exclude": [
     "node_modules",