From 91fad70130fa5828b8f37208686556342cae46d2 Mon Sep 17 00:00:00 2001 From: Thijs Louisse Date: Fri, 8 Mar 2024 10:18:32 +0100 Subject: [PATCH] fix(ui): only use elementToFocusAfterHide when provided as HTMLElement --- .changeset/twelve-deers-punch.md | 5 +++++ packages/ui/components/overlays/src/OverlayController.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/twelve-deers-punch.md diff --git a/.changeset/twelve-deers-punch.md b/.changeset/twelve-deers-punch.md new file mode 100644 index 000000000..5e15d3073 --- /dev/null +++ b/.changeset/twelve-deers-punch.md @@ -0,0 +1,5 @@ +--- +'@lion/ui': patch +--- + +fix: only use elementToFocusAfterHide when provided as HTMLElement diff --git a/packages/ui/components/overlays/src/OverlayController.js b/packages/ui/components/overlays/src/OverlayController.js index d88f6f5aa..c2801589b 100644 --- a/packages/ui/components/overlays/src/OverlayController.js +++ b/packages/ui/components/overlays/src/OverlayController.js @@ -931,7 +931,7 @@ export class OverlayController extends EventTarget { return; } - if (this.elementToFocusAfterHide) { + if (this.elementToFocusAfterHide instanceof HTMLElement) { this.elementToFocusAfterHide.focus(); this.elementToFocusAfterHide.scrollIntoView({ block: 'nearest' }); } else {